From: Shahaf Shuler <shahafs@mellanox.com>
To: Yongseok Koh <yskoh@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 1/4] net/mlx5: fix memory event on secondary process
Date: Tue, 26 Mar 2019 12:28:02 +0000 [thread overview]
Message-ID: <AM0PR0502MB3795FBEF7C702D667620AFF0C35F0@AM0PR0502MB3795.eurprd05.prod.outlook.com> (raw)
Message-ID: <20190326122802.1BCGLaX51L-MsnG68AovYABozrhKYExvSnyvMauIek8@z> (raw)
In-Reply-To: <20190325191545.20707-2-yskoh@mellanox.com>
Monday, March 25, 2019 9:16 PM, Yongseok Koh:
> Subject: [dpdk-dev] [PATCH v2 1/4] net/mlx5: fix memory event on
> secondary process
>
> As the memory event is propagated to secondary processes, the event is
> processed redundantly. This should be processed once because the data
> structure used for MR and the event is global across the processes.
>
> Fixes: 974f1e7ef146 ("net/mlx5: add new memory region support")
> Cc: stable@dpdk.org
>
> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
Acked-by: Shahaf Shuler <shahafs@mellanox.com>
> ---
> drivers/net/mlx5/mlx5.c | 5 +++--
> drivers/net/mlx5/mlx5_mr.c | 2 ++
> 2 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index
> ae4b71695e..dd29eba955 100644
> --- a/drivers/net/mlx5/mlx5.c
> +++ b/drivers/net/mlx5/mlx5.c
> @@ -157,9 +157,10 @@ mlx5_prepare_shared_data(void)
> if (rte_eal_process_type() == RTE_PROC_PRIMARY) {
> LIST_INIT(&mlx5_shared_data-
> >mem_event_cb_list);
> rte_rwlock_init(&mlx5_shared_data-
> >mem_event_rwlock);
> +
> rte_mem_event_callback_register("MLX5_MEM_EVENT_CB",
> +
> mlx5_mr_mem_event_cb,
> + NULL);
> }
> -
> rte_mem_event_callback_register("MLX5_MEM_EVENT_CB",
> - mlx5_mr_mem_event_cb,
> NULL);
> }
> rte_spinlock_unlock(&mlx5_shared_data_lock);
> }
> diff --git a/drivers/net/mlx5/mlx5_mr.c b/drivers/net/mlx5/mlx5_mr.c index
> 700d83d1bc..d336a77e40 100644
> --- a/drivers/net/mlx5/mlx5_mr.c
> +++ b/drivers/net/mlx5/mlx5_mr.c
> @@ -891,6 +891,8 @@ mlx5_mr_mem_event_cb(enum rte_mem_event
> event_type, const void *addr,
> struct mlx5_priv *priv;
> struct mlx5_dev_list *dev_list = &mlx5_shared_data-
> >mem_event_cb_list;
>
> + /* Must be called from the primary process. */
> + assert(rte_eal_process_type() == RTE_PROC_PRIMARY);
> switch (event_type) {
> case RTE_MEM_EVENT_FREE:
> rte_rwlock_write_lock(&mlx5_shared_data-
> >mem_event_rwlock);
> --
> 2.11.0
next prev parent reply other threads:[~2019-03-26 12:28 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-07 7:33 [dpdk-dev] [PATCH 0/4] net/mlx5: rework IPC socket and PMD global data init Yongseok Koh
2019-03-07 7:33 ` [dpdk-dev] [PATCH 1/4] net/mlx5: fix memory event on secondary process Yongseok Koh
2019-03-07 7:33 ` [dpdk-dev] [PATCH 2/4] net/mlx5: replace IPC socket with EAL API Yongseok Koh
2019-03-14 12:36 ` Shahaf Shuler
2019-03-14 12:36 ` Shahaf Shuler
2019-03-18 21:29 ` Yongseok Koh
2019-03-18 21:29 ` Yongseok Koh
2019-03-07 7:33 ` [dpdk-dev] [PATCH 3/4] net/mlx5: rework PMD global data init Yongseok Koh
2019-03-14 12:36 ` Shahaf Shuler
2019-03-14 12:36 ` Shahaf Shuler
2019-03-18 21:21 ` Yongseok Koh
2019-03-18 21:21 ` Yongseok Koh
2019-03-19 6:54 ` Shahaf Shuler
2019-03-19 6:54 ` Shahaf Shuler
2019-03-07 7:33 ` [dpdk-dev] [PATCH 4/4] net/mlx5: sync stop/start of datapath with secondary process Yongseok Koh
2019-03-25 19:15 ` [dpdk-dev] [PATCH v2 0/4] net/mlx5: rework IPC socket and PMD global data init Yongseok Koh
2019-03-25 19:15 ` Yongseok Koh
2019-03-25 19:15 ` [dpdk-dev] [PATCH v2 1/4] net/mlx5: fix memory event on secondary process Yongseok Koh
2019-03-25 19:15 ` Yongseok Koh
2019-03-26 12:28 ` Shahaf Shuler [this message]
2019-03-26 12:28 ` Shahaf Shuler
2019-03-25 19:15 ` [dpdk-dev] [PATCH v2 2/4] net/mlx5: replace IPC socket with EAL API Yongseok Koh
2019-03-25 19:15 ` Yongseok Koh
2019-03-26 12:31 ` Shahaf Shuler
2019-03-26 12:31 ` Shahaf Shuler
2019-03-25 19:15 ` [dpdk-dev] [PATCH v2 3/4] net/mlx5: rework PMD global data init Yongseok Koh
2019-03-25 19:15 ` Yongseok Koh
2019-03-26 12:38 ` Shahaf Shuler
2019-03-26 12:38 ` Shahaf Shuler
2019-03-25 19:15 ` [dpdk-dev] [PATCH v2 4/4] net/mlx5: sync stop/start of datapath with secondary process Yongseok Koh
2019-03-25 19:15 ` Yongseok Koh
2019-03-26 12:49 ` Shahaf Shuler
2019-03-26 12:49 ` Shahaf Shuler
2019-04-01 21:12 ` [dpdk-dev] [PATCH v3 0/4] net/mlx5: rework IPC socket and PMD global data init Yongseok Koh
2019-04-01 21:12 ` Yongseok Koh
2019-04-01 21:12 ` [dpdk-dev] [PATCH v3 1/4] net/mlx5: fix memory event on secondary process Yongseok Koh
2019-04-01 21:12 ` Yongseok Koh
2019-04-01 21:12 ` [dpdk-dev] [PATCH v3 2/4] net/mlx5: replace IPC socket with EAL API Yongseok Koh
2019-04-01 21:12 ` Yongseok Koh
2019-04-01 21:12 ` [dpdk-dev] [PATCH v3 3/4] net/mlx5: rework PMD global data init Yongseok Koh
2019-04-01 21:12 ` Yongseok Koh
2019-04-01 21:12 ` [dpdk-dev] [PATCH v3 4/4] net/mlx5: sync stop/start of datapath with secondary process Yongseok Koh
2019-04-01 21:12 ` Yongseok Koh
2019-04-02 7:11 ` [dpdk-dev] [PATCH v3 0/4] net/mlx5: rework IPC socket and PMD global data init Shahaf Shuler
2019-04-02 7:11 ` Shahaf Shuler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR0502MB3795FBEF7C702D667620AFF0C35F0@AM0PR0502MB3795.eurprd05.prod.outlook.com \
--to=shahafs@mellanox.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).