From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Wang, Xiao W" <xiao.w.wang@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 1/2] app/testpmd: fix tx vlan and qinq dependency
Date: Tue, 26 Mar 2019 17:33:16 +0000 [thread overview]
Message-ID: <8CEF83825BEC744B83065625E567D7C260D76A03@IRSMSX108.ger.corp.intel.com> (raw)
Message-ID: <20190326173316.u2RGazj6eDKc_Qmu7GheKOu6amMpf3euGW1B3_8vZTc@z> (raw)
In-Reply-To: <2df6ee75-8330-7e3e-673c-71b030a57416@intel.com>
Hi Nithin
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Thursday, March 21, 2019 5:11 PM
> To: Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>; Lu, Wenzhuo
> <wenzhuo.lu@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; Iremonger,
> Bernard <bernard.iremonger@intel.com>
> Cc: dev@dpdk.org; Wang, Xiao W <xiao.w.wang@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v2 1/2] app/testpmd: fix tx vlan and qinq
> dependency
>
> On 3/18/2019 9:56 AM, Nithin Kumar Dabilpuram wrote:
> > Tx VLAN & QinQ insert enable need not depend on Rx VLAN offload
> > ETH_VLAN_EXTEND_OFFLOAD.
> >
> > Fixes: 6a34f91690d0 ("app/testpmd: fix error message when setting Tx
> > VLAN")
> > Cc: xiao.w.wang@intel.com
> >
> > Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
>
> <...>
>
> > @@ -2963,11 +2962,6 @@ tx_vlan_set(portid_t port_id, uint16_t vlan_id)
> > if (vlan_id_is_invalid(vlan_id))
> > return;
> >
> > - vlan_offload = rte_eth_dev_get_vlan_offload(port_id);
> > - if (vlan_offload & ETH_VLAN_EXTEND_OFFLOAD) {
> > - printf("Error, as QinQ has been enabled.\n");
> > - return;
> > - }
>
> It looks like you didn't take account comment on this in previous version, can
> you please check it?
./dpdk/devtools/check-git-log.sh -1
Wrong headline lowercase:
app/testpmd: fix tx vlan and qinq dependency
otherwise
acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
next prev parent reply other threads:[~2019-03-26 17:33 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-19 6:48 [dpdk-dev] [PATCH] app/testpmd: fix tx vlan and qinq insert enable Nithin Kumar Dabilpuram
2019-03-01 16:29 ` Ferruh Yigit
2019-03-18 9:56 ` [dpdk-dev] [PATCH v2 1/2] app/testpmd: fix tx vlan and qinq dependency Nithin Kumar Dabilpuram
2019-03-18 9:56 ` Nithin Kumar Dabilpuram
2019-03-18 9:56 ` [dpdk-dev] [PATCH v2 2/2] app/testpmd: fix tx qinq insert enable Nithin Kumar Dabilpuram
2019-03-18 9:56 ` Nithin Kumar Dabilpuram
2019-03-26 17:40 ` Iremonger, Bernard
2019-03-26 17:40 ` Iremonger, Bernard
2019-03-21 17:11 ` [dpdk-dev] [PATCH v2 1/2] app/testpmd: fix tx vlan and qinq dependency Ferruh Yigit
2019-03-21 17:11 ` Ferruh Yigit
2019-03-26 17:33 ` Iremonger, Bernard [this message]
2019-03-26 17:33 ` Iremonger, Bernard
2019-03-27 9:52 ` Iremonger, Bernard
2019-03-27 9:52 ` Iremonger, Bernard
2019-03-31 18:58 ` [dpdk-dev] [EXT] " Nithin Kumar Dabilpuram
2019-03-31 18:58 ` Nithin Kumar Dabilpuram
2019-04-01 19:10 ` Ferruh Yigit
2019-04-01 19:10 ` Ferruh Yigit
2019-04-02 2:35 ` Wang, Xiao W
2019-04-02 2:35 ` Wang, Xiao W
2019-04-05 7:36 ` [dpdk-dev] [PATCH v3 1/2] app/testpmd: fix Tx VLAN and QinQ dependency Nithin Kumar Dabilpuram
2019-04-05 7:36 ` Nithin Kumar Dabilpuram
2019-04-05 7:36 ` [dpdk-dev] [PATCH v3 2/2] app/testpmd: fix Tx QinQ set Nithin Kumar Dabilpuram
2019-04-05 7:36 ` Nithin Kumar Dabilpuram
2019-04-05 13:36 ` [dpdk-dev] [PATCH v3 1/2] app/testpmd: fix Tx VLAN and QinQ dependency Ferruh Yigit
2019-04-05 13:36 ` Ferruh Yigit
2019-04-05 12:04 ` [dpdk-dev] [PATCH v4 " Nithin Dabilpuram
2019-04-05 12:04 ` Nithin Dabilpuram
2019-04-05 12:04 ` [dpdk-dev] [PATCH v4 2/2] app/testpmd: fix Tx QinQ set Nithin Dabilpuram
2019-04-05 12:04 ` Nithin Dabilpuram
2019-04-05 12:06 ` [dpdk-dev] [PATCH v4 1/2] app/testpmd: fix Tx VLAN and QinQ dependency Ferruh Yigit
2019-04-05 12:06 ` Ferruh Yigit
2019-04-05 13:10 ` Nithin Kumar D
2019-04-05 13:10 ` Nithin Kumar D
2019-04-05 13:32 ` Ferruh Yigit
2019-04-05 13:32 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8CEF83825BEC744B83065625E567D7C260D76A03@IRSMSX108.ger.corp.intel.com \
--to=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jingjing.wu@intel.com \
--cc=ndabilpuram@marvell.com \
--cc=wenzhuo.lu@intel.com \
--cc=xiao.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).