From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Fan Zhang <roy.fan.zhang@intel.com>, dev@dpdk.org
Cc: stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] vhost/crypto: fix coverity issues
Date: Wed, 27 Mar 2019 11:18:01 +0100 [thread overview]
Message-ID: <ea2a4ccc-828f-8097-56c8-fa0e401da672@redhat.com> (raw)
Message-ID: <20190327101801.hbzsuXhom8IxuUlN1LzJYZ9m7z1JR5fREwCZy_JX0FA@z> (raw)
In-Reply-To: <20190325143731.6488-1-roy.fan.zhang@intel.com>
On 3/25/19 3:37 PM, Fan Zhang wrote:
> Fixes: cd1e8f03abf0 ("vhost/crypto: fix packet copy in chaining mode")
>
> Coverity Issue: 277214
> Coverity Issue: 277220
> Coverity Issue: 277233
> Coverity Issue: 277236
>
> Cc: stable@dpdk.org
>
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
> lib/librte_vhost/vhost_crypto.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_vhost/vhost_crypto.c b/lib/librte_vhost/vhost_crypto.c
> index 9b4b850e8..0edf12d52 100644
> --- a/lib/librte_vhost/vhost_crypto.c
> +++ b/lib/librte_vhost/vhost_crypto.c
> @@ -1109,7 +1109,7 @@ prepare_sym_chain_op(struct vhost_crypto *vcrypto, struct rte_crypto_op *op,
>
> if (unlikely(copy_data(digest_addr, vc_req, &digest_desc,
> chain->para.hash_result_len,
> - nb_descs, vq_size)) < 0) {
> + nb_descs, vq_size) < 0)) {
> ret = VIRTIO_CRYPTO_BADMSG;
> goto error_exit;
> }
> @@ -1627,7 +1627,7 @@ rte_vhost_crypto_fetch_requests(int vid, uint32_t qid,
> op->sym->m_src->data_off = 0;
>
> if (unlikely(vhost_crypto_process_one_req(vcrypto, vq,
> - op, head, desc_idx)) < 0)
> + op, head, desc_idx) < 0))
> break;
> }
>
>
Good catch from Coverity!
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
next prev parent reply other threads:[~2019-03-27 10:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 14:37 Fan Zhang
2019-03-25 14:37 ` Fan Zhang
2019-03-27 10:18 ` Maxime Coquelin [this message]
2019-03-27 10:18 ` Maxime Coquelin
2019-03-27 11:14 ` Maxime Coquelin
2019-03-27 11:14 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea2a4ccc-828f-8097-56c8-fa0e401da672@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=roy.fan.zhang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).