From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: "Stojaczyk, Dariusz" <dariusz.stojaczyk@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] eal: initialize alarms early
Date: Thu, 28 Mar 2019 11:46:22 +0100 [thread overview]
Message-ID: <2018712.ubzJDVHxhL@xps> (raw)
Message-ID: <20190328104622.68N7yZ-PXuaNBwaNeEYRRgLdKn3VInVCbnRtu2WtOnE@z> (raw)
In-Reply-To: <20190328104313.GA1418@bricha3-MOBL.ger.corp.intel.com>
28/03/2019 11:43, Bruce Richardson:
> On Wed, Mar 27, 2019 at 11:42:40PM +0100, Thomas Monjalon wrote:
> > 27/03/2019 21:33, Stojaczyk, Dariusz:
> > > From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > > > 26/03/2019 19:43, Darek Stojaczyk:
> > > > > We currently initialize rte_alarms after starting
> > > > > to listen for IPC hotplug requests, which gives
> > > > > us a data race window. Upon receiving such hotplug
> > > > > request we always try to set an alarm and this
> > > > > obviously doesn't work if the alarms weren't
> > > > > initialized yet.
> > > > >
> > > > > To fix it, we initialize alarms before starting
> > > > > to listen for IPC hotplug messages. Specifically,
> > > > > we move rte_eal_alarm_init() right after
> > > > > rte_eal_intr_init() as it makes some sense to
> > > > > keep those two close to each other.
> > > >
> > > > I wonder which regression it will bring :)
> > > > The experience shows that we cannot touch this function
> > > > without introducing a regression. Please check twice.
> > >
> > > Hah, ok - I'll check again the possible outcomes of this.
> > >
> > > >
> > > > > Fixes: 244d5130719c ("eal: enable hotplug on multi-process")
> > > > > Cc: Qi Zhang <qi.z.zhang@intel.com>
> > > > > Cc: Anatoly Burakov <anatoly.burakov@intel.com>
> > > > > Cc: stable@dpdk.org
> > > > >
> > > > > Signed-off-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
> > > > > ---
> > > > > lib/librte_eal/linux/eal/eal.c | 12 ++++++------
> > > > > 1 file changed, 6 insertions(+), 6 deletions(-)
> > > >
> > > > You probably need to update the FreeBSD version too.
> > > >
> > >
> > > Oh, that I cannot do. First of all, in bsd code I don't see
> > > rte_mp_dev_hotplug_init() called anywhere, as if bsd
> > > did not listen for IPC hotplug messages at all and hence did
> > > not have any data race in this area. Second, I would be
> > > afraid to touch any bsd code as I'm not running any bsd
> > > system.
> >
> > The problem is the consistency between OSes.
> > May you ask help here? Bruce is maintaining the FreeBSD side.
> >
> I don't think we support IPC or hotplug on BSD, so I don't think this patch
> is relevant on the BSD side.
Yes, but then, the initialization order is different on Linux and BSD.
I'm thinking about consistency and maintenance ease.
next prev parent reply other threads:[~2019-03-28 10:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-26 18:43 Darek Stojaczyk
2019-03-26 18:43 ` Darek Stojaczyk
2019-03-27 18:11 ` Thomas Monjalon
2019-03-27 18:11 ` Thomas Monjalon
2019-03-27 20:33 ` Stojaczyk, Dariusz
2019-03-27 20:33 ` Stojaczyk, Dariusz
2019-03-27 22:42 ` Thomas Monjalon
2019-03-27 22:42 ` Thomas Monjalon
2019-03-28 10:43 ` Bruce Richardson
2019-03-28 10:43 ` Bruce Richardson
2019-03-28 10:46 ` Thomas Monjalon [this message]
2019-03-28 10:46 ` Thomas Monjalon
2019-03-28 13:14 ` Burakov, Anatoly
2019-03-28 13:14 ` Burakov, Anatoly
2019-04-01 14:22 ` Stojaczyk, Dariusz
2019-04-01 14:22 ` Stojaczyk, Dariusz
2019-04-01 14:18 ` [dpdk-dev] [PATCH v2] " Darek Stojaczyk
2019-04-01 14:18 ` Darek Stojaczyk
2019-04-02 13:01 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2019-04-02 13:01 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2018712.ubzJDVHxhL@xps \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dariusz.stojaczyk@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).