From: "Eads, Gage" <gage.eads@intel.com>
To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "olivier.matz@6wind.com" <olivier.matz@6wind.com>,
"arybchenko@solarflare.com" <arybchenko@solarflare.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"Gavin Hu (Arm Technology China)" <Gavin.Hu@arm.com>,
nd <nd@arm.com>, "thomas@monjalon.net" <thomas@monjalon.net>,
nd <nd@arm.com>, Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH v3 1/8] stack: introduce rte stack library
Date: Fri, 29 Mar 2019 19:23:37 +0000 [thread overview]
Message-ID: <9184057F7FC11744A2107296B6B8EB1E5420D923@FMSMSX108.amr.corp.intel.com> (raw)
Message-ID: <20190329192337.CKKAzdapXFFYWvFybiNkE-__-1C57Smk9bXZxwqN15M@z> (raw)
In-Reply-To: <VE1PR08MB5149B4FD26B816BA51F7B58998590@VE1PR08MB5149.eurprd08.prod.outlook.com>
@Thomas: I expect I can address Honnappa's feedback within a day or two. Since today is the 19.05 merge deadline, what do you think about these options for merging?
1. Merge V4 now and address these comments during RC1.
2. Delay merge until RC2, with all comments addressed.
In terms of risk, Honnappa identified an incorrect memory ordering argument (patch 6/8), but that doesn't affect the one platform (x86-64) that can (currently) use this library. His other comments address readability, error-checking, and performance, but aren't critical. Beyond that, this patchset is isolated from the rest of DPDK. So, I think the risk to the project is very low.
(Also, note that I accidentally left off Olivier's Reviewed-by tag in V4's patches 1, 3, 5, and 6 -- I'll address that as well)
> -----Original Message-----
> From: Honnappa Nagarahalli [mailto:Honnappa.Nagarahalli@arm.com]
> Sent: Thursday, March 28, 2019 6:27 PM
> To: Eads, Gage <gage.eads@intel.com>; dev@dpdk.org
> Cc: olivier.matz@6wind.com; arybchenko@solarflare.com; Richardson, Bruce
> <bruce.richardson@intel.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>; Gavin Hu (Arm Technology China)
> <Gavin.Hu@arm.com>; nd <nd@arm.com>; thomas@monjalon.net; nd
> <nd@arm.com>
> Subject: RE: [PATCH v3 1/8] stack: introduce rte stack library
>
> Hi Gage,
> Apologies for the late comments.
>
No problem, I appreciate the feedback.
[snip]
> > +static ssize_t
> > +rte_stack_get_memsize(unsigned int count) {
> > + ssize_t sz = sizeof(struct rte_stack);
> > +
> > + /* Add padding to avoid false sharing conflicts */
> > + sz += RTE_CACHE_LINE_ROUNDUP(count * sizeof(void *)) +
> > + 2 * RTE_CACHE_LINE_SIZE;
> I did not understand how the false sharing is caused and how this padding is
> solving the issue. Verbose comments would help.
The additional padding (beyond the CACHE_LINE_ROUNDUP) is to prevent false sharing caused by adjacent/next-line hardware prefetchers. I'll address this.
[snip]
> > +struct rte_stack *
> > +rte_stack_create(const char *name, unsigned int count, int socket_id,
> > + uint32_t flags)
> > +{
> > + char mz_name[RTE_MEMZONE_NAMESIZE];
> > + struct rte_stack_list *stack_list;
> > + const struct rte_memzone *mz;
> > + struct rte_tailq_entry *te;
> > + struct rte_stack *s;
> > + unsigned int sz;
> > + int ret;
> > +
> > + RTE_SET_USED(flags);
> > +
> > + sz = rte_stack_get_memsize(count);
> > +
> > + ret = snprintf(mz_name, sizeof(mz_name), "%s%s",
> > + RTE_STACK_MZ_PREFIX, name);
> > + if (ret < 0 || ret >= (int)sizeof(mz_name)) {
> > + rte_errno = ENAMETOOLONG;
> > + return NULL;
> > + }
> > +
> > + te = rte_zmalloc("STACK_TAILQ_ENTRY", sizeof(*te), 0);
> > + if (te == NULL) {
> > + STACK_LOG_ERR("Cannot reserve memory for tailq\n");
> > + rte_errno = ENOMEM;
> > + return NULL;
> > + }
> > +
> > + rte_rwlock_write_lock(RTE_EAL_TAILQ_RWLOCK);
> > +
> I think there is a need to check if a stack with the same name exists already.
rte_memzone_reserve_aligned() does just that. This behavior is tested in the function test_stack_name_reuse(), added in commit " test/stack: add stack test".
> > + mz = rte_memzone_reserve_aligned(mz_name, sz, socket_id,
> > + 0, __alignof__(*s));
> > + if (mz == NULL) {
> > + STACK_LOG_ERR("Cannot reserve stack memzone!\n");
> > + rte_rwlock_write_unlock(RTE_EAL_TAILQ_RWLOCK);
> > + rte_free(te);
> > + return NULL;
> > + }
[snip]
> > +void
> > +rte_stack_free(struct rte_stack *s)
> > +{
> > + struct rte_stack_list *stack_list;
> > + struct rte_tailq_entry *te;
> > +
> > + if (s == NULL)
> > + return;
> > +
> Adding a check to make sure the length of the stack is 0 would help catch
> issues?
My preference is to leave that check to the user, for any apps that want to/can safely free non-empty stacks.
[snip]
> > +#define RTE_TAILQ_STACK_NAME "RTE_STACK"
> > +#define RTE_STACK_MZ_PREFIX "STK_"
> Nit, "STACK_" would be easier to debug
Since RTE_MEMZONE_NAMESIZE (32) doesn't give us a lot of space, I kept the prefix short. Adding 2 more characters *probably* won't make a difference...but I'd prefer the shortened name.
> > +/** The maximum length of a stack name. */ #define
> RTE_STACK_NAMESIZE
> > +(RTE_MEMZONE_NAMESIZE - \
> > + sizeof(RTE_STACK_MZ_PREFIX) + 1)
> > +
[snip]
> > +/**
> > + * @internal Push several objects on the stack (MT-safe).
> > + *
> > + * @param s
> > + * A pointer to the stack structure.
> > + * @param obj_table
> > + * A pointer to a table of void * pointers (objects).
> > + * @param n
> > + * The number of objects to push on the stack from the obj_table.
> > + * @return
> > + * Actual number of objects pushed (either 0 or *n*).
> > + */
> > +static __rte_always_inline unsigned int __rte_experimental
> This is an internal function. Is '__rte_experimental' tag required?
I don't think so, but I erred on the side of caution. I don't think the tag causes any problems.
>
> > +rte_stack_std_push(struct rte_stack *s, void * const *obj_table,
> > +unsigned int n) {
> Since this is an internal function, does it make sense to add '__' to the
> beginning of the function name (similar to what is done in rte_ring?).
Makes sense. I'll address this.
[snip]
> > +/**
> > + * @internal Pop several objects from the stack (MT-safe).
> > + *
> > + * @param s
> > + * A pointer to the stack structure.
> > + * @param obj_table
> > + * A pointer to a table of void * pointers (objects).
> > + * @param n
> > + * The number of objects to pull from the stack.
> > + * @return
> > + * Actual number of objects popped (either 0 or *n*).
> > + */
> > +static __rte_always_inline unsigned int __rte_experimental
> This is an internal function. Is '__rte_experimental' tag required?
(see above)
[snip]
> > +static __rte_always_inline unsigned int __rte_experimental
> > +rte_stack_pop(struct rte_stack *s, void **obj_table, unsigned int n) {
> > + if (unlikely(n == 0 || obj_table == NULL))
> > + return 0;
> 's == NULL' can be added as well. Similar check is missing in 'rte_stack_push'.
> Since these are data-path APIs, RTE_ASSERT would be better.
>
Good point. I'll add RTE_ASSERT for obj_table and s. That won't work for "n == 0" -- the pop code assumes n > 0, so we can't allow that check to be compiled out.
[snip]
> > +/**
> > + * @warning
> > + * @b EXPERIMENTAL: this API may change without prior notice
> > + *
> > + * Create a new stack named *name* in memory.
> > + *
> > + * This function uses ``memzone_reserve()`` to allocate memory for a
> > +stack of
> > + * size *count*. The behavior of the stack is controlled by the *flags*.
> > + *
> > + * @param name
> > + * The name of the stack.
> > + * @param count
> > + * The size of the stack.
> > + * @param socket_id
> > + * The *socket_id* argument is the socket identifier in case of
> > + * NUMA. The value can be *SOCKET_ID_ANY* if there is no NUMA
> > + * constraint for the reserved zone.
> > + * @param flags
> > + * Reserved for future use.
> > + * @return
> > + * On success, the pointer to the new allocated stack. NULL on error with
> > + * rte_errno set appropriately. Possible errno values include:
> > + * - ENOSPC - the maximum number of memzones has already been
> > allocated
> > + * - EEXIST - a stack with the same name already exists
> This is not implemented currently
It is -- see above.
Thanks,
Gage
next prev parent reply other threads:[~2019-03-29 19:23 UTC|newest]
Thread overview: 228+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 16:06 [dpdk-dev] [PATCH 0/7] Subject: [PATCH ...] Add stack library and new mempool handler Gage Eads
2019-02-22 16:06 ` [dpdk-dev] [PATCH 1/7] stack: introduce rte stack library Gage Eads
2019-02-25 10:43 ` Olivier Matz
2019-02-28 5:10 ` Eads, Gage
2019-02-22 16:06 ` [dpdk-dev] [PATCH 2/7] mempool/stack: convert mempool to use rte stack Gage Eads
2019-02-25 10:46 ` Olivier Matz
2019-02-22 16:06 ` [dpdk-dev] [PATCH 3/7] test/stack: add stack test Gage Eads
2019-02-25 10:59 ` Olivier Matz
2019-02-28 5:11 ` Eads, Gage
2019-02-22 16:06 ` [dpdk-dev] [PATCH 4/7] test/stack: add stack perf test Gage Eads
2019-02-25 11:04 ` Olivier Matz
2019-02-22 16:06 ` [dpdk-dev] [PATCH 5/7] stack: add non-blocking stack implementation Gage Eads
2019-02-25 11:28 ` Olivier Matz
[not found] ` <2EC44CCD3517A842B44C82651A5557A14AF13386@fmsmsx118.amr.corp.intel.com>
2019-03-01 20:53 ` [dpdk-dev] FW: " Eads, Gage
2019-03-01 21:12 ` Thomas Monjalon
2019-03-01 21:29 ` Eads, Gage
2019-02-22 16:06 ` [dpdk-dev] [PATCH 6/7] test/stack: add non-blocking stack tests Gage Eads
2019-02-25 11:28 ` Olivier Matz
2019-02-22 16:06 ` [dpdk-dev] [PATCH 7/7] mempool/stack: add non-blocking stack mempool handler Gage Eads
2019-02-25 11:29 ` Olivier Matz
2019-03-05 16:42 ` [dpdk-dev] [PATCH v2 0/8] Add stack library and new " Gage Eads
2019-03-05 16:42 ` [dpdk-dev] [PATCH v2 1/8] stack: introduce rte stack library Gage Eads
2019-03-05 16:42 ` [dpdk-dev] [PATCH v2 2/8] mempool/stack: convert mempool to use rte stack Gage Eads
2019-03-05 16:42 ` [dpdk-dev] [PATCH v2 3/8] test/stack: add stack test Gage Eads
2019-03-05 16:42 ` [dpdk-dev] [PATCH v2 4/8] test/stack: add stack perf test Gage Eads
2019-03-05 16:42 ` [dpdk-dev] [PATCH v2 5/8] stack: add lock-free stack implementation Gage Eads
2019-03-05 16:42 ` [dpdk-dev] [PATCH v2 6/8] stack: add C11 atomic implementation Gage Eads
2019-03-05 16:42 ` [dpdk-dev] [PATCH v2 7/8] test/stack: add lock-free stack tests Gage Eads
2019-03-05 16:42 ` [dpdk-dev] [PATCH v2 8/8] mempool/stack: add lock-free stack mempool handler Gage Eads
2019-03-06 14:45 ` [dpdk-dev] [PATCH v3 0/8] Add stack library and new " Gage Eads
2019-03-06 14:45 ` [dpdk-dev] [PATCH v3 1/8] stack: introduce rte stack library Gage Eads
2019-03-14 8:00 ` Olivier Matz
2019-03-14 8:00 ` Olivier Matz
2019-03-28 23:26 ` Honnappa Nagarahalli
2019-03-28 23:26 ` Honnappa Nagarahalli
2019-03-29 19:23 ` Eads, Gage [this message]
2019-03-29 19:23 ` Eads, Gage
2019-03-29 21:07 ` Thomas Monjalon
2019-03-29 21:07 ` Thomas Monjalon
2019-04-01 17:41 ` Honnappa Nagarahalli
2019-04-01 17:41 ` Honnappa Nagarahalli
2019-04-01 19:34 ` Eads, Gage
2019-04-01 19:34 ` Eads, Gage
2019-03-06 14:45 ` [dpdk-dev] [PATCH v3 2/8] mempool/stack: convert mempool to use rte stack Gage Eads
2019-03-06 14:45 ` [dpdk-dev] [PATCH v3 3/8] test/stack: add stack test Gage Eads
2019-03-14 8:00 ` Olivier Matz
2019-03-14 8:00 ` Olivier Matz
2019-03-06 14:45 ` [dpdk-dev] [PATCH v3 4/8] test/stack: add stack perf test Gage Eads
2019-03-06 14:45 ` [dpdk-dev] [PATCH v3 5/8] stack: add lock-free stack implementation Gage Eads
2019-03-14 8:01 ` Olivier Matz
2019-03-14 8:01 ` Olivier Matz
2019-03-28 23:27 ` Honnappa Nagarahalli
2019-03-28 23:27 ` Honnappa Nagarahalli
2019-03-29 19:25 ` Eads, Gage
2019-03-29 19:25 ` Eads, Gage
2019-03-06 14:45 ` [dpdk-dev] [PATCH v3 6/8] stack: add C11 atomic implementation Gage Eads
2019-03-14 8:04 ` Olivier Matz
2019-03-14 8:04 ` Olivier Matz
2019-03-28 23:27 ` Honnappa Nagarahalli
2019-03-28 23:27 ` Honnappa Nagarahalli
2019-03-29 19:24 ` Eads, Gage
2019-03-29 19:24 ` Eads, Gage
2019-04-01 0:06 ` Eads, Gage
2019-04-01 0:06 ` Eads, Gage
2019-04-01 19:06 ` Honnappa Nagarahalli
2019-04-01 19:06 ` Honnappa Nagarahalli
2019-04-01 20:21 ` Eads, Gage
2019-04-01 20:21 ` Eads, Gage
2019-03-06 14:45 ` [dpdk-dev] [PATCH v3 7/8] test/stack: add lock-free stack tests Gage Eads
2019-03-06 14:45 ` [dpdk-dev] [PATCH v3 8/8] mempool/stack: add lock-free stack mempool handler Gage Eads
2019-03-28 18:00 ` [dpdk-dev] [PATCH v4 0/8] Add stack library and new " Gage Eads
2019-03-28 18:00 ` Gage Eads
2019-03-28 18:00 ` [dpdk-dev] [PATCH v4 1/8] stack: introduce rte stack library Gage Eads
2019-03-28 18:00 ` Gage Eads
2019-03-28 18:00 ` [dpdk-dev] [PATCH v4 2/8] mempool/stack: convert mempool to use rte stack Gage Eads
2019-03-28 18:00 ` Gage Eads
2019-03-28 18:00 ` [dpdk-dev] [PATCH v4 3/8] test/stack: add stack test Gage Eads
2019-03-28 18:00 ` Gage Eads
2019-03-28 18:00 ` [dpdk-dev] [PATCH v4 4/8] test/stack: add stack perf test Gage Eads
2019-03-28 18:00 ` Gage Eads
2019-03-28 18:00 ` [dpdk-dev] [PATCH v4 5/8] stack: add lock-free stack implementation Gage Eads
2019-03-28 18:00 ` Gage Eads
2019-03-28 18:00 ` [dpdk-dev] [PATCH v4 6/8] stack: add C11 atomic implementation Gage Eads
2019-03-28 18:00 ` Gage Eads
2019-03-28 18:00 ` [dpdk-dev] [PATCH v4 7/8] test/stack: add lock-free stack tests Gage Eads
2019-03-28 18:00 ` Gage Eads
2019-03-28 18:00 ` [dpdk-dev] [PATCH v4 8/8] mempool/stack: add lock-free stack mempool handler Gage Eads
2019-03-28 18:00 ` Gage Eads
2019-04-01 0:12 ` [dpdk-dev] [PATCH v5 0/8] Add stack library and new " Gage Eads
2019-04-01 0:12 ` Gage Eads
2019-04-01 0:12 ` [dpdk-dev] [PATCH v5 1/8] stack: introduce rte stack library Gage Eads
2019-04-01 0:12 ` Gage Eads
2019-04-01 0:12 ` [dpdk-dev] [PATCH v5 2/8] mempool/stack: convert mempool to use rte stack Gage Eads
2019-04-01 0:12 ` Gage Eads
2019-04-01 0:12 ` [dpdk-dev] [PATCH v5 3/8] test/stack: add stack test Gage Eads
2019-04-01 0:12 ` Gage Eads
2019-04-01 0:12 ` [dpdk-dev] [PATCH v5 4/8] test/stack: add stack perf test Gage Eads
2019-04-01 0:12 ` Gage Eads
2019-04-01 0:12 ` [dpdk-dev] [PATCH v5 5/8] stack: add lock-free stack implementation Gage Eads
2019-04-01 0:12 ` Gage Eads
2019-04-01 18:08 ` Honnappa Nagarahalli
2019-04-01 18:08 ` Honnappa Nagarahalli
2019-04-01 0:12 ` [dpdk-dev] [PATCH v5 6/8] stack: add C11 atomic implementation Gage Eads
2019-04-01 0:12 ` Gage Eads
2019-04-01 0:12 ` [dpdk-dev] [PATCH v5 7/8] test/stack: add lock-free stack tests Gage Eads
2019-04-01 0:12 ` Gage Eads
2019-04-01 0:12 ` [dpdk-dev] [PATCH v5 8/8] mempool/stack: add lock-free stack mempool handler Gage Eads
2019-04-01 0:12 ` Gage Eads
2019-04-01 21:14 ` [dpdk-dev] [PATCH v6 0/8] Add stack library and new " Gage Eads
2019-04-01 21:14 ` Gage Eads
2019-04-01 21:14 ` [dpdk-dev] [PATCH v6 1/8] stack: introduce rte stack library Gage Eads
2019-04-01 21:14 ` Gage Eads
2019-04-02 11:14 ` Honnappa Nagarahalli
2019-04-02 11:14 ` Honnappa Nagarahalli
2019-04-03 17:06 ` Thomas Monjalon
2019-04-03 17:06 ` Thomas Monjalon
2019-04-03 17:13 ` Eads, Gage
2019-04-03 17:13 ` Eads, Gage
2019-04-03 17:23 ` Thomas Monjalon
2019-04-03 17:23 ` Thomas Monjalon
2019-04-01 21:14 ` [dpdk-dev] [PATCH v6 2/8] mempool/stack: convert mempool to use rte stack Gage Eads
2019-04-01 21:14 ` Gage Eads
2019-04-01 21:14 ` [dpdk-dev] [PATCH v6 3/8] test/stack: add stack test Gage Eads
2019-04-01 21:14 ` Gage Eads
2019-04-01 21:14 ` [dpdk-dev] [PATCH v6 4/8] test/stack: add stack perf test Gage Eads
2019-04-01 21:14 ` Gage Eads
2019-04-01 21:14 ` [dpdk-dev] [PATCH v6 5/8] stack: add lock-free stack implementation Gage Eads
2019-04-01 21:14 ` Gage Eads
2019-04-01 21:14 ` [dpdk-dev] [PATCH v6 6/8] stack: add C11 atomic implementation Gage Eads
2019-04-01 21:14 ` Gage Eads
2019-04-02 11:11 ` Honnappa Nagarahalli
2019-04-02 11:11 ` Honnappa Nagarahalli
2019-04-01 21:14 ` [dpdk-dev] [PATCH v6 7/8] test/stack: add lock-free stack tests Gage Eads
2019-04-01 21:14 ` Gage Eads
2019-04-01 21:14 ` [dpdk-dev] [PATCH v6 8/8] mempool/stack: add lock-free stack mempool handler Gage Eads
2019-04-01 21:14 ` Gage Eads
2019-04-03 17:04 ` [dpdk-dev] [PATCH v6 0/8] Add stack library and new " Thomas Monjalon
2019-04-03 17:04 ` Thomas Monjalon
2019-04-03 17:10 ` Eads, Gage
2019-04-03 17:10 ` Eads, Gage
2019-04-03 20:09 ` [dpdk-dev] [PATCH v7 " Gage Eads
2019-04-03 20:09 ` Gage Eads
2019-04-03 20:09 ` [dpdk-dev] [PATCH v7 1/8] stack: introduce rte stack library Gage Eads
2019-04-03 20:09 ` Gage Eads
2019-04-03 20:09 ` [dpdk-dev] [PATCH v7 2/8] mempool/stack: convert mempool to use rte stack Gage Eads
2019-04-03 20:09 ` Gage Eads
2019-04-03 20:09 ` [dpdk-dev] [PATCH v7 3/8] test/stack: add stack test Gage Eads
2019-04-03 20:09 ` Gage Eads
2019-04-03 20:09 ` [dpdk-dev] [PATCH v7 4/8] test/stack: add stack perf test Gage Eads
2019-04-03 20:09 ` Gage Eads
2019-04-03 20:09 ` [dpdk-dev] [PATCH v7 5/8] stack: add lock-free stack implementation Gage Eads
2019-04-03 20:09 ` Gage Eads
2019-04-03 20:09 ` [dpdk-dev] [PATCH v7 6/8] stack: add C11 atomic implementation Gage Eads
2019-04-03 20:09 ` Gage Eads
2019-04-03 20:09 ` [dpdk-dev] [PATCH v7 7/8] test/stack: add lock-free stack tests Gage Eads
2019-04-03 20:09 ` Gage Eads
2019-04-03 20:09 ` [dpdk-dev] [PATCH v7 8/8] mempool/stack: add lock-free stack mempool handler Gage Eads
2019-04-03 20:09 ` Gage Eads
2019-04-03 20:39 ` [dpdk-dev] [PATCH v7 0/8] Add stack library and new " Thomas Monjalon
2019-04-03 20:39 ` Thomas Monjalon
2019-04-03 20:49 ` Eads, Gage
2019-04-03 20:49 ` Eads, Gage
2019-04-03 20:50 ` [dpdk-dev] [PATCH v8 " Gage Eads
2019-04-03 20:50 ` Gage Eads
2019-04-03 20:50 ` [dpdk-dev] [PATCH v8 1/8] stack: introduce rte stack library Gage Eads
2019-04-03 20:50 ` Gage Eads
2019-04-03 20:50 ` [dpdk-dev] [PATCH v8 2/8] mempool/stack: convert mempool to use rte stack Gage Eads
2019-04-03 20:50 ` Gage Eads
2019-04-03 20:50 ` [dpdk-dev] [PATCH v8 3/8] test/stack: add stack test Gage Eads
2019-04-03 20:50 ` Gage Eads
2019-04-03 22:41 ` Thomas Monjalon
2019-04-03 22:41 ` Thomas Monjalon
2019-04-03 23:05 ` Eads, Gage
2019-04-03 23:05 ` Eads, Gage
2019-04-03 20:50 ` [dpdk-dev] [PATCH v8 4/8] test/stack: add stack perf test Gage Eads
2019-04-03 20:50 ` Gage Eads
2019-04-03 20:50 ` [dpdk-dev] [PATCH v8 5/8] stack: add lock-free stack implementation Gage Eads
2019-04-03 20:50 ` Gage Eads
2019-04-03 20:50 ` [dpdk-dev] [PATCH v8 6/8] stack: add C11 atomic implementation Gage Eads
2019-04-03 20:50 ` Gage Eads
2019-04-03 20:50 ` [dpdk-dev] [PATCH v8 7/8] test/stack: add lock-free stack tests Gage Eads
2019-04-03 20:50 ` Gage Eads
2019-04-03 20:50 ` [dpdk-dev] [PATCH v8 8/8] mempool/stack: add lock-free stack mempool handler Gage Eads
2019-04-03 20:50 ` Gage Eads
2019-04-03 23:20 ` [dpdk-dev] [PATCH v9 0/8] Add stack library and new " Gage Eads
2019-04-03 23:20 ` Gage Eads
2019-04-03 23:20 ` [dpdk-dev] [PATCH v9 1/8] stack: introduce rte stack library Gage Eads
2019-04-03 23:20 ` Gage Eads
2019-04-04 13:30 ` Thomas Monjalon
2019-04-04 13:30 ` Thomas Monjalon
2019-04-04 14:14 ` Eads, Gage
2019-04-04 14:14 ` Eads, Gage
2019-04-03 23:20 ` [dpdk-dev] [PATCH v9 2/8] mempool/stack: convert mempool to use rte stack Gage Eads
2019-04-03 23:20 ` Gage Eads
2019-04-03 23:20 ` [dpdk-dev] [PATCH v9 3/8] test/stack: add stack test Gage Eads
2019-04-03 23:20 ` Gage Eads
2019-04-04 7:34 ` Thomas Monjalon
2019-04-04 7:34 ` Thomas Monjalon
2019-04-03 23:20 ` [dpdk-dev] [PATCH v9 4/8] test/stack: add stack perf test Gage Eads
2019-04-03 23:20 ` Gage Eads
2019-04-03 23:20 ` [dpdk-dev] [PATCH v9 5/8] stack: add lock-free stack implementation Gage Eads
2019-04-03 23:20 ` Gage Eads
2019-04-03 23:20 ` [dpdk-dev] [PATCH v9 6/8] stack: add C11 atomic implementation Gage Eads
2019-04-03 23:20 ` Gage Eads
2019-04-03 23:20 ` [dpdk-dev] [PATCH v9 7/8] test/stack: add lock-free stack tests Gage Eads
2019-04-03 23:20 ` Gage Eads
2019-04-03 23:20 ` [dpdk-dev] [PATCH v9 8/8] mempool/stack: add lock-free stack mempool handler Gage Eads
2019-04-03 23:20 ` Gage Eads
2019-04-04 10:01 ` [dpdk-dev] [PATCH v10 0/8] Add stack library and new " Gage Eads
2019-04-04 10:01 ` Gage Eads
2019-04-04 10:01 ` [dpdk-dev] [PATCH v10 1/8] stack: introduce rte stack library Gage Eads
2019-04-04 10:01 ` Gage Eads
2019-04-04 10:01 ` [dpdk-dev] [PATCH v10 2/8] mempool/stack: convert mempool to use rte stack Gage Eads
2019-04-04 10:01 ` Gage Eads
2019-04-04 10:01 ` [dpdk-dev] [PATCH v10 3/8] test/stack: add stack test Gage Eads
2019-04-04 10:01 ` Gage Eads
2019-04-04 10:01 ` [dpdk-dev] [PATCH v10 4/8] test/stack: add stack perf test Gage Eads
2019-04-04 10:01 ` Gage Eads
2019-04-04 10:01 ` [dpdk-dev] [PATCH v10 5/8] stack: add lock-free stack implementation Gage Eads
2019-04-04 10:01 ` Gage Eads
2019-04-04 10:01 ` [dpdk-dev] [PATCH v10 6/8] stack: add C11 atomic implementation Gage Eads
2019-04-04 10:01 ` Gage Eads
2019-04-04 10:01 ` [dpdk-dev] [PATCH v10 7/8] test/stack: add lock-free stack tests Gage Eads
2019-04-04 10:01 ` Gage Eads
2019-04-04 10:01 ` [dpdk-dev] [PATCH v10 8/8] mempool/stack: add lock-free stack mempool handler Gage Eads
2019-04-04 10:01 ` Gage Eads
2019-04-04 15:42 ` [dpdk-dev] [PATCH v10 0/8] Add stack library and new " Thomas Monjalon
2019-04-04 15:42 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9184057F7FC11744A2107296B6B8EB1E5420D923@FMSMSX108.amr.corp.intel.com \
--to=gage.eads@intel.com \
--cc=Gavin.Hu@arm.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=arybchenko@solarflare.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=nd@arm.com \
--cc=olivier.matz@6wind.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).