From: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
"arybchenko@solarflare.com" <arybchenko@solarflare.com>,
"stephen@networkplumber.org" <stephen@networkplumber.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: [dpdk-dev] [PATCH] ethdev: fix DMA zone reserve not honoring size
Date: Sun, 31 Mar 2019 16:25:04 +0000 [thread overview]
Message-ID: <20190331162437.13048-1-pbhagavatula@marvell.com> (raw)
Message-ID: <20190331162504.VtGNF9XNZbnnvtdgsMYqvv6yoV4Pt2lLtFkWvVpQZ2Y@z> (raw)
From: Pavan Nikhilesh <pbhagavatula@marvell.com>
The `rte_eth_dma_zone_reserve()` is generally used to create HW rings.
In some scenarios when a driver needs to reconfigure the ring size
since the named memzone already exists it returns the previous memzone
without checking if a different sized ring is requested.
Introduce a check to see if the ring size requested is different from the
previously created memzone length.
Fixes: 719dbebceb81 ("xen: allow determining DOM0 at runtime")
Cc: stable@dpdk.org
Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
---
lib/librte_ethdev/rte_ethdev.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c
index 12b66b68c..4ae12e43b 100644
--- a/lib/librte_ethdev/rte_ethdev.c
+++ b/lib/librte_ethdev/rte_ethdev.c
@@ -3604,9 +3604,12 @@ rte_eth_dma_zone_reserve(const struct rte_eth_dev *dev, const char *ring_name,
}
mz = rte_memzone_lookup(z_name);
- if (mz)
+ if (mz && (mz->len == size))
return mz;
+ if (mz)
+ rte_memzone_free(mz);
+
return rte_memzone_reserve_aligned(z_name, size, socket_id,
RTE_MEMZONE_IOVA_CONTIG, align);
}
--
2.21.0
next reply other threads:[~2019-03-31 16:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-31 16:25 Pavan Nikhilesh Bhagavatula [this message]
2019-03-31 16:25 ` Pavan Nikhilesh Bhagavatula
2019-04-01 7:30 ` Andrew Rybchenko
2019-04-01 7:30 ` Andrew Rybchenko
2019-04-01 9:28 ` Burakov, Anatoly
2019-04-01 9:28 ` Burakov, Anatoly
2019-04-01 9:40 ` Burakov, Anatoly
2019-04-01 9:40 ` Burakov, Anatoly
2019-04-01 12:12 ` [dpdk-dev] [EXT] " Pavan Nikhilesh Bhagavatula
2019-04-01 12:12 ` Pavan Nikhilesh Bhagavatula
2019-04-02 0:47 ` Jerin Jacob Kollanukkaran
2019-04-02 0:47 ` Jerin Jacob Kollanukkaran
2019-04-02 7:36 ` Andrew Rybchenko
2019-04-02 7:36 ` Andrew Rybchenko
2019-04-02 8:25 ` Jerin Jacob Kollanukkaran
2019-04-02 8:25 ` Jerin Jacob Kollanukkaran
2019-04-02 8:44 ` Andrew Rybchenko
2019-04-02 8:44 ` Andrew Rybchenko
2019-04-04 22:23 ` Thomas Monjalon
2019-04-04 22:23 ` Thomas Monjalon
2019-04-05 8:03 ` Andrew Rybchenko
2019-04-05 8:03 ` Andrew Rybchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190331162437.13048-1-pbhagavatula@marvell.com \
--to=pbhagavatula@marvell.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerinj@marvell.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).