DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>,
	"Yigit, Ferruh" <ferruh.yigit@intel.com>,
	"Zhang, Qi Z" <qi.z.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"O'Hare, Cathal" <cathal.ohare@intel.com>,
	 "Mcnamara, John" <john.mcnamara@intel.com>
Subject: Re: [dpdk-dev] [PATCH v7 0/8] Support vector instructions on ICE
Date: Mon, 1 Apr 2019 05:46:03 +0000	[thread overview]
Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC0909407F8DBB@shsmsx102.ccr.corp.intel.com> (raw)
Message-ID: <20190401054603.LzTZ-vTzQdp_v_dEvhUHgzSj4knTyO-CdUWbDj45I7s@z> (raw)
In-Reply-To: <2061322.Qldrv329ue@xps>

Hi Thomas,


> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Sunday, March 31, 2019 11:52 PM
> To: Yigit, Ferruh <ferruh.yigit@intel.com>; Lu, Wenzhuo
> <wenzhuo.lu@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org; O'Hare, Cathal <cathal.ohare@intel.com>; Mcnamara,
> John <john.mcnamara@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v7 0/8] Support vector instructions on ICE
> 
> 26/03/2019 10:50, Ferruh Yigit:
> > > Wenzhuo Lu (8):
> > >   net/ice: fix Tx function setting
> > >   net/ice: add pointer for queue buffer release
> > >   net/ice: support vector SSE in RX
> > >   net/ice: support Rx scatter SSE vector
> > >   net/ice: support Tx SSE vector
> > >   net/ice: support Rx AVX2 vector
> > >   net/ice: support Rx scatter AVX2 vector
> > >   net/ice: support vector AVX2 in TX
> >
> > This version (v7) pulled from next-net-intel to next-net.
> 
> I assume these patches have been tested, or at least compiled.
> However, when running devtools/test-meson-builds.sh, there is a
> compilation error for build-x86-default:
> 
> In file included from ../drivers/net/ice/ice_ethdev.h:10:
> rte_ethdev_pci.h:38:10: fatal error: 'rte_pci.h' file not found
> 
> It can be fixed in
> 	net/ice: support Rx AVX2 vector
> by adding static_rte_pci and static_rte_bus_pci to the dependencies.
> I fixed it even better in
> 	net/ice: support vector SSE in Rx
> by replacing the useless include of rte_ethdev_pci.h in ice_ethdev.h with
> rte_ethdev_driver.h.
Really sorry for this. Although I don't understand the issue. I do use meson build and it works.
In my server,  no matter using " rte_ethdev_pci.h " or " rte_ethdev_driver.h ", it works fine.
To be honest, the compile error looks weird to me. Looks like any file which includes " rte_ethdev_pci.h " can hit the same problem. But I cannot tell anything, as I cannot reproduce the error.
Again, really appreciate for root causing and fixing the error but not rejecting the patches.

> 
> I could just reject the next-net tree, but I don't really have such option if we
> want to close 19.05-rc1 quickly.
> 
> In summary, I am spending my Sunday hours to fix the mess in your driver
> which was supposed to be tested before submitting, plus before merge in
> next-net-intel, plus compilation-tested before pull in next-net.
> I don't know what failed in the process, but I really don't like it.
> I don't want to see any new patch for ice PMD in 19.05 cycle.
> If you really need some fixes in 19.05 (very likely given the mass code drop
> you are doing few days before the -rc1 deadline), then I advise you to
> double check everything and make commits fully justified and explained.
> 
> Sorry for the bad mood, and I hope it won't happen again soon.
> 


  parent reply	other threads:[~2019-04-01  5:46 UTC|newest]

Thread overview: 219+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-28  7:48 [dpdk-dev] [PATCH " Wenzhuo Lu
2019-02-28  7:48 ` [dpdk-dev] [PATCH 1/8] net/ice: fix TX function setting Wenzhuo Lu
2019-02-28  7:48 ` [dpdk-dev] [PATCH 2/8] net/ice: add pointer for queue buffer release Wenzhuo Lu
2019-02-28  7:48 ` [dpdk-dev] [PATCH 3/8] net/ice: support RX SSE vector Wenzhuo Lu
2019-03-01  3:44   ` Zhang, Qi Z
2019-03-04  1:27     ` Lu, Wenzhuo
2019-02-28  7:48 ` [dpdk-dev] [PATCH 4/8] net/ice: support RX scatter " Wenzhuo Lu
2019-02-28  7:48 ` [dpdk-dev] [PATCH 5/8] net/ice: support TX " Wenzhuo Lu
2019-02-28  7:48 ` [dpdk-dev] [PATCH 6/8] net/ice: support RX AVX2 vector Wenzhuo Lu
2019-02-28  7:48 ` [dpdk-dev] [PATCH 7/8] net/ice: support RX scatter " Wenzhuo Lu
2019-02-28  7:48 ` [dpdk-dev] [PATCH 8/8] net/ice: support TX " Wenzhuo Lu
2019-03-01  3:41 ` [dpdk-dev] [PATCH 0/8] Support vector instructions on ICE Zhang, Qi Z
2019-03-04  1:24   ` Lu, Wenzhuo
2019-03-04  6:53 ` [dpdk-dev] [PATCH v2 " Wenzhuo Lu
2019-03-04  6:53   ` [dpdk-dev] [PATCH v2 1/8] net/ice: fix Tx function setting Wenzhuo Lu
2019-03-04  6:53   ` [dpdk-dev] [PATCH v2 2/8] net/ice: add pointer for queue buffer release Wenzhuo Lu
2019-03-04  6:53   ` [dpdk-dev] [PATCH v2 3/8] net/ice: support vector SSE in RX Wenzhuo Lu
2019-03-11  3:26     ` Zhang, Qi Z
2019-03-15  1:50       ` Lu, Wenzhuo
2019-03-15  1:50         ` Lu, Wenzhuo
2019-03-04  6:53   ` [dpdk-dev] [PATCH v2 4/8] net/ice: support Rx scatter SSE vector Wenzhuo Lu
2019-03-04  6:53   ` [dpdk-dev] [PATCH v2 5/8] net/ice: support Tx " Wenzhuo Lu
2019-03-04  6:53   ` [dpdk-dev] [PATCH v2 6/8] net/ice: support Rx AVX2 vector Wenzhuo Lu
2019-03-04  6:53   ` [dpdk-dev] [PATCH v2 7/8] net/ice: support Rx scatter " Wenzhuo Lu
2019-03-04  6:53   ` [dpdk-dev] [PATCH v2 8/8] net/ice: support vector AVX2 in TX Wenzhuo Lu
2019-03-15  6:22 ` [dpdk-dev] [PATCH v3 0/8] Support vector instructions on ICE Wenzhuo Lu
2019-03-15  6:22   ` Wenzhuo Lu
2019-03-15  6:22   ` [dpdk-dev] [PATCH v3 1/8] net/ice: fix Tx function setting Wenzhuo Lu
2019-03-15  6:22     ` Wenzhuo Lu
2019-03-15 17:52     ` Ferruh Yigit
2019-03-15 17:52       ` Ferruh Yigit
2019-03-18  1:08       ` Lu, Wenzhuo
2019-03-18  1:08         ` Lu, Wenzhuo
2019-03-20 17:22         ` Ferruh Yigit
2019-03-20 17:22           ` Ferruh Yigit
2019-03-21  2:29           ` Lu, Wenzhuo
2019-03-21  2:29             ` Lu, Wenzhuo
2019-03-15  6:22   ` [dpdk-dev] [PATCH v3 2/8] net/ice: add pointer for queue buffer release Wenzhuo Lu
2019-03-15  6:22     ` Wenzhuo Lu
2019-03-15 17:52     ` Ferruh Yigit
2019-03-15 17:52       ` Ferruh Yigit
2019-03-18  1:15       ` Lu, Wenzhuo
2019-03-18  1:15         ` Lu, Wenzhuo
2019-03-15  6:22   ` [dpdk-dev] [PATCH v3 3/8] net/ice: support vector SSE in RX Wenzhuo Lu
2019-03-15  6:22     ` Wenzhuo Lu
2019-03-15 17:53     ` Ferruh Yigit
2019-03-15 17:53       ` Ferruh Yigit
2019-03-18  1:22       ` Lu, Wenzhuo
2019-03-18  1:22         ` Lu, Wenzhuo
2019-03-20 17:35         ` Ferruh Yigit
2019-03-20 17:35           ` Ferruh Yigit
2019-03-21  2:48           ` Lu, Wenzhuo
2019-03-21  2:48             ` Lu, Wenzhuo
2019-03-15  6:22   ` [dpdk-dev] [PATCH v3 4/8] net/ice: support Rx scatter SSE vector Wenzhuo Lu
2019-03-15  6:22     ` Wenzhuo Lu
2019-03-15  6:22   ` [dpdk-dev] [PATCH v3 5/8] net/ice: support Tx " Wenzhuo Lu
2019-03-15  6:22     ` Wenzhuo Lu
2019-03-15  6:22   ` [dpdk-dev] [PATCH v3 6/8] net/ice: support Rx AVX2 vector Wenzhuo Lu
2019-03-15  6:22     ` Wenzhuo Lu
2019-03-15 17:54     ` Ferruh Yigit
2019-03-15 17:54       ` Ferruh Yigit
2019-03-18  1:37       ` Lu, Wenzhuo
2019-03-18  1:37         ` Lu, Wenzhuo
2019-03-20 17:37         ` Ferruh Yigit
2019-03-20 17:37           ` Ferruh Yigit
2019-03-21  2:31           ` Lu, Wenzhuo
2019-03-21  2:31             ` Lu, Wenzhuo
2019-03-15  6:22   ` [dpdk-dev] [PATCH v3 7/8] net/ice: support Rx scatter " Wenzhuo Lu
2019-03-15  6:22     ` Wenzhuo Lu
2019-03-15  6:22   ` [dpdk-dev] [PATCH v3 8/8] net/ice: support vector AVX2 in TX Wenzhuo Lu
2019-03-15  6:22     ` Wenzhuo Lu
2019-03-15 17:54     ` Ferruh Yigit
2019-03-15 17:54       ` Ferruh Yigit
2019-03-18  1:38       ` Lu, Wenzhuo
2019-03-18  1:38         ` Lu, Wenzhuo
2019-03-15  8:08   ` [dpdk-dev] [PATCH v3 0/8] Support vector instructions on ICE Zhang, Qi Z
2019-03-15  8:08     ` Zhang, Qi Z
2019-03-21  6:26 ` [dpdk-dev] [PATCH v4 " Wenzhuo Lu
2019-03-21  6:26   ` Wenzhuo Lu
2019-03-21  6:26   ` [dpdk-dev] [PATCH v4 1/8] net/ice: fix Tx function setting Wenzhuo Lu
2019-03-21  6:26     ` Wenzhuo Lu
2019-03-22  8:46     ` Maxime Coquelin
2019-03-22  8:46       ` Maxime Coquelin
2019-03-22  9:01       ` Maxime Coquelin
2019-03-22  9:01         ` Maxime Coquelin
2019-03-21  6:26   ` [dpdk-dev] [PATCH v4 2/8] net/ice: add pointer for queue buffer release Wenzhuo Lu
2019-03-21  6:26     ` Wenzhuo Lu
2019-03-22  8:59     ` Maxime Coquelin
2019-03-22  8:59       ` Maxime Coquelin
2019-03-21  6:26   ` [dpdk-dev] [PATCH v4 3/8] net/ice: support vector SSE in RX Wenzhuo Lu
2019-03-21  6:26     ` Wenzhuo Lu
2019-03-21 19:02     ` Ferruh Yigit
2019-03-21 19:02       ` Ferruh Yigit
2019-03-22  1:46       ` Lu, Wenzhuo
2019-03-22  1:46         ` Lu, Wenzhuo
2019-03-21  6:26   ` [dpdk-dev] [PATCH v4 4/8] net/ice: support Rx scatter SSE vector Wenzhuo Lu
2019-03-21  6:26     ` Wenzhuo Lu
2019-03-21  6:26   ` [dpdk-dev] [PATCH v4 5/8] net/ice: support Tx " Wenzhuo Lu
2019-03-21  6:26     ` Wenzhuo Lu
2019-03-21  6:26   ` [dpdk-dev] [PATCH v4 6/8] net/ice: support Rx AVX2 vector Wenzhuo Lu
2019-03-21  6:26     ` Wenzhuo Lu
2019-03-21  6:26   ` [dpdk-dev] [PATCH v4 7/8] net/ice: support Rx scatter " Wenzhuo Lu
2019-03-21  6:26     ` Wenzhuo Lu
2019-03-21  6:26   ` [dpdk-dev] [PATCH v4 8/8] net/ice: support vector AVX2 in TX Wenzhuo Lu
2019-03-21  6:26     ` Wenzhuo Lu
2019-03-21 19:20     ` Ferruh Yigit
2019-03-21 19:20       ` Ferruh Yigit
2019-03-22  1:45       ` Lu, Wenzhuo
2019-03-22  1:45         ` Lu, Wenzhuo
2019-03-22  2:58 ` [dpdk-dev] [PATCH v5 0/8] Support vector instructions on ICE Wenzhuo Lu
2019-03-22  2:58   ` Wenzhuo Lu
2019-03-22  2:58   ` [dpdk-dev] [PATCH v5 1/8] net/ice: fix Tx function setting Wenzhuo Lu
2019-03-22  2:58     ` Wenzhuo Lu
2019-03-22  2:58   ` [dpdk-dev] [PATCH v5 2/8] net/ice: add pointer for queue buffer release Wenzhuo Lu
2019-03-22  2:58     ` Wenzhuo Lu
2019-03-22  2:58   ` [dpdk-dev] [PATCH v5 3/8] net/ice: support vector SSE in RX Wenzhuo Lu
2019-03-22  2:58     ` Wenzhuo Lu
2019-03-22  9:42     ` Maxime Coquelin
2019-03-22  9:42       ` Maxime Coquelin
2019-03-25  1:56       ` Lu, Wenzhuo
2019-03-25  1:56         ` Lu, Wenzhuo
2019-03-22  2:58   ` [dpdk-dev] [PATCH v5 4/8] net/ice: support Rx scatter SSE vector Wenzhuo Lu
2019-03-22  2:58     ` Wenzhuo Lu
2019-03-22  2:58   ` [dpdk-dev] [PATCH v5 5/8] net/ice: support Tx " Wenzhuo Lu
2019-03-22  2:58     ` Wenzhuo Lu
2019-03-22  9:58     ` Maxime Coquelin
2019-03-22  9:58       ` Maxime Coquelin
2019-03-25  2:02       ` Lu, Wenzhuo
2019-03-25  2:02         ` Lu, Wenzhuo
2019-03-22  2:58   ` [dpdk-dev] [PATCH v5 6/8] net/ice: support Rx AVX2 vector Wenzhuo Lu
2019-03-22  2:58     ` Wenzhuo Lu
2019-03-22 10:12     ` Maxime Coquelin
2019-03-22 10:12       ` Maxime Coquelin
2019-03-25  2:22       ` Lu, Wenzhuo
2019-03-25  2:22         ` Lu, Wenzhuo
2019-03-25  8:26         ` Maxime Coquelin
2019-03-25  8:26           ` Maxime Coquelin
2019-03-26  1:00           ` Lu, Wenzhuo
2019-03-26  1:00             ` Lu, Wenzhuo
2019-03-26  9:28             ` Maxime Coquelin
2019-03-26  9:28               ` Maxime Coquelin
2019-03-27  0:56               ` Lu, Wenzhuo
2019-03-27  0:56                 ` Lu, Wenzhuo
2019-03-27  7:50                 ` Maxime Coquelin
2019-03-27  7:50                   ` Maxime Coquelin
2019-03-28  1:56                   ` Lu, Wenzhuo
2019-03-28  1:56                     ` Lu, Wenzhuo
2019-03-22  2:58   ` [dpdk-dev] [PATCH v5 7/8] net/ice: support Rx scatter " Wenzhuo Lu
2019-03-22  2:58     ` Wenzhuo Lu
2019-03-22  2:58   ` [dpdk-dev] [PATCH v5 8/8] net/ice: support vector AVX2 in TX Wenzhuo Lu
2019-03-22  2:58     ` Wenzhuo Lu
2019-03-25  6:06 ` [dpdk-dev] [PATCH v6 0/8] Support vector instructions on ICE Wenzhuo Lu
2019-03-25  6:06   ` Wenzhuo Lu
2019-03-25  6:06   ` [dpdk-dev] [PATCH v6 1/8] net/ice: fix Tx function setting Wenzhuo Lu
2019-03-25  6:06     ` Wenzhuo Lu
2019-03-25  6:06   ` [dpdk-dev] [PATCH v6 2/8] net/ice: add pointer for queue buffer release Wenzhuo Lu
2019-03-25  6:06     ` Wenzhuo Lu
2019-03-25 13:23     ` Maxime Coquelin
2019-03-25 13:23       ` Maxime Coquelin
2019-03-26  1:15       ` Lu, Wenzhuo
2019-03-26  1:15         ` Lu, Wenzhuo
2019-03-25  6:06   ` [dpdk-dev] [PATCH v6 3/8] net/ice: support vector SSE in RX Wenzhuo Lu
2019-03-25  6:06     ` Wenzhuo Lu
2019-03-25  6:06   ` [dpdk-dev] [PATCH v6 4/8] net/ice: support Rx scatter SSE vector Wenzhuo Lu
2019-03-25  6:06     ` Wenzhuo Lu
2019-03-25  6:06   ` [dpdk-dev] [PATCH v6 5/8] net/ice: support Tx " Wenzhuo Lu
2019-03-25  6:06     ` Wenzhuo Lu
2019-03-25  6:06   ` [dpdk-dev] [PATCH v6 6/8] net/ice: support Rx AVX2 vector Wenzhuo Lu
2019-03-25  6:06     ` Wenzhuo Lu
2019-03-25  6:06   ` [dpdk-dev] [PATCH v6 7/8] net/ice: support Rx scatter " Wenzhuo Lu
2019-03-25  6:06     ` Wenzhuo Lu
2019-03-25  6:06   ` [dpdk-dev] [PATCH v6 8/8] net/ice: support vector AVX2 in TX Wenzhuo Lu
2019-03-25  6:06     ` Wenzhuo Lu
2019-03-25  7:56   ` [dpdk-dev] [PATCH v6 0/8] Support vector instructions on ICE Zhang, Qi Z
2019-03-25  7:56     ` Zhang, Qi Z
2019-03-26  6:16 ` [dpdk-dev] [PATCH v7 " Wenzhuo Lu
2019-03-26  6:16   ` Wenzhuo Lu
2019-03-26  6:16   ` [dpdk-dev] [PATCH v7 1/8] net/ice: fix Tx function setting Wenzhuo Lu
2019-03-26  6:16     ` Wenzhuo Lu
2019-03-26  6:16   ` [dpdk-dev] [PATCH v7 2/8] net/ice: add pointer for queue buffer release Wenzhuo Lu
2019-03-26  6:16     ` Wenzhuo Lu
2019-03-26  6:16   ` [dpdk-dev] [PATCH v7 3/8] net/ice: support vector SSE in RX Wenzhuo Lu
2019-03-26  6:16     ` Wenzhuo Lu
2019-03-26  6:16   ` [dpdk-dev] [PATCH v7 4/8] net/ice: support Rx scatter SSE vector Wenzhuo Lu
2019-03-26  6:16     ` Wenzhuo Lu
2019-03-26  6:16   ` [dpdk-dev] [PATCH v7 5/8] net/ice: support Tx " Wenzhuo Lu
2019-03-26  6:16     ` Wenzhuo Lu
2019-03-26  6:16   ` [dpdk-dev] [PATCH v7 6/8] net/ice: support Rx AVX2 vector Wenzhuo Lu
2019-03-26  6:16     ` Wenzhuo Lu
2019-03-26  6:16   ` [dpdk-dev] [PATCH v7 7/8] net/ice: support Rx scatter " Wenzhuo Lu
2019-03-26  6:16     ` Wenzhuo Lu
2019-03-26  6:16   ` [dpdk-dev] [PATCH v7 8/8] net/ice: support vector AVX2 in TX Wenzhuo Lu
2019-03-26  6:16     ` Wenzhuo Lu
2019-03-26  9:50   ` [dpdk-dev] [PATCH v7 0/8] Support vector instructions on ICE Ferruh Yigit
2019-03-26  9:50     ` Ferruh Yigit
2019-03-31 15:52     ` Thomas Monjalon
2019-03-31 15:52       ` Thomas Monjalon
2019-04-01  5:46       ` Lu, Wenzhuo [this message]
2019-04-01  5:46         ` Lu, Wenzhuo
2019-04-01 12:51       ` Ferruh Yigit
2019-04-01 12:51         ` Ferruh Yigit
2019-04-01 13:27         ` Thomas Monjalon
2019-04-01 13:27           ` Thomas Monjalon
2019-04-01 15:12           ` Ferruh Yigit
2019-04-01 15:12             ` Ferruh Yigit
2019-04-01 15:14             ` Thomas Monjalon
2019-04-01 15:14               ` Thomas Monjalon
2019-04-02  1:01               ` Lu, Wenzhuo
2019-04-02  1:01                 ` Lu, Wenzhuo
2019-04-02  7:12                 ` Thomas Monjalon
2019-04-02  7:12                   ` Thomas Monjalon
2019-04-01 14:39         ` Bruce Richardson
2019-04-01 14:39           ` Bruce Richardson
2019-04-01 14:56           ` Ferruh Yigit
2019-04-01 14:56             ` Ferruh Yigit
2019-04-01 15:09             ` Ferruh Yigit
2019-04-01 15:09               ` Ferruh Yigit
2019-04-01 15:13             ` Thomas Monjalon
2019-04-01 15:13               ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6A0DE07E22DDAD4C9103DF62FEBC0909407F8DBB@shsmsx102.ccr.corp.intel.com \
    --to=wenzhuo.lu@intel.com \
    --cc=cathal.ohare@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=john.mcnamara@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).