DPDK patches and discussions
 help / color / mirror / Atom feed
From: Aaron Conole <aconole@redhat.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [RFC 1/3] test/meson: auto detect number of cores
Date: Mon, 01 Apr 2019 10:07:14 -0400	[thread overview]
Message-ID: <f7t1s2l7ral.fsf@dhcp-25.97.bos.redhat.com> (raw)
Message-ID: <20190401140714.CFL8-kY4z5--IhFDNOeMDP3vQ0Jt8a0SzCpAImr_EKc@z> (raw)
In-Reply-To: <CAJFAV8x6K1y9T63p1OkkpaHoY8kv8S4rAZCkjzpvOAbyGBXLrg@mail.gmail.com> (David Marchand's message of "Mon, 1 Apr 2019 15:48:25 +0200")

David Marchand <david.marchand@redhat.com> writes:

Thanks for the review, David!

> On Fri, Mar 29, 2019 at 6:23 PM Aaron Conole <aconole@redhat.com> wrote:
>
>  Some environments do not provide a minimum 4 cores for running tests.  This
>  allows those environments to still execute 'ninja test' without causing
>  multiple failures.
>
>  Signed-off-by: Aaron Conole <aconole@redhat.com>
>  ---
>   app/test/meson.build | 11 ++++++++++-
>   1 file changed, 10 insertions(+), 1 deletion(-)
>
>  diff --git a/app/test/meson.build b/app/test/meson.build
>  index ddb4d09ae..975b38daa 100644
>  --- a/app/test/meson.build
>  +++ b/app/test/meson.build
>  @@ -337,10 +337,15 @@ if get_option('tests')
>          timeout_seconds = 600
>          timeout_seconds_fast = 10
>
>  +       # Retreive the number of CPU cores
>  +       num_cores = run_command('lscpu', '-p=cpu').stdout().strip().split('\n')[-1]
>  +       num_cores_arg = '-l 0-' + num_cores
>
> Seeing how we can reduce the core number, we can at least cap it to 4 and not use all the cores on bigger
> systems.
> But, thinking again, do you know if there is a need for more than 2 cores in the existing tests ?

Probably not.  At least, the systems in the travis environment only
provide 2 cores and most of the tests pass.  OTOH, some still fail and I
need to investigate them a bit more.  Some of the test case failures are
ex. eal flags failures and maybe they do pass some '-c f' as part of
the test case, which would fail on systems without 4 cores.

>  +
>  +       test_args = [num_cores_arg, '-n 4']

Whoops!  I think, this '-n 4' option can probably be removed as well.  I
think the memory channel config is optional, and I believe there's no
need to try and tune it.

>          foreach arg : fast_parallel_test_names
>                  test(arg, dpdk_test,
>                          env : ['DPDK_TEST=' + arg],
>  -                       args : ['-c f','-n 4', '--file-prefix=@0@'.format(arg)],
>  +                       args : test_args + ['--file-prefix=@0@'.format(arg)],
>                          timeout : timeout_seconds_fast,
>                          suite : 'fast-tests')
>          endforeach
>  @@ -348,6 +353,7 @@ if get_option('tests')
>          foreach arg : fast_non_parallel_test_names
>                  test(arg, dpdk_test,
>                          env : ['DPDK_TEST=' + arg],
>  +                       args : test_args + ['--file-prefix=@0@'.format(arg)],
>
> I don't understand this part.
>
> (How|) was it working before ?

It did work before.

> Is there some default args ? I could not find it.

I think it does try to do some auto-detection.  I did extend this
because it seemed to make sense, and I have some future work to allow
passing '--no-huge' (in case we have a CI system that doesn't allow
allocating hugepages).  Maybe it doesn't make sense to add that right
now, though.  I'll try without it.

>                          timeout : timeout_seconds_fast,
>                          is_parallel : false,
>                          suite : 'fast-tests')

  parent reply	other threads:[~2019-04-01 14:07 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-29 17:22 [dpdk-dev] [RFC 0/3] ci: enable unit tests for non-aarch64 platforms Aaron Conole
2019-03-29 17:22 ` Aaron Conole
2019-03-29 17:22 ` [dpdk-dev] [RFC 1/3] test/meson: auto detect number of cores Aaron Conole
2019-03-29 17:22   ` Aaron Conole
2019-04-01 13:48   ` David Marchand
2019-04-01 13:48     ` David Marchand
2019-04-01 14:07     ` Aaron Conole [this message]
2019-04-01 14:07       ` Aaron Conole
2019-04-01 16:23   ` Pattan, Reshma
2019-04-01 16:23     ` Pattan, Reshma
2019-04-01 17:48     ` Aaron Conole
2019-04-01 17:48       ` Aaron Conole
2019-04-01 19:39       ` Thomas Monjalon
2019-04-01 19:39         ` Thomas Monjalon
2019-04-01 19:58         ` Aaron Conole
2019-04-01 19:58           ` Aaron Conole
2019-03-29 17:22 ` [dpdk-dev] [RFC 2/3] meson-tests: separate slower tests Aaron Conole
2019-03-29 17:22   ` Aaron Conole
2019-03-29 17:22 ` [dpdk-dev] [RFC 3/3] ci: enable tests on non-arm platforms Aaron Conole
2019-03-29 17:22   ` Aaron Conole
2019-04-17  8:32   ` Jerin Jacob Kollanukkaran
2019-04-17  8:32     ` Jerin Jacob Kollanukkaran
2019-04-17 12:39     ` Aaron Conole
2019-04-17 12:39       ` Aaron Conole
2019-04-17 15:32       ` [dpdk-dev] [EXT] " Jerin Jacob Kollanukkaran
2019-04-17 15:32         ` Jerin Jacob Kollanukkaran
2019-04-01 19:15 ` [dpdk-dev] [RFC 0/3] ci: enable unit tests for non-aarch64 platforms David Marchand
2019-04-01 19:15   ` David Marchand
2019-04-01 19:28   ` Aaron Conole
2019-04-01 19:28     ` Aaron Conole
2019-04-01 19:29     ` David Marchand
2019-04-01 19:29       ` David Marchand
2019-04-02  9:37       ` Bruce Richardson
2019-04-02  9:37         ` Bruce Richardson
2019-04-02 10:09         ` David Marchand
2019-04-02 10:09           ` David Marchand
2019-04-02 12:49           ` Aaron Conole
2019-04-02 12:49             ` Aaron Conole

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f7t1s2l7ral.fsf@dhcp-25.97.bos.redhat.com \
    --to=aconole@redhat.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).