From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Ali Alnubani <alialnu@mellanox.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
harini.ramakrishnan@microsoft.com, ranjit.menon@intel.com
Subject: Re: [dpdk-dev] [PATCH] build: use cat instead of more
Date: Mon, 1 Apr 2019 15:47:50 +0100 [thread overview]
Message-ID: <20190401144750.GB1441@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <3743424.Qud79MjzIA@xps>
On Mon, Apr 01, 2019 at 01:24:20PM +0200, Thomas Monjalon wrote:
> 01/04/2019 12:36, Ali Alnubani:
> > This is to fix a build error with meson that is caused
> > by using the 'more' command to read the VERSION file. The error:
> >
> > config/meson.build:10:10: ERROR: String
> > '::::::::::::::\n<RTE_SDK_PATH>VERSION\n::::::::::::::\n19' cannot be
> > converted to int
> >
> > The command 'more' prints the file name before the actual
> > contents of the file when it's being run without a controlling terminal.
> > This could happen in CI environments.
> >
> > Please refer to:
> > https://git.kernel.org/pub/scm/utils/util-linux/util-linux.git/tree/text-utils/more.c
> >
> > The cat command can still be found on Windows if the ports of GNU
> > utilities are installed.
> >
> > Fixes: c04172b5f031 ("build: add single source of DPDK version number")
> > Fixes: d320fe56bd51 ("build: use version number from config file")
> >
> > Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
>
> Acked-by: Thomas Monjalon <thomas@monjalon.net>
>
> It is fixing a regression on Linux.
> I think we should take this fix urgently
> and think about Windows in a next step.
>
> "more" is an interactive command, we should not use it.
> As suggested by Ali, we may require an extra dependency on Windows
> to get some GNU utilities. Or if no other tools are required,
> may we have a meson builtin to read a file?
>
Should not need to do so. May I suggest using "find_program" function
instead of hard-coding the command. That allows a list of programs to be
specified and the first one found is used. Unfortunately, on windows the
direct equivalent of "cat" is "type" which is a built-in rather than
command as far as I can see, so find_program doesn't work for it. However,
the following should do:
version: run_command(find_program('cat', 'more'), files('VERSION')).stdout().strip()
next prev parent reply other threads:[~2019-04-01 14:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-01 10:36 Ali Alnubani
2019-04-01 10:36 ` Ali Alnubani
2019-04-01 11:24 ` Thomas Monjalon
2019-04-01 11:24 ` Thomas Monjalon
2019-04-01 14:47 ` Bruce Richardson [this message]
2019-04-01 14:47 ` Bruce Richardson
2019-04-01 15:38 ` [dpdk-dev] [PATCH v2] build: use cat if found Ali Alnubani
2019-04-01 15:38 ` Ali Alnubani
2019-04-01 15:48 ` Bruce Richardson
2019-04-01 15:48 ` Bruce Richardson
2019-04-01 16:59 ` Thomas Monjalon
2019-04-01 16:59 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190401144750.GB1441@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=alialnu@mellanox.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=harini.ramakrishnan@microsoft.com \
--cc=ranjit.menon@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).