DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Eads, Gage" <gage.eads@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"olivier.matz@6wind.com" <olivier.matz@6wind.com>,
	"arybchenko@solarflare.com" <arybchenko@solarflare.com>,
	"Richardson, Bruce" <bruce.richardson@intel.com>,
	"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
	"gavin.hu@arm.com" <gavin.hu@arm.com>,
	"Honnappa.Nagarahalli@arm.com" <Honnappa.Nagarahalli@arm.com>,
	"nd@arm.com" <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH v9 1/8] stack: introduce rte stack library
Date: Thu, 4 Apr 2019 14:14:18 +0000	[thread overview]
Message-ID: <9184057F7FC11744A2107296B6B8EB1E54210E03@FMSMSX108.amr.corp.intel.com> (raw)
Message-ID: <20190404141418.emJ892oq7Td36i1yk8iJgX04aD-Bchb0g4homCy_5RI@z> (raw)
In-Reply-To: <1742818.CN8ABES3X5@xps>



> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Thursday, April 4, 2019 8:30 AM
> To: Eads, Gage <gage.eads@intel.com>
> Cc: dev@dpdk.org; olivier.matz@6wind.com; arybchenko@solarflare.com;
> Richardson, Bruce <bruce.richardson@intel.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>; gavin.hu@arm.com;
> Honnappa.Nagarahalli@arm.com; nd@arm.com
> Subject: Re: [dpdk-dev] [PATCH v9 1/8] stack: introduce rte stack library
> 
> 04/04/2019 01:20, Gage Eads:
> > --- a/mk/rte.app.mk
> > +++ b/mk/rte.app.mk
> > @@ -87,6 +87,7 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_SECURITY)       += -
> lrte_security
> >  _LDLIBS-$(CONFIG_RTE_LIBRTE_COMPRESSDEV)    += -lrte_compressdev
> >  _LDLIBS-$(CONFIG_RTE_LIBRTE_EVENTDEV)       += -lrte_eventdev
> >  _LDLIBS-$(CONFIG_RTE_LIBRTE_RAWDEV)         += -lrte_rawdev
> > +_LDLIBS-$(CONFIG_RTE_LIBRTE_STACK)          += -lrte_stack
> >  _LDLIBS-$(CONFIG_RTE_LIBRTE_TIMER)          += -lrte_timer
> >  _LDLIBS-$(CONFIG_RTE_LIBRTE_MEMPOOL)        += -lrte_mempool
> >  _LDLIBS-$(CONFIG_RTE_DRIVER_MEMPOOL_RING)   += -
> lrte_mempool_ring
> 
> Stack library is used by mempool, so it should appear after mempool in the
> library list.
> It is the same as ring lib being after mempool_ring.
> 
> If you agree, please just tell me without sending a new version, because I'm
> doing other minor changes (sorting stack near ring in many files).
> 

Agreed. I suspect we haven't seen any linker problems because it's in a --whole-archive section (line 72), but better to put these in the correct dependency order.

  parent reply	other threads:[~2019-04-04 14:14 UTC|newest]

Thread overview: 228+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-22 16:06 [dpdk-dev] [PATCH 0/7] Subject: [PATCH ...] Add stack library and new mempool handler Gage Eads
2019-02-22 16:06 ` [dpdk-dev] [PATCH 1/7] stack: introduce rte stack library Gage Eads
2019-02-25 10:43   ` Olivier Matz
2019-02-28  5:10     ` Eads, Gage
2019-02-22 16:06 ` [dpdk-dev] [PATCH 2/7] mempool/stack: convert mempool to use rte stack Gage Eads
2019-02-25 10:46   ` Olivier Matz
2019-02-22 16:06 ` [dpdk-dev] [PATCH 3/7] test/stack: add stack test Gage Eads
2019-02-25 10:59   ` Olivier Matz
2019-02-28  5:11     ` Eads, Gage
2019-02-22 16:06 ` [dpdk-dev] [PATCH 4/7] test/stack: add stack perf test Gage Eads
2019-02-25 11:04   ` Olivier Matz
2019-02-22 16:06 ` [dpdk-dev] [PATCH 5/7] stack: add non-blocking stack implementation Gage Eads
2019-02-25 11:28   ` Olivier Matz
     [not found]     ` <2EC44CCD3517A842B44C82651A5557A14AF13386@fmsmsx118.amr.corp.intel.com>
2019-03-01 20:53       ` [dpdk-dev] FW: " Eads, Gage
2019-03-01 21:12         ` Thomas Monjalon
2019-03-01 21:29           ` Eads, Gage
2019-02-22 16:06 ` [dpdk-dev] [PATCH 6/7] test/stack: add non-blocking stack tests Gage Eads
2019-02-25 11:28   ` Olivier Matz
2019-02-22 16:06 ` [dpdk-dev] [PATCH 7/7] mempool/stack: add non-blocking stack mempool handler Gage Eads
2019-02-25 11:29   ` Olivier Matz
2019-03-05 16:42 ` [dpdk-dev] [PATCH v2 0/8] Add stack library and new " Gage Eads
2019-03-05 16:42   ` [dpdk-dev] [PATCH v2 1/8] stack: introduce rte stack library Gage Eads
2019-03-05 16:42   ` [dpdk-dev] [PATCH v2 2/8] mempool/stack: convert mempool to use rte stack Gage Eads
2019-03-05 16:42   ` [dpdk-dev] [PATCH v2 3/8] test/stack: add stack test Gage Eads
2019-03-05 16:42   ` [dpdk-dev] [PATCH v2 4/8] test/stack: add stack perf test Gage Eads
2019-03-05 16:42   ` [dpdk-dev] [PATCH v2 5/8] stack: add lock-free stack implementation Gage Eads
2019-03-05 16:42   ` [dpdk-dev] [PATCH v2 6/8] stack: add C11 atomic implementation Gage Eads
2019-03-05 16:42   ` [dpdk-dev] [PATCH v2 7/8] test/stack: add lock-free stack tests Gage Eads
2019-03-05 16:42   ` [dpdk-dev] [PATCH v2 8/8] mempool/stack: add lock-free stack mempool handler Gage Eads
2019-03-06 14:45   ` [dpdk-dev] [PATCH v3 0/8] Add stack library and new " Gage Eads
2019-03-06 14:45     ` [dpdk-dev] [PATCH v3 1/8] stack: introduce rte stack library Gage Eads
2019-03-14  8:00       ` Olivier Matz
2019-03-14  8:00         ` Olivier Matz
2019-03-28 23:26       ` Honnappa Nagarahalli
2019-03-28 23:26         ` Honnappa Nagarahalli
2019-03-29 19:23         ` Eads, Gage
2019-03-29 19:23           ` Eads, Gage
2019-03-29 21:07           ` Thomas Monjalon
2019-03-29 21:07             ` Thomas Monjalon
2019-04-01 17:41           ` Honnappa Nagarahalli
2019-04-01 17:41             ` Honnappa Nagarahalli
2019-04-01 19:34             ` Eads, Gage
2019-04-01 19:34               ` Eads, Gage
2019-03-06 14:45     ` [dpdk-dev] [PATCH v3 2/8] mempool/stack: convert mempool to use rte stack Gage Eads
2019-03-06 14:45     ` [dpdk-dev] [PATCH v3 3/8] test/stack: add stack test Gage Eads
2019-03-14  8:00       ` Olivier Matz
2019-03-14  8:00         ` Olivier Matz
2019-03-06 14:45     ` [dpdk-dev] [PATCH v3 4/8] test/stack: add stack perf test Gage Eads
2019-03-06 14:45     ` [dpdk-dev] [PATCH v3 5/8] stack: add lock-free stack implementation Gage Eads
2019-03-14  8:01       ` Olivier Matz
2019-03-14  8:01         ` Olivier Matz
2019-03-28 23:27       ` Honnappa Nagarahalli
2019-03-28 23:27         ` Honnappa Nagarahalli
2019-03-29 19:25         ` Eads, Gage
2019-03-29 19:25           ` Eads, Gage
2019-03-06 14:45     ` [dpdk-dev] [PATCH v3 6/8] stack: add C11 atomic implementation Gage Eads
2019-03-14  8:04       ` Olivier Matz
2019-03-14  8:04         ` Olivier Matz
2019-03-28 23:27       ` Honnappa Nagarahalli
2019-03-28 23:27         ` Honnappa Nagarahalli
2019-03-29 19:24         ` Eads, Gage
2019-03-29 19:24           ` Eads, Gage
2019-04-01  0:06           ` Eads, Gage
2019-04-01  0:06             ` Eads, Gage
2019-04-01 19:06             ` Honnappa Nagarahalli
2019-04-01 19:06               ` Honnappa Nagarahalli
2019-04-01 20:21               ` Eads, Gage
2019-04-01 20:21                 ` Eads, Gage
2019-03-06 14:45     ` [dpdk-dev] [PATCH v3 7/8] test/stack: add lock-free stack tests Gage Eads
2019-03-06 14:45     ` [dpdk-dev] [PATCH v3 8/8] mempool/stack: add lock-free stack mempool handler Gage Eads
2019-03-28 18:00     ` [dpdk-dev] [PATCH v4 0/8] Add stack library and new " Gage Eads
2019-03-28 18:00       ` Gage Eads
2019-03-28 18:00       ` [dpdk-dev] [PATCH v4 1/8] stack: introduce rte stack library Gage Eads
2019-03-28 18:00         ` Gage Eads
2019-03-28 18:00       ` [dpdk-dev] [PATCH v4 2/8] mempool/stack: convert mempool to use rte stack Gage Eads
2019-03-28 18:00         ` Gage Eads
2019-03-28 18:00       ` [dpdk-dev] [PATCH v4 3/8] test/stack: add stack test Gage Eads
2019-03-28 18:00         ` Gage Eads
2019-03-28 18:00       ` [dpdk-dev] [PATCH v4 4/8] test/stack: add stack perf test Gage Eads
2019-03-28 18:00         ` Gage Eads
2019-03-28 18:00       ` [dpdk-dev] [PATCH v4 5/8] stack: add lock-free stack implementation Gage Eads
2019-03-28 18:00         ` Gage Eads
2019-03-28 18:00       ` [dpdk-dev] [PATCH v4 6/8] stack: add C11 atomic implementation Gage Eads
2019-03-28 18:00         ` Gage Eads
2019-03-28 18:00       ` [dpdk-dev] [PATCH v4 7/8] test/stack: add lock-free stack tests Gage Eads
2019-03-28 18:00         ` Gage Eads
2019-03-28 18:00       ` [dpdk-dev] [PATCH v4 8/8] mempool/stack: add lock-free stack mempool handler Gage Eads
2019-03-28 18:00         ` Gage Eads
2019-04-01  0:12       ` [dpdk-dev] [PATCH v5 0/8] Add stack library and new " Gage Eads
2019-04-01  0:12         ` Gage Eads
2019-04-01  0:12         ` [dpdk-dev] [PATCH v5 1/8] stack: introduce rte stack library Gage Eads
2019-04-01  0:12           ` Gage Eads
2019-04-01  0:12         ` [dpdk-dev] [PATCH v5 2/8] mempool/stack: convert mempool to use rte stack Gage Eads
2019-04-01  0:12           ` Gage Eads
2019-04-01  0:12         ` [dpdk-dev] [PATCH v5 3/8] test/stack: add stack test Gage Eads
2019-04-01  0:12           ` Gage Eads
2019-04-01  0:12         ` [dpdk-dev] [PATCH v5 4/8] test/stack: add stack perf test Gage Eads
2019-04-01  0:12           ` Gage Eads
2019-04-01  0:12         ` [dpdk-dev] [PATCH v5 5/8] stack: add lock-free stack implementation Gage Eads
2019-04-01  0:12           ` Gage Eads
2019-04-01 18:08           ` Honnappa Nagarahalli
2019-04-01 18:08             ` Honnappa Nagarahalli
2019-04-01  0:12         ` [dpdk-dev] [PATCH v5 6/8] stack: add C11 atomic implementation Gage Eads
2019-04-01  0:12           ` Gage Eads
2019-04-01  0:12         ` [dpdk-dev] [PATCH v5 7/8] test/stack: add lock-free stack tests Gage Eads
2019-04-01  0:12           ` Gage Eads
2019-04-01  0:12         ` [dpdk-dev] [PATCH v5 8/8] mempool/stack: add lock-free stack mempool handler Gage Eads
2019-04-01  0:12           ` Gage Eads
2019-04-01 21:14         ` [dpdk-dev] [PATCH v6 0/8] Add stack library and new " Gage Eads
2019-04-01 21:14           ` Gage Eads
2019-04-01 21:14           ` [dpdk-dev] [PATCH v6 1/8] stack: introduce rte stack library Gage Eads
2019-04-01 21:14             ` Gage Eads
2019-04-02 11:14             ` Honnappa Nagarahalli
2019-04-02 11:14               ` Honnappa Nagarahalli
2019-04-03 17:06               ` Thomas Monjalon
2019-04-03 17:06                 ` Thomas Monjalon
2019-04-03 17:13                 ` Eads, Gage
2019-04-03 17:13                   ` Eads, Gage
2019-04-03 17:23                   ` Thomas Monjalon
2019-04-03 17:23                     ` Thomas Monjalon
2019-04-01 21:14           ` [dpdk-dev] [PATCH v6 2/8] mempool/stack: convert mempool to use rte stack Gage Eads
2019-04-01 21:14             ` Gage Eads
2019-04-01 21:14           ` [dpdk-dev] [PATCH v6 3/8] test/stack: add stack test Gage Eads
2019-04-01 21:14             ` Gage Eads
2019-04-01 21:14           ` [dpdk-dev] [PATCH v6 4/8] test/stack: add stack perf test Gage Eads
2019-04-01 21:14             ` Gage Eads
2019-04-01 21:14           ` [dpdk-dev] [PATCH v6 5/8] stack: add lock-free stack implementation Gage Eads
2019-04-01 21:14             ` Gage Eads
2019-04-01 21:14           ` [dpdk-dev] [PATCH v6 6/8] stack: add C11 atomic implementation Gage Eads
2019-04-01 21:14             ` Gage Eads
2019-04-02 11:11             ` Honnappa Nagarahalli
2019-04-02 11:11               ` Honnappa Nagarahalli
2019-04-01 21:14           ` [dpdk-dev] [PATCH v6 7/8] test/stack: add lock-free stack tests Gage Eads
2019-04-01 21:14             ` Gage Eads
2019-04-01 21:14           ` [dpdk-dev] [PATCH v6 8/8] mempool/stack: add lock-free stack mempool handler Gage Eads
2019-04-01 21:14             ` Gage Eads
2019-04-03 17:04           ` [dpdk-dev] [PATCH v6 0/8] Add stack library and new " Thomas Monjalon
2019-04-03 17:04             ` Thomas Monjalon
2019-04-03 17:10             ` Eads, Gage
2019-04-03 17:10               ` Eads, Gage
2019-04-03 20:09           ` [dpdk-dev] [PATCH v7 " Gage Eads
2019-04-03 20:09             ` Gage Eads
2019-04-03 20:09             ` [dpdk-dev] [PATCH v7 1/8] stack: introduce rte stack library Gage Eads
2019-04-03 20:09               ` Gage Eads
2019-04-03 20:09             ` [dpdk-dev] [PATCH v7 2/8] mempool/stack: convert mempool to use rte stack Gage Eads
2019-04-03 20:09               ` Gage Eads
2019-04-03 20:09             ` [dpdk-dev] [PATCH v7 3/8] test/stack: add stack test Gage Eads
2019-04-03 20:09               ` Gage Eads
2019-04-03 20:09             ` [dpdk-dev] [PATCH v7 4/8] test/stack: add stack perf test Gage Eads
2019-04-03 20:09               ` Gage Eads
2019-04-03 20:09             ` [dpdk-dev] [PATCH v7 5/8] stack: add lock-free stack implementation Gage Eads
2019-04-03 20:09               ` Gage Eads
2019-04-03 20:09             ` [dpdk-dev] [PATCH v7 6/8] stack: add C11 atomic implementation Gage Eads
2019-04-03 20:09               ` Gage Eads
2019-04-03 20:09             ` [dpdk-dev] [PATCH v7 7/8] test/stack: add lock-free stack tests Gage Eads
2019-04-03 20:09               ` Gage Eads
2019-04-03 20:09             ` [dpdk-dev] [PATCH v7 8/8] mempool/stack: add lock-free stack mempool handler Gage Eads
2019-04-03 20:09               ` Gage Eads
2019-04-03 20:39             ` [dpdk-dev] [PATCH v7 0/8] Add stack library and new " Thomas Monjalon
2019-04-03 20:39               ` Thomas Monjalon
2019-04-03 20:49               ` Eads, Gage
2019-04-03 20:49                 ` Eads, Gage
2019-04-03 20:50             ` [dpdk-dev] [PATCH v8 " Gage Eads
2019-04-03 20:50               ` Gage Eads
2019-04-03 20:50               ` [dpdk-dev] [PATCH v8 1/8] stack: introduce rte stack library Gage Eads
2019-04-03 20:50                 ` Gage Eads
2019-04-03 20:50               ` [dpdk-dev] [PATCH v8 2/8] mempool/stack: convert mempool to use rte stack Gage Eads
2019-04-03 20:50                 ` Gage Eads
2019-04-03 20:50               ` [dpdk-dev] [PATCH v8 3/8] test/stack: add stack test Gage Eads
2019-04-03 20:50                 ` Gage Eads
2019-04-03 22:41                 ` Thomas Monjalon
2019-04-03 22:41                   ` Thomas Monjalon
2019-04-03 23:05                   ` Eads, Gage
2019-04-03 23:05                     ` Eads, Gage
2019-04-03 20:50               ` [dpdk-dev] [PATCH v8 4/8] test/stack: add stack perf test Gage Eads
2019-04-03 20:50                 ` Gage Eads
2019-04-03 20:50               ` [dpdk-dev] [PATCH v8 5/8] stack: add lock-free stack implementation Gage Eads
2019-04-03 20:50                 ` Gage Eads
2019-04-03 20:50               ` [dpdk-dev] [PATCH v8 6/8] stack: add C11 atomic implementation Gage Eads
2019-04-03 20:50                 ` Gage Eads
2019-04-03 20:50               ` [dpdk-dev] [PATCH v8 7/8] test/stack: add lock-free stack tests Gage Eads
2019-04-03 20:50                 ` Gage Eads
2019-04-03 20:50               ` [dpdk-dev] [PATCH v8 8/8] mempool/stack: add lock-free stack mempool handler Gage Eads
2019-04-03 20:50                 ` Gage Eads
2019-04-03 23:20               ` [dpdk-dev] [PATCH v9 0/8] Add stack library and new " Gage Eads
2019-04-03 23:20                 ` Gage Eads
2019-04-03 23:20                 ` [dpdk-dev] [PATCH v9 1/8] stack: introduce rte stack library Gage Eads
2019-04-03 23:20                   ` Gage Eads
2019-04-04 13:30                   ` Thomas Monjalon
2019-04-04 13:30                     ` Thomas Monjalon
2019-04-04 14:14                     ` Eads, Gage [this message]
2019-04-04 14:14                       ` Eads, Gage
2019-04-03 23:20                 ` [dpdk-dev] [PATCH v9 2/8] mempool/stack: convert mempool to use rte stack Gage Eads
2019-04-03 23:20                   ` Gage Eads
2019-04-03 23:20                 ` [dpdk-dev] [PATCH v9 3/8] test/stack: add stack test Gage Eads
2019-04-03 23:20                   ` Gage Eads
2019-04-04  7:34                   ` Thomas Monjalon
2019-04-04  7:34                     ` Thomas Monjalon
2019-04-03 23:20                 ` [dpdk-dev] [PATCH v9 4/8] test/stack: add stack perf test Gage Eads
2019-04-03 23:20                   ` Gage Eads
2019-04-03 23:20                 ` [dpdk-dev] [PATCH v9 5/8] stack: add lock-free stack implementation Gage Eads
2019-04-03 23:20                   ` Gage Eads
2019-04-03 23:20                 ` [dpdk-dev] [PATCH v9 6/8] stack: add C11 atomic implementation Gage Eads
2019-04-03 23:20                   ` Gage Eads
2019-04-03 23:20                 ` [dpdk-dev] [PATCH v9 7/8] test/stack: add lock-free stack tests Gage Eads
2019-04-03 23:20                   ` Gage Eads
2019-04-03 23:20                 ` [dpdk-dev] [PATCH v9 8/8] mempool/stack: add lock-free stack mempool handler Gage Eads
2019-04-03 23:20                   ` Gage Eads
2019-04-04 10:01                 ` [dpdk-dev] [PATCH v10 0/8] Add stack library and new " Gage Eads
2019-04-04 10:01                   ` Gage Eads
2019-04-04 10:01                   ` [dpdk-dev] [PATCH v10 1/8] stack: introduce rte stack library Gage Eads
2019-04-04 10:01                     ` Gage Eads
2019-04-04 10:01                   ` [dpdk-dev] [PATCH v10 2/8] mempool/stack: convert mempool to use rte stack Gage Eads
2019-04-04 10:01                     ` Gage Eads
2019-04-04 10:01                   ` [dpdk-dev] [PATCH v10 3/8] test/stack: add stack test Gage Eads
2019-04-04 10:01                     ` Gage Eads
2019-04-04 10:01                   ` [dpdk-dev] [PATCH v10 4/8] test/stack: add stack perf test Gage Eads
2019-04-04 10:01                     ` Gage Eads
2019-04-04 10:01                   ` [dpdk-dev] [PATCH v10 5/8] stack: add lock-free stack implementation Gage Eads
2019-04-04 10:01                     ` Gage Eads
2019-04-04 10:01                   ` [dpdk-dev] [PATCH v10 6/8] stack: add C11 atomic implementation Gage Eads
2019-04-04 10:01                     ` Gage Eads
2019-04-04 10:01                   ` [dpdk-dev] [PATCH v10 7/8] test/stack: add lock-free stack tests Gage Eads
2019-04-04 10:01                     ` Gage Eads
2019-04-04 10:01                   ` [dpdk-dev] [PATCH v10 8/8] mempool/stack: add lock-free stack mempool handler Gage Eads
2019-04-04 10:01                     ` Gage Eads
2019-04-04 15:42                   ` [dpdk-dev] [PATCH v10 0/8] Add stack library and new " Thomas Monjalon
2019-04-04 15:42                     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9184057F7FC11744A2107296B6B8EB1E54210E03@FMSMSX108.amr.corp.intel.com \
    --to=gage.eads@intel.com \
    --cc=Honnappa.Nagarahalli@arm.com \
    --cc=arybchenko@solarflare.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=gavin.hu@arm.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=nd@arm.com \
    --cc=olivier.matz@6wind.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).