From: "Trahe, Fiona" <fiona.trahe@intel.com>
To: "Iremonger, Bernard" <bernard.iremonger@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"akhil.goyal@nxp.com" <akhil.goyal@nxp.com>
Cc: "Trahe, Fiona" <fiona.trahe@intel.com>
Subject: Re: [dpdk-dev] [PATCH] crypto/qat: fix second seg fault in QAT PMD
Date: Mon, 8 Apr 2019 16:44:12 +0000 [thread overview]
Message-ID: <348A99DA5F5B7549AA880327E580B4358973BD1D@IRSMSX101.ger.corp.intel.com> (raw)
Message-ID: <20190408164412.U8V2APc6tlnAk4uGQE_mMUgB0XgXdbg8gx7qNlkM2nU@z> (raw)
In-Reply-To: <1554726370-16591-1-git-send-email-bernard.iremonger@intel.com>
Hi Bernard,
> -----Original Message-----
> From: Iremonger, Bernard
> Sent: Monday, April 8, 2019 1:26 PM
> To: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>; akhil.goyal@nxp.com
> Cc: Iremonger, Bernard <bernard.iremonger@intel.com>
> Subject: [PATCH] crypto/qat: fix second seg fault in QAT PMD
>
> While running the IPsec unit tests the following
> segmentation fault is occurring:
>
> Thread 1 "test" received signal SIGSEGV, Segmentation fault.
> 0x0000000000bf3b50 in qat_sym_process_response (
> op=0x5355280 <unittest_params+512>, resp=0x100455100 "")
> at /root/dpdk/drivers/crypto/qat/qat_sym.h:161
> 161 if (sess->bpi_ctx)
>
> Fixes: 91614c73b67c ("crypto/qat: make response process function inline")
> Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
> ---
> drivers/crypto/qat/qat_sym.h | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/crypto/qat/qat_sym.h b/drivers/crypto/qat/qat_sym.h
> index bc6426c..685c6c0 100644
> --- a/drivers/crypto/qat/qat_sym.h
> +++ b/drivers/crypto/qat/qat_sym.h
> @@ -157,10 +157,12 @@ qat_sym_process_response(void **op, uint8_t *resp)
> rx_op->sym->session,
> cryptodev_qat_driver_id);
>
> -
> - if (sess->bpi_ctx)
> + if (sess == NULL)
> + rx_op->status = RTE_CRYPTO_OP_STATUS_AUTH_FAILED;
> + else if (sess->bpi_ctx) {
> qat_bpicipher_postprocess(sess, rx_op);
> - rx_op->status = RTE_CRYPTO_OP_STATUS_SUCCESS;
> + rx_op->status = RTE_CRYPTO_OP_STATUS_SUCCESS;
> + }
> }
> *op = (void *)rx_op;
> }
> --
> 2.7.4
[Fiona] As for previous seg-fault- this is on data-path and likely due to the application sending
in an invalid session - or a session created for a symmetric PMD, but being sent to a
QAT asymmetric PMD - whose driver_id would not appear in the session array.
Can you make sure to check for SYMMETRIC support in capabilities.
next prev parent reply other threads:[~2019-04-08 16:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 12:26 Bernard Iremonger
2019-04-08 12:26 ` Bernard Iremonger
2019-04-08 16:44 ` Trahe, Fiona [this message]
2019-04-08 16:44 ` Trahe, Fiona
2019-04-08 16:56 ` Iremonger, Bernard
2019-04-08 16:56 ` Iremonger, Bernard
2019-04-10 14:19 ` Iremonger, Bernard
2019-04-10 14:19 ` Iremonger, Bernard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=348A99DA5F5B7549AA880327E580B4358973BD1D@IRSMSX101.ger.corp.intel.com \
--to=fiona.trahe@intel.com \
--cc=akhil.goyal@nxp.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).