From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>, dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH 4/5] examples/l2fwd-cat: fix build on FreeBSD
Date: Tue, 9 Apr 2019 11:40:00 +0100 [thread overview]
Message-ID: <20190409103959.GA671@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <CAJFAV8wE4h3yy_HxZ+cSJXt7vJwdQQo2-pRcRW74pCS96apAsw@mail.gmail.com>
On Tue, Apr 09, 2019 at 12:34:06PM +0200, David Marchand wrote:
> On Tue, Apr 9, 2019 at 12:03 PM Bruce Richardson
> <[1]bruce.richardson@intel.com> wrote:
>
> On Tue, Apr 09, 2019 at 11:56:04AM +0200, David Marchand wrote:
> > On Tue, Apr 9, 2019 at 11:30 AM Bruce Richardson
> > <[1][2]bruce.richardson@intel.com> wrote:
> >
> > The definition of CPU_AND differs from Linux to BSD, so we
> need to
> > use
> > RTE_CPU_AND instead.
> > Fixes: f6baccbc2b3b ("examples/l2fwd-cat: add sample
> application for
> > PQoS CAT and CDP")
> > Cc: [2][3]stable@dpdk.org
> >
> > This creates a dependency on backporting c3568ea37670 ("eal:
> restrict
> > control threads to startup CPU affinity") which introduced the
> > RTE_CPU_AND macro.
> > --
> > David Marchand
> >
> Shall I drop the stable reference from the v2, then?
>
> We can backport in 18.11, as I would expect c3568ea37670 to be
> backported.
> The question is more what we want to do with 17.11.
> We could backport only the macro bits from this patch if needed.
> --
Yes. I'll leave the stable cc and then each maintainer can decide
themselves on backport. I'll include note in the patch (below cutline) to
call out dependency explicitly.
/Bruce
next prev parent reply other threads:[~2019-04-09 10:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190409092933.55356-1-bruce.richardson@intel.com>
2019-04-09 9:29 ` [dpdk-stable] " Bruce Richardson
2019-04-09 9:56 ` [dpdk-stable] [dpdk-dev] " David Marchand
2019-04-09 10:03 ` Bruce Richardson
2019-04-09 10:34 ` David Marchand
2019-04-09 10:40 ` Bruce Richardson [this message]
2019-04-09 10:40 ` Luca Boccassi
2019-04-09 11:09 ` David Marchand
2019-04-09 10:40 ` Luca Boccassi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190409103959.GA671@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).