From: Rami Rosen <ramirose@gmail.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>, dev <dev@dpdk.org>,
stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] kni: fix build for ndo_fdb_add in Linux 5.1
Date: Tue, 9 Apr 2019 20:59:09 +0300 [thread overview]
Message-ID: <CAHLOa7Tvs0A_wbCSmsyCVMDEKMMDhh3XA=_GaS+DmX-yWmwQUg@mail.gmail.com> (raw)
Message-ID: <20190409175909.QjqthTzT2wrd45DNtGL2PZO94APGy6aMQiGXEQCDEMY@z> (raw)
In-Reply-To: <20190408200035.GA1146@bricha3-MOBL.ger.corp.intel.com>
On Mon, Apr 08, 2019 at 03:22:26PM +0100, Ferruh Yigit wrote:
> Build error seen with Linux kernel 5.1 and
> when CONFIG_RTE_KNI_KMOD_ETHTOOL is enabled.
>
> Build error:
> .../dpdk/build/build/kernel/linux/kni/igb_main.c:2352:18:
> error: initialization of ... from incompatible pointer type ...
> [-Werror=incompatible-pointer-types]
> .ndo_fdb_add = igb_ndo_fdb_add,
> ^~~~~~~~~~~~~~~
>
> ndo_fdb_add() is changed in Linux kernel version 5.1 and now requires
> a new parameter, 'struct netlink_ext_ack *extack':
> Linux Commit 87b0984ebfab ("net: Add extack argument to ndo_fdb_add()")
>
> ndo_fdb_add() parameter updated with compile time Linux kernel version
> check.
>
> Cc: stable@dpdk.org
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
Tested-by: Bruce Richardson <bruce.richardson@intel.com>
Thanks.
Checked build with CONFIG_RTE_KNI_KMOD_ETHTOOL=y
after applying the patch, build was done against the bleeding edge of
net-next of today (kernel 5.1-rc4).
Build of the kni kernel module completed successfully.
Reviewed-by: Rami Rosen <ramirose@gmail.com>
next prev parent reply other threads:[~2019-04-09 17:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 14:22 Ferruh Yigit
2019-04-08 14:22 ` Ferruh Yigit
2019-04-08 20:00 ` Bruce Richardson
2019-04-08 20:00 ` Bruce Richardson
2019-04-09 17:59 ` Rami Rosen [this message]
2019-04-09 17:59 ` Rami Rosen
2019-04-19 10:26 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2019-04-19 10:26 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHLOa7Tvs0A_wbCSmsyCVMDEKMMDhh3XA=_GaS+DmX-yWmwQUg@mail.gmail.com' \
--to=ramirose@gmail.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).