From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: Aaron Conole <aconole@redhat.com>, dev <dev@dpdk.org>,
Luca Boccassi <bluca@debian.org>,
Reshma Pattan <reshma.pattan@intel.com>,
Agalya Babu RadhaKrishnan <agalyax.babu.radhakrishnan@intel.com>,
David Marchand <dmarchan@redhat.com>
Subject: Re: [dpdk-dev] [PATCH 3/3] app/test/meson: auto detect number of cores
Date: Fri, 12 Apr 2019 10:06:01 +0100 [thread overview]
Message-ID: <20190412090601.GA1723@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <CAJFAV8y_pJyLaSHsipU=XyfYy5ubrPGtEVSmGL5q-ejgrdviJw@mail.gmail.com>
On Fri, Apr 12, 2019 at 09:46:17AM +0200, David Marchand wrote:
> On Thu, Apr 11, 2019 at 9:52 PM Aaron Conole <[1]aconole@redhat.com>
> wrote:
>
> The arguments being passed will cause failures on laptops that have,
> for instance, 2 cores only. Most of the tests don't require more
> than a single core. Some require multiple cores (but those tests
> should be modified to 'SKIP' when the correct number of cores
> aren't available).
> The unit test results shouldn't be impacted by this change, but it
> allows for a future enhancement to pass flags such as '--no-huge'.
> Also include a fix to a reported issue with running on FreeBSD.
> Signed-off-by: Aaron Conole <[2]aconole@redhat.com>
> ---
> Conflicts with [3]http://patches.dpdk.org/patch/50850/
> app/test/meson.build | 24 +++++++++++++++++++++---
> 1 file changed, 21 insertions(+), 3 deletions(-)
> diff --git a/app/test/meson.build b/app/test/meson.build
> index 867cc5863..1010bfbc8 100644
> --- a/app/test/meson.build
> +++ b/app/test/meson.build
> @@ -344,17 +344,32 @@ if get_option('tests')
> timeout_seconds = 600
> timeout_seconds_fast = 10
> + # Retreive the number of CPU cores
>
> nit: Retrieve
> Little concern here on the approach of getting the max available cpu
> index.
> If we have non contiguous cpus (let's say hyper threading is disabled),
> this won't work.
> But we can just assume this won't happen for non regression setups
> (vms).
>
> + num_cores = run_command('lscpu',
> '-p=cpu').stdout().strip().split('\n')[-1]
>
> lscpu is a linux command afaik.
> Maybe for FreeBSD:
> root@freebsd-10:~ # sysctl dev.cpu |cut -d . -f 3 |sort |tail -1
> 3
> Not sure if FreeBSD ensures that the keys names/objects won't change
> accross the versions.
>
Very similar thoughs/concerns here. I think doing this per OS is probably
safer in the long term - even though lscpu is available for FreeBSD as an
extra package.
My suggestion: for FreeBSD, get the number of CPUs using
"/sbin/sysctl -n hw.ncpu"
For Linux, rather than using a "0-N" range, use output from
"cat /sys/devices/system/cpu/present", which will ensure that it works
even in the non-contiguous CPU numbering case. [Though I suspect we get
non-contiguous numbers only in the case a core or two has been hotplugged
out, I think - disabling hyperthreading won't leave gaps, just fewer cores]
/Bruce
next prev parent reply other threads:[~2019-04-12 9:06 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-11 19:52 [dpdk-dev] [PATCH 0/3] travis: enhancements for build (plus a meson fix) Aaron Conole
2019-04-11 19:52 ` Aaron Conole
2019-04-11 19:52 ` [dpdk-dev] [PATCH 1/3] travis: enable ccache Aaron Conole
2019-04-11 19:52 ` Aaron Conole
2019-04-12 7:46 ` David Marchand
2019-04-12 7:46 ` David Marchand
2019-04-12 9:16 ` Luca Boccassi
2019-04-12 9:16 ` Luca Boccassi
2019-04-11 19:52 ` [dpdk-dev] [PATCH 2/3] travis: add a distinguisher to the 'extra' builds Aaron Conole
2019-04-11 19:52 ` Aaron Conole
2019-04-12 7:46 ` David Marchand
2019-04-12 7:46 ` David Marchand
2019-04-12 9:17 ` Luca Boccassi
2019-04-12 9:17 ` Luca Boccassi
2019-04-11 19:52 ` [dpdk-dev] [PATCH 3/3] app/test/meson: auto detect number of cores Aaron Conole
2019-04-11 19:52 ` Aaron Conole
2019-04-12 7:46 ` David Marchand
2019-04-12 7:46 ` David Marchand
2019-04-12 9:06 ` Bruce Richardson [this message]
2019-04-12 9:06 ` Bruce Richardson
2019-04-12 9:17 ` Luca Boccassi
2019-04-12 9:17 ` Luca Boccassi
2019-04-12 16:21 ` [dpdk-dev] [PATCH v2 0/3] travis: enhancements for build (plus a meson fix) Aaron Conole
2019-04-12 16:21 ` Aaron Conole
2019-04-12 16:21 ` [dpdk-dev] [PATCH v2 1/3] travis: enable ccache Aaron Conole
2019-04-12 16:21 ` Aaron Conole
2019-04-12 16:21 ` [dpdk-dev] [PATCH v2 2/3] travis: add a distinguisher to the 'extra' builds Aaron Conole
2019-04-12 16:21 ` Aaron Conole
2019-04-12 16:21 ` [dpdk-dev] [PATCH v2 3/3] app/test/meson: auto detect number of cores Aaron Conole
2019-04-12 16:21 ` Aaron Conole
2019-04-12 16:36 ` Bruce Richardson
2019-04-12 16:36 ` Bruce Richardson
2019-04-12 18:21 ` Aaron Conole
2019-04-12 18:21 ` Aaron Conole
2019-04-15 9:14 ` Bruce Richardson
2019-04-15 9:14 ` Bruce Richardson
2019-04-17 12:09 ` [dpdk-dev] [PATCH v2 0/3] travis: enhancements for build (plus a meson fix) Thomas Monjalon
2019-04-17 12:09 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190412090601.GA1723@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=aconole@redhat.com \
--cc=agalyax.babu.radhakrishnan@intel.com \
--cc=bluca@debian.org \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmarchan@redhat.com \
--cc=reshma.pattan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).