From: "Hunt, David" <david.hunt@intel.com>
To: Lukasz Gosiewski <lukaszx.gosiewski@intel.com>
Cc: dev@dpdk.org, lukaszx.krakowiak@intel.com
Subject: Re: [dpdk-dev] [PATCH v3] power: update for handling fifo path string
Date: Mon, 15 Apr 2019 16:50:40 +0100 [thread overview]
Message-ID: <f0d60c49-45e9-c6ee-68e1-8673c48b488f@intel.com> (raw)
Message-ID: <20190415155040.TOLN1ZczL0bkIV4YZuVT_8JakSIr5Isx5pgW3ClYfrE@z> (raw)
In-Reply-To: <20190415100109.6240-1-lukaszx.gosiewski@intel.com>
Hi Lukasz,
On 15/4/2019 11:01 AM, Lukasz Gosiewski wrote:
> From: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>
>
> Removed doubled created fifo path string for channel info.
>
> ---
> v3:
> *improvement to coding style
>
> v2:
> * rebase to master changes
>
> Signed-off-by: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>
> Signed-off-by: Lukasz Gosiewski <lukaszx.gosiewski@intel.com>
> ---
> examples/vm_power_manager/channel_manager.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/examples/vm_power_manager/channel_manager.c b/examples/vm_power_manager/channel_manager.c
> index 0187f79ab..05c0eea44 100644
> --- a/examples/vm_power_manager/channel_manager.c
> +++ b/examples/vm_power_manager/channel_manager.c
> @@ -24,6 +24,7 @@
> #include <rte_log.h>
> #include <rte_atomic.h>
> #include <rte_spinlock.h>
> +#include <rte_string_fns.h>
>
> #include <libvirt/libvirt.h>
>
> @@ -362,8 +363,6 @@ setup_host_channel_info(struct channel_info **chan_info_dptr,
> chan_info->status = CHANNEL_MGR_CHANNEL_DISCONNECTED;
> chan_info->type = CHANNEL_TYPE_JSON;
>
> - fifo_path(chan_info->channel_path, sizeof(chan_info->channel_path));
> -
> if (open_host_channel(chan_info) < 0) {
> RTE_LOG(ERR, CHANNEL_MANAGER, "Could not open host channel: "
> "'%s'\n",
> @@ -563,8 +562,8 @@ add_host_channel(void)
> "channel '%s'\n", socket_path);
> return 0;
> }
> - strlcpy(chan_info->channel_path, socket_path,
> - sizeof(chan_info->channel_path));
> + rte_strlcpy(chan_info->channel_path, socket_path, UNIX_PATH_MAX);
> +
> if (setup_host_channel_info(&chan_info, 0) < 0) {
> rte_free(chan_info);
> return 0;
I'm not seeing this patch in patchwork, I'm seeing the original v1 from
Lukasz K. Can you try re-sending to mailing list? If it's not in
patchwork, it won't get applied.
Rgds,
Dave.
next prev parent reply other threads:[~2019-04-15 15:51 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 11:52 [dpdk-dev] [PATCH] " Lukasz Krakowiak
2019-04-03 11:52 ` Lukasz Krakowiak
2019-04-15 7:33 ` [dpdk-dev] [PATCH v2 1/3] " Lukasz Gosiewski
2019-04-15 7:33 ` Lukasz Gosiewski
2019-04-15 10:01 ` [dpdk-dev] [PATCH v3] " Lukasz Gosiewski
2019-04-15 10:01 ` Lukasz Gosiewski
2019-04-15 15:50 ` Hunt, David [this message]
2019-04-15 15:50 ` Hunt, David
2019-04-16 7:02 ` Lukasz Gosiewski
2019-04-16 7:02 ` Lukasz Gosiewski
2019-04-16 8:16 ` Hunt, David
2019-04-16 8:16 ` Hunt, David
2019-04-16 8:19 ` Krakowiak, LukaszX
2019-04-16 8:19 ` Krakowiak, LukaszX
2019-04-16 8:23 ` Gosiewski, LukaszX
2019-04-16 8:23 ` Gosiewski, LukaszX
2019-04-16 16:17 ` Ferruh Yigit
2019-04-16 16:17 ` Ferruh Yigit
2019-04-16 10:20 ` [dpdk-dev] [PATCH v4] " Lukasz Gosiewski
2019-04-16 10:20 ` Lukasz Gosiewski
2019-04-17 12:21 ` Hunt, David
2019-04-17 12:21 ` Hunt, David
2019-07-04 20:06 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0d60c49-45e9-c6ee-68e1-8673c48b488f@intel.com \
--to=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=lukaszx.gosiewski@intel.com \
--cc=lukaszx.krakowiak@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).