From: Bruce Richardson <bruce.richardson@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "Liang, Ma" <liang.j.ma@intel.com>, Lee Daly <lee.daly@intel.com>,
david.hunt@intel.com, dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] lib/librte_power: set new frequecy on turbo_disable
Date: Tue, 16 Apr 2019 10:25:12 +0100 [thread overview]
Message-ID: <20190416092511.GA1861@bricha3-MOBL.ger.corp.intel.com> (raw)
Message-ID: <20190416092512.JMz-GKO5pYZ_iz22S75gQWC2aSou14E5Lhh8e2d7GZQ@z> (raw)
In-Reply-To: <20190415093640.7ef236c8@shemminger-XPS-13-9360>
On Mon, Apr 15, 2019 at 09:36:40AM -0700, Stephen Hemminger wrote:
> On Mon, 15 Apr 2019 17:11:10 +0100
> "Liang, Ma" <liang.j.ma@intel.com> wrote:
>
> > > pi->turbo_enable = 0;
> > >
> > > -
> > > + if ((pi->turbo_available) && (pi->curr_idx <= 1)) {
>
> You (don't) need (so many) parenthesis.
True (but it doesn't hurt (either)) :-)
next prev parent reply other threads:[~2019-04-16 9:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-12 15:57 Lee Daly
2019-04-12 15:57 ` Lee Daly
2019-04-15 9:21 ` Hunt, David
2019-04-15 9:21 ` Hunt, David
2019-04-22 22:12 ` Thomas Monjalon
2019-04-22 22:12 ` Thomas Monjalon
2019-04-15 16:11 ` Liang, Ma
2019-04-15 16:11 ` Liang, Ma
2019-04-15 16:36 ` Stephen Hemminger
2019-04-15 16:36 ` Stephen Hemminger
2019-04-16 9:25 ` Bruce Richardson [this message]
2019-04-16 9:25 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190416092511.GA1861@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=lee.daly@intel.com \
--cc=liang.j.ma@intel.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).