DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Christensen <drc@linux.vnet.ibm.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
	"Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Cc: Andrew Rybchenko <arybchenko@solarflare.com>,
	"Yigit, Ferruh" <ferruh.yigit@intel.com>,
	"thomas@monjalon.net" <thomas@monjalon.net>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"radhika.chirra@ibm.com" <radhika.chirra@ibm.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] ethdev: missing typecast causes C++ build error
Date: Tue, 16 Apr 2019 14:50:39 -0700	[thread overview]
Message-ID: <adb2aed7-9793-66e2-7e98-94a0dbe17857@linux.vnet.ibm.com> (raw)
Message-ID: <20190416215039._0fcwygIGXeZxJeCyhQrvd4GPPeIkv5aMBvpDTiBuF0@z> (raw)
In-Reply-To: <20190416141919.523b4c8b@xps13.lan>

>>>>> In file included from drivers/pmd.cc:7:0:
>>>>> /home/rchirra/gen/io/deps/dpdk/build/include/rte_ethdev_pci.h:
>>>>> In function ‘int eth_dev_pci_specific_init(rte_eth_dev*, void*)’:
>>>>> /home/rchirra/gen/io/deps/dpdk/build/include/rte_ethdev_pci.h:75:35:·
>>>>> error: invalid conversion from ‘void*’ to ‘rte_pci_device*’
>>>>> [-fpermissive]
>>>>>     struct rte_pci_device *pci_dev = bus_device;
>>>>>                                      ^~~~~~~~~~
>>>>> make[1]: *** [drivers/pmd.o] Error 1
>>>>>
>>>>> $ g++ --version
>>>>> g++ (Ubuntu 7.3.0-27ubuntu1~18.04) 7.3.0
>>>> This problem is while building a driver with c++ compiler, but since the
>>>> solution is a simple casting, which doesn't have any side affect, I am for
>>>> getting the patch, any objection?
>>>
>>> It should be a decision that we support PMDs in C++ (if I understand
>>> the usage correctly) and it will require all headers to be compatible and
>>> ideally it should be checked by build automation (otherwise we will break
>>> and fix it pretty often).
>>
>> Or as alternative, we probably can claim that PMDs in C++ are not supported,
>> and if people like to do that - they have to deal with it on their own
>> (create a C wrapper file, or so).
>> Konstantin
>>
> +1 no drivers or other parts of EAL in C++
> 
I've learned more about the intended usage in this case and it turns out 
not to be a PMD at all, it's an application that's reaching into the EAL 
in what I consider an inappropriate way.  As a result I'm withdrawing 
the patch request and I'll work with the developers to find an alternate 
solution to their problem.

Dave


  parent reply	other threads:[~2019-04-16 21:50 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-10 20:16 [dpdk-dev] [PATCH] ethdev: missing typecast from void in eth_dev_pci_specific_init David Christensen
2019-04-10 20:16 ` David Christensen
2019-04-10 20:29 ` Thomas Monjalon
2019-04-10 20:29   ` Thomas Monjalon
2019-04-10 20:58   ` David Christensen
2019-04-10 20:58     ` David Christensen
2019-04-10 21:14     ` Thomas Monjalon
2019-04-10 21:14       ` Thomas Monjalon
2019-04-12 17:13       ` Ferruh Yigit
2019-04-12 17:13         ` Ferruh Yigit
2019-04-10 21:00 ` Bruce Richardson
2019-04-10 21:00   ` Bruce Richardson
2019-04-10 23:08   ` Stephen Hemminger
2019-04-10 23:08     ` Stephen Hemminger
2019-04-12 17:09     ` Ferruh Yigit
2019-04-12 17:09       ` Ferruh Yigit
2019-04-12 17:15       ` Ananyev, Konstantin
2019-04-12 17:15         ` Ananyev, Konstantin
2019-04-12 17:25         ` Ferruh Yigit
2019-04-12 17:25           ` Ferruh Yigit
2019-04-12 17:29           ` Ferruh Yigit
2019-04-12 17:29             ` Ferruh Yigit
2019-04-12 21:31             ` Stephen Hemminger
2019-04-12 21:31               ` Stephen Hemminger
2019-04-15 16:00               ` Ferruh Yigit
2019-04-15 16:00                 ` Ferruh Yigit
2019-04-10 21:36 ` [dpdk-dev] [PATCH v2] ethdev: missing typecast causes C++ build error David Christensen
2019-04-10 21:36   ` David Christensen
2019-04-16 16:31   ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2019-04-16 16:31     ` Ferruh Yigit
2019-04-16 16:39     ` Andrew Rybchenko
2019-04-16 16:39       ` Andrew Rybchenko
2019-04-16 16:46       ` Ananyev, Konstantin
2019-04-16 16:46         ` Ananyev, Konstantin
2019-04-16 21:19         ` Stephen Hemminger
2019-04-16 21:19           ` Stephen Hemminger
2019-04-16 21:50           ` David Christensen [this message]
2019-04-16 21:50             ` David Christensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adb2aed7-9793-66e2-7e98-94a0dbe17857@linux.vnet.ibm.com \
    --to=drc@linux.vnet.ibm.com \
    --cc=arybchenko@solarflare.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=radhika.chirra@ibm.com \
    --cc=stable@dpdk.org \
    --cc=stephen@networkplumber.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).