DPDK patches and discussions
 help / color / mirror / Atom feed
From: Wang Ying A <ying.a.wang@intel.com>
To: wenzhuo.lu@intel.com, qiming.yang@intel.com, qi.z.zhang@intel.com
Cc: dev@dpdk.org, ramirose@gmail.com,
	Wang Ying A <ying.a.wang@intel.com>,
	stable@dpdk.org
Subject: [dpdk-dev] [PATCH v2 2/2] net/ice: fix promiscuous mode
Date: Wed, 17 Apr 2019 09:47:52 +0800	[thread overview]
Message-ID: <1555465672-288172-3-git-send-email-ying.a.wang@intel.com> (raw)
Message-ID: <20190417014752.0Af_K01zwq19ygtOiQFnfi7uDtwOa8vsGZ28HlYuIrY@z> (raw)
In-Reply-To: <1555465672-288172-1-git-send-email-ying.a.wang@intel.com>

When device promiscuous mode has already been enabled,
should not return error if user re-enable it.

Fixes: c945e4bf9063 ("net/ice: support promiscuous mode")
Cc: stable@dpdk.org

Signed-off-by: Wang Ying A <ying.a.wang@intel.com>
---
 drivers/net/ice/ice_ethdev.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index 3263337..8811057 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -2763,7 +2763,9 @@ static int ice_macaddr_set(struct rte_eth_dev *dev,
 		ICE_PROMISC_MCAST_RX | ICE_PROMISC_MCAST_TX;
 
 	status = ice_set_vsi_promisc(hw, vsi->idx, pmask, 0);
-	if (status != ICE_SUCCESS)
+	if (status == ICE_ERR_ALREADY_EXISTS)
+		PMD_DRV_LOG(DEBUG, "Promisc mode has already been enabled");
+	else if (status != ICE_SUCCESS)
 		PMD_DRV_LOG(ERR, "Failed to enable promisc, err=%d", status);
 }
 
-- 
1.8.3.1


  parent reply	other threads:[~2019-04-17  2:00 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-12 13:52 [dpdk-dev] [PATCH 0/2] ice: code clean and promisc mode fix Wang Ying A
2019-04-12 13:52 ` Wang Ying A
2019-04-12 13:52 ` [dpdk-dev] [PATCH 1/2] net/ice: code clean Wang Ying A
2019-04-12 13:52   ` Wang Ying A
2019-04-15 12:43   ` Zhang, Qi Z
2019-04-15 12:43     ` Zhang, Qi Z
2019-04-17  0:45     ` Wang, Ying A
2019-04-17  0:45       ` Wang, Ying A
2019-04-17  1:47   ` [dpdk-dev] [PATCH v2 0/2] ice: fix wrong type and promisc mode Wang Ying A
2019-04-17  1:47     ` Wang Ying A
2019-04-17  1:47     ` [dpdk-dev] [PATCH v2 1/2] net/ice: fix wrong type Wang Ying A
2019-04-17  1:47       ` Wang Ying A
2019-04-17  1:47     ` Wang Ying A [this message]
2019-04-17  1:47       ` [dpdk-dev] [PATCH v2 2/2] net/ice: fix promiscuous mode Wang Ying A
2019-04-17  3:09     ` [dpdk-dev] [PATCH v2 0/2] ice: fix wrong type and promisc mode Yang, Qiming
2019-04-17  3:09       ` Yang, Qiming
2019-04-17  3:46       ` Zhang, Qi Z
2019-04-17  3:46         ` Zhang, Qi Z
2019-04-12 13:52 ` [dpdk-dev] [PATCH 2/2] net/ice: fix promiscuous mode Wang Ying A
2019-04-12 13:52   ` Wang Ying A
2019-04-15 21:40   ` Rami Rosen
2019-04-15 21:40     ` Rami Rosen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1555465672-288172-3-git-send-email-ying.a.wang@intel.com \
    --to=ying.a.wang@intel.com \
    --cc=dev@dpdk.org \
    --cc=qi.z.zhang@intel.com \
    --cc=qiming.yang@intel.com \
    --cc=ramirose@gmail.com \
    --cc=stable@dpdk.org \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).