DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Qiming Yang <qiming.yang@intel.com>
Cc: dev <dev@dpdk.org>, dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/iavf: fix info get
Date: Wed, 17 Apr 2019 10:46:20 +0200	[thread overview]
Message-ID: <CAJFAV8whE=L+b0onD9=gagj2goc9SWA3CNcwkmcV4BZEDmBiKg@mail.gmail.com> (raw)
Message-ID: <20190417084620.oS93wTIVgxZFqZroKJO1Yi-qJ8i7qN_uaE4TjCb5JbI@z> (raw)
In-Reply-To: <20190417160834.75103-1-qiming.yang@intel.com>

On Wed, Apr 17, 2019 at 10:41 AM Qiming Yang <qiming.yang@intel.com> wrote:

> iavf driver reset the dev_info structure. This action will clear
> the setting in core library. This patch fix that issue.
>
> Fixes: 69dd4c3d0898 ("net/avf: enable queue and device")
>
"Cc: stable@dpdk.org" is supposed to be part of the commitlog.

See
http://doc.dpdk.org/guides/contributing/stable.html#what-changes-should-be-backported


> Signed-off-by: Qiming Yang <qiming.yang@intel.com>
> ---
>  drivers/net/iavf/iavf_ethdev.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/iavf/iavf_ethdev.c
> b/drivers/net/iavf/iavf_ethdev.c
> index 846e604..7825cbc 100644
> --- a/drivers/net/iavf/iavf_ethdev.c
> +++ b/drivers/net/iavf/iavf_ethdev.c
> @@ -498,7 +498,6 @@ iavf_dev_info_get(struct rte_eth_dev *dev, struct
> rte_eth_dev_info *dev_info)
>  {
>         struct iavf_info *vf =
> IAVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
>
> -       memset(dev_info, 0, sizeof(*dev_info));
>         dev_info->max_rx_queues = vf->vsi_res->num_queue_pairs;
>         dev_info->max_tx_queues = vf->vsi_res->num_queue_pairs;
>         dev_info->min_rx_bufsize = IAVF_BUF_SIZE_MIN;
> --
> 2.9.5
>
>
Reviewed-by: David Marchand <david.marchand@redhat.com>

-- 
David Marchand

  reply	other threads:[~2019-04-17  8:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-17 16:08 Qiming Yang
2019-04-17  8:46 ` David Marchand [this message]
2019-04-17  8:46   ` David Marchand
2019-04-17 12:34   ` Ferruh Yigit
2019-04-17 12:34     ` Ferruh Yigit
2019-04-17 16:08 ` Qiming Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJFAV8whE=L+b0onD9=gagj2goc9SWA3CNcwkmcV4BZEDmBiKg@mail.gmail.com' \
    --to=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=qiming.yang@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).