From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: stable@dpdk.org, dev@dpdk.org
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 1/3] devtools/test-meson-builds: skip missing compilers
Date: Wed, 17 Apr 2019 16:59:53 +0200 [thread overview]
Message-ID: <5465672.Kypt5CsLy1@xps> (raw)
Message-ID: <20190417145953.45CfNAztlLnxbC2xJzTKho7E1WgGq-5A1tGmkAiH4-s@z> (raw)
In-Reply-To: <20190410205224.69977-2-bruce.richardson@intel.com>
10/04/2019 22:52, Bruce Richardson:
> if either gcc or clang are missing, skip doing those builds.
> This allows a setup to only do, e.g. gcc tests.
>
> CC: stable@dpdk.org
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> --- a/devtools/test-meson-builds.sh
> +++ b/devtools/test-meson-builds.sh
> # shared and static linked builds with gcc and clang
> for c in gcc clang ; do
> - for s in static shared ; do
> - export CC="ccache $c"
> - build build-$c-$s --default-library=$s
> - done
> + if command -v $c >/dev/null 2>&1 ; then
> + for s in static shared ; do
> + export CC="ccache $c"
> + build build-$c-$s --default-library=$s
> + done
> + fi
May I suggest this oneline change instead?
command -v $c >/dev/null 2>&1 || continue
next prev parent reply other threads:[~2019-04-17 14:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-10 20:52 [dpdk-dev] [PATCH 0/3] fix test-meson-builds for older distros Bruce Richardson
2019-04-10 20:52 ` Bruce Richardson
2019-04-10 20:52 ` [dpdk-dev] [PATCH 1/3] devtools/test-meson-builds: skip missing compilers Bruce Richardson
2019-04-10 20:52 ` Bruce Richardson
2019-04-17 14:59 ` Thomas Monjalon [this message]
2019-04-17 14:59 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2019-04-17 15:04 ` Bruce Richardson
2019-04-17 15:04 ` Bruce Richardson
2019-04-10 20:52 ` [dpdk-dev] [PATCH 2/3] devtools/test-meson-builds: support older compilers Bruce Richardson
2019-04-10 20:52 ` Bruce Richardson
2019-04-10 20:52 ` [dpdk-dev] [PATCH 3/3] devtools/test-meson-builds: fix bash-isms Bruce Richardson
2019-04-10 20:52 ` Bruce Richardson
2019-04-11 8:48 ` [dpdk-dev] [PATCH 0/3] fix test-meson-builds for older distros Luca Boccassi
2019-04-11 8:48 ` Luca Boccassi
2019-04-17 15:17 ` Thomas Monjalon
2019-04-17 15:17 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5465672.Kypt5CsLy1@xps \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).