From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
To: David Marchand <david.marchand@redhat.com>
Cc: Gaetan Rivet <gaetan.rivet@6wind.com>,
Ferruh Yigit <ferruh.yigit@intel.com>, dev <dev@dpdk.org>,
Chas Williams <3chas3@gmail.com>
Subject: Re: [dpdk-dev] [PATCH] net/failsafe: fix source port ID in Rx packets
Date: Fri, 19 Apr 2019 10:08:03 +0200 [thread overview]
Message-ID: <20190419080803.GJ4889@6wind.com> (raw)
In-Reply-To: <CAJFAV8zLVkmWp6_ENK2kaPHXig0=mtTOGZ2_ER1Kf0ASJAEBAQ@mail.gmail.com>
On Thu, Apr 18, 2019 at 04:06:31PM +0200, David Marchand wrote:
> Hey Adrien,
Hey David!
> On Thu, Apr 18, 2019 at 3:12 PM Adrien Mazarguil <adrien.mazarguil@6wind.com>
> wrote:
>
> > When passed to the application, Rx packets retain the port ID value
> > originally set by slave devices. Unfortunately these IDs have no meaning to
> > applications, which are typically unaware of their existence.
> >
> > This confuses those caring about the source port field in mbufs (m->port)
> > which experience issues ranging from traffic drop to crashes.
> >
> > Fixes: a46f8d584eb8 ("net/failsafe: add fail-safe PMD")
<snip>
> Not a big fan of those duplicated rx_burst functions...
> Reviewed-by: David Marchand <david.marchand@redhat.com>
>
> I suppose the bonding pmd has the same issue.
I don't have much experience with it, however chances are that it's not as
bad as with failsafe since bonding behaves more like a helper that
applications knowingly use to aggregate ports they set up and already know
about. Leaving the original port ID in this case may actually be useful, but
could be optional.
Failsafe on the other hand spawns and manages any number of sub-devices
hidden from the application on its own based on opaque user configuration.
These sub-devices may or may not be present depending on hot-plug events
absorbed by failsafe, which means their port IDs are not only unexpected but
also volatile.
--
Adrien Mazarguil
6WIND
next prev parent reply other threads:[~2019-04-19 8:08 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-18 13:11 Adrien Mazarguil
2019-04-18 13:11 ` Adrien Mazarguil
2019-04-18 14:06 ` David Marchand
2019-04-18 14:06 ` David Marchand
2019-04-19 8:08 ` Adrien Mazarguil [this message]
2019-04-19 8:08 ` Adrien Mazarguil
2019-04-18 14:08 ` Gaëtan Rivet
2019-04-18 14:08 ` Gaëtan Rivet
2019-04-18 14:42 ` Ferruh Yigit
2019-04-18 14:42 ` Ferruh Yigit
2019-04-18 15:08 ` Adrien Mazarguil
2019-04-18 15:08 ` Adrien Mazarguil
2019-04-18 15:32 ` [dpdk-dev] [PATCH v2] " Adrien Mazarguil
2019-04-18 15:32 ` Adrien Mazarguil
2019-04-18 15:39 ` Thomas Monjalon
2019-04-18 15:39 ` Thomas Monjalon
2019-04-18 15:51 ` Thomas Monjalon
2019-04-18 15:51 ` Thomas Monjalon
2019-04-18 16:46 ` Adrien Mazarguil
2019-04-18 16:46 ` Adrien Mazarguil
2019-04-18 16:54 ` Thomas Monjalon
2019-04-18 16:54 ` Thomas Monjalon
2019-04-18 17:09 ` Adrien Mazarguil
2019-04-18 17:09 ` Adrien Mazarguil
2019-04-18 17:43 ` Thomas Monjalon
2019-04-18 17:43 ` Thomas Monjalon
2019-04-18 15:51 ` Gaëtan Rivet
2019-04-18 15:51 ` Gaëtan Rivet
2019-04-18 17:20 ` [dpdk-dev] [PATCH v3] " Adrien Mazarguil
2019-04-18 17:20 ` Adrien Mazarguil
2019-04-18 18:51 ` Ferruh Yigit
2019-04-18 18:51 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190419080803.GJ4889@6wind.com \
--to=adrien.mazarguil@6wind.com \
--cc=3chas3@gmail.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=gaetan.rivet@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).