From: Thomas Monjalon <thomas@monjalon.net>
To: Tomasz Jozwiak <tomaszx.jozwiak@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org, fiona.trahe@intel.com,
yskoh@mellanox.com, bruce.richardson@intel.com
Subject: Re: [dpdk-dev] [PATCH] test/compress: fix max mbuf size test case
Date: Fri, 19 Apr 2019 12:17:26 +0200 [thread overview]
Message-ID: <4602312.zkvPNgCjdN@xps> (raw)
Message-ID: <20190419101726.4N86ZZwgavqqJE24qUvHj-6mnXMJNIv9ltevMvmLLDE@z> (raw)
In-Reply-To: <1555667827-3715-1-git-send-email-tomaszx.jozwiak@intel.com>
Please check my comments below:
19/04/2019 11:57, Tomasz Jozwiak:
> Fixed the compilation error on gcc (GCC)
> 4.8.5 20150623 (Red Hat 4.8.5-28)
It is seen with more compilers:
https://build.opensuse.org/project/show/home:bluca:dpdk
Please add the log of the error.
> Fixes: 355b02eedc65 ("test/compress: add max mbuf size test case")
> Cc: stable@dpdk.org
It is a recent commit, no need to Cc stable for backport.
> Signed-off-by: Tomasz Jozwiak <tomaszx.jozwiak@intel.com>
> ---
> app/test/test_compressdev.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/app/test/test_compressdev.c b/app/test/test_compressdev.c
> index 404b98f..603eeea 100644
> --- a/app/test/test_compressdev.c
> +++ b/app/test/test_compressdev.c
> @@ -1948,6 +1948,7 @@ test_compressdev_deflate_stateless_dynamic_big(void)
> struct comp_testsuite_params *ts_params = &testsuite_params;
> uint16_t i = 0;
> int ret = TEST_SUCCESS;
> + int j = 0;
> const struct rte_compressdev_capabilities *capab;
> char *test_buffer = NULL;
>
> @@ -1989,8 +1990,8 @@ test_compressdev_deflate_stateless_dynamic_big(void)
>
> /* fill the buffer with data based on rand. data */
> srand(BIG_DATA_TEST_SIZE);
> - for (uint32_t i = 0; i < BIG_DATA_TEST_SIZE - 1; ++i)
> - test_buffer[i] = (uint8_t)(rand() % ((uint8_t)-1)) | 1;
> + for (j = 0; j < BIG_DATA_TEST_SIZE - 1; ++j)
> + test_buffer[j] = (uint8_t)(rand() % ((uint8_t)-1)) | 1;
>
> test_buffer[BIG_DATA_TEST_SIZE-1] = 0;
> int_data.buf_idx = &i;
What is supposed to be "i"?
It is initialized at 0 and never touched.
next prev parent reply other threads:[~2019-04-19 10:17 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-19 9:57 Tomasz Jozwiak
2019-04-19 9:57 ` Tomasz Jozwiak
2019-04-19 10:05 ` Bruce Richardson
2019-04-19 10:05 ` Bruce Richardson
2019-04-19 10:17 ` Thomas Monjalon [this message]
2019-04-19 10:17 ` Thomas Monjalon
[not found] ` <CA70B6012E3ADB4184D44E025E5FF01B6A20A888@LCSMSX155.ger.corp.intel.com>
2019-04-19 11:25 ` Thomas Monjalon
2019-04-19 11:25 ` Thomas Monjalon
2019-04-19 11:36 ` Jozwiak, TomaszX
2019-04-19 11:36 ` Jozwiak, TomaszX
2019-04-19 11:50 ` Thomas Monjalon
2019-04-19 11:50 ` Thomas Monjalon
2019-04-19 12:14 ` Jozwiak, TomaszX
2019-04-19 12:14 ` Jozwiak, TomaszX
2019-04-19 17:01 ` Trahe, Fiona
2019-04-19 17:01 ` Trahe, Fiona
2019-04-19 10:49 ` David Marchand
2019-04-19 10:49 ` David Marchand
2019-04-19 11:45 ` [dpdk-dev] [PATCH v2] " Tomasz Jozwiak
2019-04-19 11:45 ` Tomasz Jozwiak
2019-04-19 16:52 ` [dpdk-dev] [PATCH v3] " Fiona Trahe
2019-04-19 16:52 ` Fiona Trahe
2019-04-19 21:06 ` Thomas Monjalon
2019-04-19 21:06 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4602312.zkvPNgCjdN@xps \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=stable@dpdk.org \
--cc=tomaszx.jozwiak@intel.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).