From: "Jozwiak, TomaszX" <tomaszx.jozwiak@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"david.marchand@redhat.com" <david.marchand@redhat.com>,
"Trahe, Fiona" <fiona.trahe@intel.com>,
"yskoh@mellanox.com" <yskoh@mellanox.com>,
"Cel, TomaszX" <tomaszx.cel@intel.com>
Subject: Re: [dpdk-dev] [PATCH] test/compress: fix max mbuf size test case
Date: Fri, 19 Apr 2019 12:14:16 +0000 [thread overview]
Message-ID: <CA70B6012E3ADB4184D44E025E5FF01B6A20B985@LCSMSX155.ger.corp.intel.com> (raw)
Message-ID: <20190419121416.dNEFNV_R_5SYp6160r2WH01k4P1HUXbqX3fLAeuHIKw@z> (raw)
In-Reply-To: <1749599.B640tvC1p7@xps>
> Moreover I don't know how the pointer of a local variable can be used.
That usage is in all test cases in this file - so probably should be fixed first.
May be I'm not an expert but what's wrong with usage of a pointer of local variable inside the function?
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Friday, April 19, 2019 1:50 PM
> To: Jozwiak, TomaszX <tomaszx.jozwiak@intel.com>
> Cc: dev@dpdk.org; Richardson, Bruce <bruce.richardson@intel.com>;
> david.marchand@redhat.com; Trahe, Fiona <fiona.trahe@intel.com>;
> yskoh@mellanox.com; Cel, TomaszX <tomaszx.cel@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] test/compress: fix max mbuf size test case
>
> Please stop top-posting, and read again below:
>
> 19/04/2019 13:36, Jozwiak, TomaszX:
> > test_deflate_comp_decomp function is common for all test cases.
> > The options for this function are inside struct interim_data_params,
> > which is passed to test_deflate_comp_decomp function as a pointer.
> >
> > The field buf_idx should be initialized because is used inside
> > test_deflate_comp_decomp That's the reason of:
> > int_data.buf_idx = &i;
> >
> > I'm not an author of this solution - sorry.
> >
> > We can review this and try to add new solution.
>
> I am not talking about int_data but the use of "i".
> Please look again your patch, you are using "j" instead of "i"
> and "i" is kept alone.
> Moreover I don't know how the pointer of a local variable can be used.
>
>
> > From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > > 19/04/2019 12:57, Jozwiak, TomaszX:
> > > > > What is supposed to be "i"?
> > > > > It is initialized at 0 and never touched.
> > > > >
> > > > It's touched inside test_deflate_comp_decomp function.
> > >
> > > What do you mean?
> > > It's a local variable and its address is referenced:
> > > int_data.buf_idx = &i;
> > > It looks really wrong.
> > >
> > > Another error is seen in FreeBSD.
> > >
> > > Should I totally revert this patch?
>
>
next prev parent reply other threads:[~2019-04-19 12:14 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-19 9:57 Tomasz Jozwiak
2019-04-19 9:57 ` Tomasz Jozwiak
2019-04-19 10:05 ` Bruce Richardson
2019-04-19 10:05 ` Bruce Richardson
2019-04-19 10:17 ` Thomas Monjalon
2019-04-19 10:17 ` Thomas Monjalon
[not found] ` <CA70B6012E3ADB4184D44E025E5FF01B6A20A888@LCSMSX155.ger.corp.intel.com>
2019-04-19 11:25 ` Thomas Monjalon
2019-04-19 11:25 ` Thomas Monjalon
2019-04-19 11:36 ` Jozwiak, TomaszX
2019-04-19 11:36 ` Jozwiak, TomaszX
2019-04-19 11:50 ` Thomas Monjalon
2019-04-19 11:50 ` Thomas Monjalon
2019-04-19 12:14 ` Jozwiak, TomaszX [this message]
2019-04-19 12:14 ` Jozwiak, TomaszX
2019-04-19 17:01 ` Trahe, Fiona
2019-04-19 17:01 ` Trahe, Fiona
2019-04-19 10:49 ` David Marchand
2019-04-19 10:49 ` David Marchand
2019-04-19 11:45 ` [dpdk-dev] [PATCH v2] " Tomasz Jozwiak
2019-04-19 11:45 ` Tomasz Jozwiak
2019-04-19 16:52 ` [dpdk-dev] [PATCH v3] " Fiona Trahe
2019-04-19 16:52 ` Fiona Trahe
2019-04-19 21:06 ` Thomas Monjalon
2019-04-19 21:06 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA70B6012E3ADB4184D44E025E5FF01B6A20B985@LCSMSX155.ger.corp.intel.com \
--to=tomaszx.jozwiak@intel.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=thomas@monjalon.net \
--cc=tomaszx.cel@intel.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).