From: Thomas Monjalon <thomas@monjalon.net>
To: "Rao, Nikhil" <nikhil.rao@intel.com>
Cc: "jerinj@marvell.com" <jerinj@marvell.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Mattias Rönnblom" <mattias.ronnblom@ericsson.com>,
"Van Haaren, Harry" <harry.van.haaren@intel.com>,
"Gujjar, Abhinandan S" <abhinandan.gujjar@intel.com>,
"Carrillo, Erik G" <erik.g.carrillo@intel.com>,
"pbhagavatula@marvell.com" <pbhagavatula@marvell.com>,
"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
"nipun.gupta@nxp.com" <nipun.gupta@nxp.com>,
"Ma, Liang J" <liang.j.ma@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] eventdev: promote adapter functions as stable
Date: Mon, 22 Apr 2019 14:48:42 +0200 [thread overview]
Message-ID: <8482996.cdUznqbjgC@xps> (raw)
Message-ID: <20190422124842.0ccStEVpG-anwy4e3RTRSLtWHFNrYLeh0nVengVAryI@z> (raw)
In-Reply-To: <1F668163772FA946975B9466A9DFF729EDDFE270@ORSMSX122.amr.corp.intel.com>
> > Promote the adapter functions and rte_event_port_unlinks_in_progress()
> > as stable as it's been added for a while now and multiple drivers and test
> > application like test-eventdev has been tested using the adapter APIs.
> >
> > Cc: nikhil.rao@intel.com
> > Cc: erik.g.carrillo@intel.com
> > Cc: abhinandan.gujjar@intel.com
> > Cc: pbhagavatula@marvell.com
> > Cc: hemant.agrawal@nxp.com
> > Cc: nipun.gupta@nxp.com
> > Cc: harry.van.haaren@intel.com
> > Cc: mattias.ronnblom@ericsson.com
> > Cc: liang.j.ma@intel.com
> >
> > Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> > ---
> > /**
> > - * @warning
> > - * @b EXPERIMENTAL: this API may change without prior notice
> > - *
> > * Register callback to process Rx packets, this is supported for
> > * SW based packet transfers.
> > * @see rte_event_eth_rx_cb_fn
> > @@ -501,7 +453,7 @@ int
> > rte_event_eth_rx_adapter_service_id_get(uint8_t id, uint32_t *service_id);
> > * - 0: Success
> > * - <0: Error code on failure.
> > */
> > -int __rte_experimental
> > +int
> > rte_event_eth_rx_adapter_cb_register(uint8_t id,
> > uint16_t eth_dev_id,
> > rte_event_eth_rx_adapter_cb_fn cb_fn,
>
> Sorry for the delay in reply, I would like to retain the rte_event_eth_rx_adapter_cb_register() function as experimental.
> I will be posting a patch for this function to accept events instead of mbufs.
>
> Since Thomas just applied the patch, should I be posting a new patch that reverts the lines above ?
Sorry I hesitated to wait more for your feedback.
Guessing the right time to apply a patch is a difficult heuristic :)
Yes please send a patch to revert for this function.
next prev parent reply other threads:[~2019-04-22 12:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-18 12:05 [dpdk-dev] [PATCH] " jerinj
2019-04-18 12:05 ` jerinj
2019-04-18 21:47 ` Carrillo, Erik G
2019-04-18 21:47 ` Carrillo, Erik G
2019-04-19 10:53 ` Jerin Jacob Kollanukkaran
2019-04-19 10:53 ` Jerin Jacob Kollanukkaran
2019-04-19 12:10 ` [dpdk-dev] [PATCH v2] " jerinj
2019-04-19 12:10 ` jerinj
2019-04-21 12:44 ` Gujjar, Abhinandan S
2019-04-21 12:44 ` Gujjar, Abhinandan S
2019-04-22 11:15 ` Thomas Monjalon
2019-04-22 11:15 ` Thomas Monjalon
2019-04-22 11:32 ` Rao, Nikhil
2019-04-22 11:32 ` Rao, Nikhil
2019-04-22 12:48 ` Thomas Monjalon [this message]
2019-04-22 12:48 ` Thomas Monjalon
2019-04-22 5:39 Hemant Agrawal
2019-04-22 5:39 ` Hemant Agrawal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8482996.cdUznqbjgC@xps \
--to=thomas@monjalon.net \
--cc=abhinandan.gujjar@intel.com \
--cc=dev@dpdk.org \
--cc=erik.g.carrillo@intel.com \
--cc=harry.van.haaren@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=jerinj@marvell.com \
--cc=liang.j.ma@intel.com \
--cc=mattias.ronnblom@ericsson.com \
--cc=nikhil.rao@intel.com \
--cc=nipun.gupta@nxp.com \
--cc=pbhagavatula@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).