From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Herakliusz Lipiec <herakliusz.lipiec@intel.com>
Cc: dev@dpdk.org, jianfeng.tan@intel.com, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 4/8] ipc: fix vfio memleak
Date: Tue, 23 Apr 2019 09:29:08 +0100 [thread overview]
Message-ID: <76414190-bc1a-f375-1f24-084403a52b5c@intel.com> (raw)
Message-ID: <20190423082908.8ljcqB_MOm5LxmoLEa32axEmuFBGb2r5mtEoOy_mVFM@z> (raw)
In-Reply-To: <20190417144100.22548-1-herakliusz.lipiec@intel.com>
On 17-Apr-19 3:41 PM, Herakliusz Lipiec wrote:
> When sending multiple requests, rte_mp_request_sync
> can succeed sending a few of those requests, but then
> fail on a later one and in the end return with rc=-1.
> The upper layers - e.g. device hotplug - currently
> handles this case as if no messages were sent and no
> memory for response buffers was allocated, which is
> not true. Fixed by always freeing reply message buffers.
This commit message is duplicated in multiple commits, and does not
really describe the problem you're fixing. Since you've already updated
the IPC API docs to ask caller to free even in case of failure, i think
here (and in other similar patches) it is sufficient to just say
something like:
When sending synchronous IPC requests, the caller must free the response
buffer even if the request returned failure. Fix the code to correctly
use the IPC API.
>
> Fixes: 83a73c5fef66 ("vfio: use generic multi-process channel")
> Cc: jianfeng.tan@intel.com
> Cc: stable@dpdk.org
> Signed-off-by: Herakliusz Lipiec <herakliusz.lipiec@intel.com>
> ---
For actual code,
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
--
Thanks,
Anatoly
next prev parent reply other threads:[~2019-04-23 8:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-17 14:41 Herakliusz Lipiec
2019-04-17 14:41 ` Herakliusz Lipiec
2019-04-23 8:29 ` Burakov, Anatoly [this message]
2019-04-23 8:29 ` Burakov, Anatoly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76414190-bc1a-f375-1f24-084403a52b5c@intel.com \
--to=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=herakliusz.lipiec@intel.com \
--cc=jianfeng.tan@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).