From: Bruce Richardson <bruce.richardson@intel.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Doherty, Declan" <declan.doherty@intel.com>
Subject: Re: [dpdk-dev] [PATCH 1/2] crypto/aesni_gcm: add dependency version check
Date: Tue, 23 Apr 2019 15:45:25 +0100 [thread overview]
Message-ID: <20190423144525.GA1859@bricha3-MOBL.ger.corp.intel.com> (raw)
Message-ID: <20190423144525.qUkQ8OQEQJSmS3KYXtFhAi9Nx7i7AxLeTB1eGC9xrYM@z> (raw)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D897803BB3E3@irsmsx112.ger.corp.intel.com>
On Tue, Apr 23, 2019 at 03:38:58PM +0100, De Lara Guarch, Pablo wrote:
>
>
> > -----Original Message-----
> > From: Richardson, Bruce
> > Sent: Friday, April 19, 2019 11:01 AM
> > To: dev@dpdk.org
> > Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Doherty,
> > Declan <declan.doherty@intel.com>; Richardson, Bruce
> > <bruce.richardson@intel.com>
> > Subject: [PATCH 1/2] crypto/aesni_gcm: add dependency version check
> >
> > The aesni_mb driver and the aesni_gcm driver both require the same version
> > of the IPSec_MB library, but only the former has a check of the library found
> > to see if it's the correct version. Add a similar check to the aesni_gcm
> > library's meson.build file, so that the auto-detection of dependencies works
> > correctly.
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > ---
> > drivers/crypto/aesni_gcm/meson.build | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
> >
> > diff --git a/drivers/crypto/aesni_gcm/meson.build
> > b/drivers/crypto/aesni_gcm/meson.build
> > index 70f57ad73..7183cfcba 100644
> > --- a/drivers/crypto/aesni_gcm/meson.build
> > +++ b/drivers/crypto/aesni_gcm/meson.build
>
> The patch looks good, but we should broaden its scope and also modify the Makefile,
> to check for the library version, like in the aesni_mb PMD.
>
> Could you add that check too?
>
I thought about doing so, but decided not to do so because the driver isn't
enabled by default. Therefore the default out-of-the-box build is not
broken when using an old version, as it is with meson. That being said,
I'll look to see if the aesni_mb checks can be easiest ported over for a
V2.
Regards,
/Bruce
next prev parent reply other threads:[~2019-04-23 14:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-19 10:01 Bruce Richardson
2019-04-19 10:01 ` Bruce Richardson
2019-04-19 10:01 ` [dpdk-dev] [PATCH 2/2] crypto/aesni_mb: cleanup of version check code Bruce Richardson
2019-04-19 10:01 ` Bruce Richardson
2019-04-23 14:40 ` De Lara Guarch, Pablo
2019-04-23 14:40 ` De Lara Guarch, Pablo
2019-04-23 14:38 ` [dpdk-dev] [PATCH 1/2] crypto/aesni_gcm: add dependency version check De Lara Guarch, Pablo
2019-04-23 14:38 ` De Lara Guarch, Pablo
2019-04-23 14:45 ` Bruce Richardson [this message]
2019-04-23 14:45 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190423144525.GA1859@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).