From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>,
Wenzhuo Lu <wenzhuo.lu@intel.com>,
Jingjing Wu <jingjing.wu@intel.com>,
Bernard Iremonger <bernard.iremonger@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org, "Li, WenjieX A" <wenjiex.a.li@intel.com>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: set fixed flag when exact link speed is chosen
Date: Tue, 23 Apr 2019 16:04:03 +0100 [thread overview]
Message-ID: <0362242f-a51a-b37b-a2e7-61f1c8bbea35@intel.com> (raw)
Message-ID: <20190423150403.wPkqvZd6oIwTlzPbY4hr9DzsvNNO8XYeCYqyOXNp2DM@z> (raw)
In-Reply-To: <04bcdfba-420b-9d5e-6e10-9d8b6762c378@intel.com>
On 4/23/2019 4:02 PM, Ferruh Yigit wrote:
> On 4/12/2019 2:12 PM, Andrew Rybchenko wrote:
>> Setting exact link speed makes sense if auto-negotiation is
>> disabled. Fixed flag is required to disable auto-negotiation.
>
> Hi Andrew,
>
> Fixed link speed is not supported by all PMDs and this change is breaking them
> to set the speed in testpmd.
>
> As long as device speed set correct, I believe the command doesn't really care
> about if link mode is auto-negotiation or not.
>
> I am for reverting this commit, is there any objection to revert it?
cc'ing Wenjie who reported the issue.
>
>>
>> Fixes: 88fbedcd5e5a ("app/testpmd: move speed and duplex parsing in a function")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
>> ---
>> app/test-pmd/cmdline.c | 12 ++++++------
>> 1 file changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
>> index 2ab03c111..691d818a6 100644
>> --- a/app/test-pmd/cmdline.c
>> +++ b/app/test-pmd/cmdline.c
>> @@ -1440,17 +1440,17 @@ parse_and_check_speed_duplex(char *speedstr, char *duplexstr, uint32_t *speed)
>> return -1;
>> }
>> if (!strcmp(speedstr, "1000")) {
>> - *speed = ETH_LINK_SPEED_1G;
>> + *speed = ETH_LINK_SPEED_1G | ETH_LINK_SPEED_FIXED;
>> } else if (!strcmp(speedstr, "10000")) {
>> - *speed = ETH_LINK_SPEED_10G;
>> + *speed = ETH_LINK_SPEED_10G | ETH_LINK_SPEED_FIXED;
>> } else if (!strcmp(speedstr, "25000")) {
>> - *speed = ETH_LINK_SPEED_25G;
>> + *speed = ETH_LINK_SPEED_25G | ETH_LINK_SPEED_FIXED;
>> } else if (!strcmp(speedstr, "40000")) {
>> - *speed = ETH_LINK_SPEED_40G;
>> + *speed = ETH_LINK_SPEED_40G | ETH_LINK_SPEED_FIXED;
>> } else if (!strcmp(speedstr, "50000")) {
>> - *speed = ETH_LINK_SPEED_50G;
>> + *speed = ETH_LINK_SPEED_50G | ETH_LINK_SPEED_FIXED;
>> } else if (!strcmp(speedstr, "100000")) {
>> - *speed = ETH_LINK_SPEED_100G;
>> + *speed = ETH_LINK_SPEED_100G | ETH_LINK_SPEED_FIXED;
>> } else if (!strcmp(speedstr, "auto")) {
>> *speed = ETH_LINK_SPEED_AUTONEG;
>> } else {
>>
>
next prev parent reply other threads:[~2019-04-23 15:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-12 13:12 Andrew Rybchenko
2019-04-12 13:12 ` Andrew Rybchenko
2019-04-12 14:40 ` Iremonger, Bernard
2019-04-12 14:40 ` Iremonger, Bernard
2019-04-16 14:04 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2019-04-16 14:04 ` Ferruh Yigit
2019-04-23 15:02 ` [dpdk-dev] " Ferruh Yigit
2019-04-23 15:02 ` Ferruh Yigit
2019-04-23 15:04 ` Ferruh Yigit [this message]
2019-04-23 15:04 ` Ferruh Yigit
2019-04-23 15:44 ` Andrew Rybchenko
2019-04-23 15:44 ` Andrew Rybchenko
2019-04-23 15:53 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2019-04-23 15:53 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0362242f-a51a-b37b-a2e7-61f1c8bbea35@intel.com \
--to=ferruh.yigit@intel.com \
--cc=arybchenko@solarflare.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=stable@dpdk.org \
--cc=wenjiex.a.li@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).