From: Herakliusz Lipiec <herakliusz.lipiec@intel.com>
To: Matan Azrad <matan@mellanox.com>, Shahaf Shuler <shahafs@mellanox.com>
Cc: dev@dpdk.org, Herakliusz Lipiec <herakliusz.lipiec@intel.com>,
yskoh@mellanox.com
Subject: [dpdk-dev] [PATCH v2 7/8] ipc: fix net/mlx4 memleak
Date: Tue, 23 Apr 2019 18:43:33 +0100 [thread overview]
Message-ID: <20190423174334.19612-8-herakliusz.lipiec@intel.com> (raw)
In-Reply-To: <20190423174334.19612-1-herakliusz.lipiec@intel.com>
When sending synchronous IPC requests, the caller must free the response
buffer even if the request returned failure. Fix the code to correctly
use the IPC API.
Bugzilla ID:228
Fixes: 0b259b8e9655 ("net/mlx4: enable secondary process to register DMA memory")
Cc: yskoh@mellanox.com
Signed-off-by: Herakliusz Lipiec <herakliusz.lipiec@intel.com>
---
drivers/net/mlx4/mlx4_mp.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/mlx4/mlx4_mp.c b/drivers/net/mlx4/mlx4_mp.c
index 183622453..f4cff7486 100644
--- a/drivers/net/mlx4/mlx4_mp.c
+++ b/drivers/net/mlx4/mlx4_mp.c
@@ -255,6 +255,7 @@ mlx4_mp_req_mr_create(struct rte_eth_dev *dev, uintptr_t addr)
if (ret) {
ERROR("port %u request to primary process failed",
dev->data->port_id);
+ free(mp_rep.msgs);
return -rte_errno;
}
assert(mp_rep.nb_received == 1);
@@ -292,7 +293,8 @@ mlx4_mp_req_verbs_cmd_fd(struct rte_eth_dev *dev)
if (ret) {
ERROR("port %u request to primary process failed",
dev->data->port_id);
- return -rte_errno;
+ ret = -rte_errno;
+ goto exit;
}
assert(mp_rep.nb_received == 1);
mp_res = &mp_rep.msgs[0];
--
2.17.2
next prev parent reply other threads:[~2019-04-23 17:43 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-17 14:38 [dpdk-dev] [PATCH 1/8] ipc: fix rte_mp_request_sync memleak Herakliusz Lipiec
2019-04-17 14:38 ` Herakliusz Lipiec
2019-04-23 8:11 ` Burakov, Anatoly
2019-04-23 8:11 ` Burakov, Anatoly
2019-04-23 8:13 ` Burakov, Anatoly
2019-04-23 8:13 ` Burakov, Anatoly
2019-04-23 17:43 ` [dpdk-dev] [PATCH v2 0/8] ipc: fix possible memleaks Herakliusz Lipiec
2019-04-23 17:43 ` Herakliusz Lipiec
2019-04-23 17:43 ` [dpdk-dev] [PATCH v2 1/8] ipc: fix rte_mp_request_sync memleak Herakliusz Lipiec
2019-04-23 17:43 ` Herakliusz Lipiec
2019-04-24 9:28 ` Stojaczyk, Dariusz
2019-04-24 9:28 ` Stojaczyk, Dariusz
2019-04-25 9:37 ` Burakov, Anatoly
2019-04-25 9:37 ` Burakov, Anatoly
2019-04-23 17:43 ` [dpdk-dev] [PATCH v2 2/8] ipc: fix hotplug memleak Herakliusz Lipiec
2019-04-23 17:43 ` Herakliusz Lipiec
2019-04-25 6:00 ` Stojaczyk, Dariusz
2019-04-25 6:00 ` Stojaczyk, Dariusz
2019-04-23 17:43 ` [dpdk-dev] [PATCH v2 3/8] ipc: fix vdev memleak Herakliusz Lipiec
2019-04-23 17:43 ` Herakliusz Lipiec
2019-04-25 6:08 ` Stojaczyk, Dariusz
2019-04-25 6:08 ` Stojaczyk, Dariusz
2019-04-23 17:43 ` [dpdk-dev] [PATCH v2 4/8] ipc: fix vfio memleak Herakliusz Lipiec
2019-04-23 17:43 ` Herakliusz Lipiec
2019-04-25 6:06 ` Stojaczyk, Dariusz
2019-04-25 6:06 ` Stojaczyk, Dariusz
2019-04-23 17:43 ` [dpdk-dev] [PATCH v2 5/8] ipc: fix pdump memleak Herakliusz Lipiec
2019-04-23 17:43 ` Herakliusz Lipiec
2019-04-23 17:43 ` [dpdk-dev] [PATCH v2 6/8] ipc: fix tap pmd memleak Herakliusz Lipiec
2019-04-23 17:43 ` Herakliusz Lipiec
2019-04-23 17:43 ` Herakliusz Lipiec [this message]
2019-04-23 17:43 ` [dpdk-dev] [PATCH v2 7/8] ipc: fix net/mlx4 memleak Herakliusz Lipiec
2019-04-23 20:16 ` Yongseok Koh
2019-04-23 20:16 ` Yongseok Koh
2019-04-23 17:43 ` [dpdk-dev] [PATCH v2 8/8] ipc: fix net/mlx5 memleak Herakliusz Lipiec
2019-04-23 17:43 ` Herakliusz Lipiec
2019-04-23 20:16 ` Yongseok Koh
2019-04-23 20:16 ` Yongseok Koh
2019-04-25 11:43 ` [dpdk-dev] [PATCH v3 0/2] ipc: fix possible memleaks Herakliusz Lipiec
2019-04-25 11:43 ` Herakliusz Lipiec
2019-04-25 11:43 ` [dpdk-dev] [PATCH v3 1/2] ipc: fix rte_mp_request_sync memleak Herakliusz Lipiec
2019-04-25 11:43 ` Herakliusz Lipiec
2019-04-25 12:47 ` Burakov, Anatoly
2019-04-25 12:47 ` Burakov, Anatoly
2019-04-25 11:43 ` [dpdk-dev] [PATCH v3 2/2] ipc: fix tap pmd memleak Herakliusz Lipiec
2019-04-25 11:43 ` Herakliusz Lipiec
2019-04-25 12:48 ` [dpdk-dev] [PATCH v4 0/2] ipc: fix possible memleaks Herakliusz Lipiec
2019-04-25 12:48 ` Herakliusz Lipiec
2019-04-25 12:48 ` [dpdk-dev] [PATCH v4 1/2] ipc: fix rte_mp_request_sync memleak Herakliusz Lipiec
2019-04-25 12:48 ` Herakliusz Lipiec
2019-04-25 12:48 ` Burakov, Anatoly
2019-04-25 12:48 ` Burakov, Anatoly
2019-04-25 12:48 ` [dpdk-dev] [PATCH v4 2/2] ipc: fix tap pmd memleak Herakliusz Lipiec
2019-04-25 12:48 ` Herakliusz Lipiec
2019-04-25 18:14 ` Wiles, Keith
2019-04-25 18:14 ` Wiles, Keith
2019-05-03 8:34 ` [dpdk-dev] [PATCH v4 0/2] ipc: fix possible memleaks Thomas Monjalon
2019-05-03 8:34 ` Thomas Monjalon
2019-05-03 8:38 ` Burakov, Anatoly
2019-05-03 8:38 ` Burakov, Anatoly
2019-05-03 10:28 ` [dpdk-dev] [PATCH v5 0/2] ipc: fix possible memory leaks Herakliusz Lipiec
2019-05-03 10:28 ` Herakliusz Lipiec
2019-05-03 10:28 ` [dpdk-dev] [PATCH v5 1/2] ipc: fix memory leak in sync request Herakliusz Lipiec
2019-05-03 10:28 ` Herakliusz Lipiec
2019-05-03 10:28 ` [dpdk-dev] [PATCH v5 2/2] net/tap: fix ipc related memory leak Herakliusz Lipiec
2019-05-03 10:28 ` Herakliusz Lipiec
2019-05-03 10:54 ` [dpdk-dev] [PATCH v5 0/2] ipc: fix possible memory leaks Thomas Monjalon
2019-05-03 10:54 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190423174334.19612-8-herakliusz.lipiec@intel.com \
--to=herakliusz.lipiec@intel.com \
--cc=dev@dpdk.org \
--cc=matan@mellanox.com \
--cc=shahafs@mellanox.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).