DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Wiles, Keith" <keith.wiles@intel.com>
To: "Lipiec, Herakliusz" <herakliusz.lipiec@intel.com>
Cc: dpdk-dev <dev@dpdk.org>,
	"Burakov, Anatoly" <anatoly.burakov@intel.com>,
	"rasland@mellanox.com" <rasland@mellanox.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v4 2/2] ipc: fix tap pmd memleak
Date: Thu, 25 Apr 2019 18:14:16 +0000	[thread overview]
Message-ID: <397C206A-DBA4-468C-8570-2E9E0C1C948A@intel.com> (raw)
Message-ID: <20190425181416.5DCy65ad6I_u2FQFbSlaSSdTrIOJtl7TnDhDUtl_Xow@z> (raw)
In-Reply-To: <20190425124817.28409-3-herakliusz.lipiec@intel.com>



> On Apr 25, 2019, at 7:48 AM, Lipiec, Herakliusz <herakliusz.lipiec@intel.com> wrote:
> 
> When sending synchronous IPC requests, the caller must free the response
> buffer if the request was successful and reply is no longer needed.
> Fix the code to correctly
> use the IPC API.
> 
> Bugzilla ID: 228
> Fixes: c9aa56edec8e ("net/tap: access primary process queues from secondary")
> Cc: rasland@mellanox.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Herakliusz Lipiec <herakliusz.lipiec@intel.com>
> ---
> drivers/net/tap/rte_eth_tap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
> index 7f74b5dc9..f8a4169c5 100644
> --- a/drivers/net/tap/rte_eth_tap.c
> +++ b/drivers/net/tap/rte_eth_tap.c
> @@ -2118,7 +2118,7 @@ tap_mp_attach_queues(const char *port_name, struct rte_eth_dev *dev)
> 		process_private->rxq_fds[queue] = reply->fds[fd_iterator++];
> 	for (queue = 0; queue < reply_param->txq_count; queue++)
> 		process_private->txq_fds[queue] = reply->fds[fd_iterator++];
> -
> +	free(reply);
> 	return 0;
> }

Acked-by: Keith Wiles <keith.wiles@intel.com>
> 
> -- 
> 2.17.2
> 

Regards,
Keith


  parent reply	other threads:[~2019-04-25 18:14 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-17 14:38 [dpdk-dev] [PATCH 1/8] ipc: fix rte_mp_request_sync memleak Herakliusz Lipiec
2019-04-17 14:38 ` Herakliusz Lipiec
2019-04-23  8:11 ` Burakov, Anatoly
2019-04-23  8:11   ` Burakov, Anatoly
2019-04-23  8:13 ` Burakov, Anatoly
2019-04-23  8:13   ` Burakov, Anatoly
2019-04-23 17:43 ` [dpdk-dev] [PATCH v2 0/8] ipc: fix possible memleaks Herakliusz Lipiec
2019-04-23 17:43   ` Herakliusz Lipiec
2019-04-23 17:43   ` [dpdk-dev] [PATCH v2 1/8] ipc: fix rte_mp_request_sync memleak Herakliusz Lipiec
2019-04-23 17:43     ` Herakliusz Lipiec
2019-04-24  9:28     ` Stojaczyk, Dariusz
2019-04-24  9:28       ` Stojaczyk, Dariusz
2019-04-25  9:37     ` Burakov, Anatoly
2019-04-25  9:37       ` Burakov, Anatoly
2019-04-23 17:43   ` [dpdk-dev] [PATCH v2 2/8] ipc: fix hotplug memleak Herakliusz Lipiec
2019-04-23 17:43     ` Herakliusz Lipiec
2019-04-25  6:00     ` Stojaczyk, Dariusz
2019-04-25  6:00       ` Stojaczyk, Dariusz
2019-04-23 17:43   ` [dpdk-dev] [PATCH v2 3/8] ipc: fix vdev memleak Herakliusz Lipiec
2019-04-23 17:43     ` Herakliusz Lipiec
2019-04-25  6:08     ` Stojaczyk, Dariusz
2019-04-25  6:08       ` Stojaczyk, Dariusz
2019-04-23 17:43   ` [dpdk-dev] [PATCH v2 4/8] ipc: fix vfio memleak Herakliusz Lipiec
2019-04-23 17:43     ` Herakliusz Lipiec
2019-04-25  6:06     ` Stojaczyk, Dariusz
2019-04-25  6:06       ` Stojaczyk, Dariusz
2019-04-23 17:43   ` [dpdk-dev] [PATCH v2 5/8] ipc: fix pdump memleak Herakliusz Lipiec
2019-04-23 17:43     ` Herakliusz Lipiec
2019-04-23 17:43   ` [dpdk-dev] [PATCH v2 6/8] ipc: fix tap pmd memleak Herakliusz Lipiec
2019-04-23 17:43     ` Herakliusz Lipiec
2019-04-23 17:43   ` [dpdk-dev] [PATCH v2 7/8] ipc: fix net/mlx4 memleak Herakliusz Lipiec
2019-04-23 17:43     ` Herakliusz Lipiec
2019-04-23 20:16     ` Yongseok Koh
2019-04-23 20:16       ` Yongseok Koh
2019-04-23 17:43   ` [dpdk-dev] [PATCH v2 8/8] ipc: fix net/mlx5 memleak Herakliusz Lipiec
2019-04-23 17:43     ` Herakliusz Lipiec
2019-04-23 20:16     ` Yongseok Koh
2019-04-23 20:16       ` Yongseok Koh
2019-04-25 11:43   ` [dpdk-dev] [PATCH v3 0/2] ipc: fix possible memleaks Herakliusz Lipiec
2019-04-25 11:43     ` Herakliusz Lipiec
2019-04-25 11:43     ` [dpdk-dev] [PATCH v3 1/2] ipc: fix rte_mp_request_sync memleak Herakliusz Lipiec
2019-04-25 11:43       ` Herakliusz Lipiec
2019-04-25 12:47       ` Burakov, Anatoly
2019-04-25 12:47         ` Burakov, Anatoly
2019-04-25 11:43     ` [dpdk-dev] [PATCH v3 2/2] ipc: fix tap pmd memleak Herakliusz Lipiec
2019-04-25 11:43       ` Herakliusz Lipiec
2019-04-25 12:48     ` [dpdk-dev] [PATCH v4 0/2] ipc: fix possible memleaks Herakliusz Lipiec
2019-04-25 12:48       ` Herakliusz Lipiec
2019-04-25 12:48       ` [dpdk-dev] [PATCH v4 1/2] ipc: fix rte_mp_request_sync memleak Herakliusz Lipiec
2019-04-25 12:48         ` Herakliusz Lipiec
2019-04-25 12:48         ` Burakov, Anatoly
2019-04-25 12:48           ` Burakov, Anatoly
2019-04-25 12:48       ` [dpdk-dev] [PATCH v4 2/2] ipc: fix tap pmd memleak Herakliusz Lipiec
2019-04-25 12:48         ` Herakliusz Lipiec
2019-04-25 18:14         ` Wiles, Keith [this message]
2019-04-25 18:14           ` Wiles, Keith
2019-05-03  8:34       ` [dpdk-dev] [PATCH v4 0/2] ipc: fix possible memleaks Thomas Monjalon
2019-05-03  8:34         ` Thomas Monjalon
2019-05-03  8:38         ` Burakov, Anatoly
2019-05-03  8:38           ` Burakov, Anatoly
2019-05-03 10:28       ` [dpdk-dev] [PATCH v5 0/2] ipc: fix possible memory leaks Herakliusz Lipiec
2019-05-03 10:28         ` Herakliusz Lipiec
2019-05-03 10:28         ` [dpdk-dev] [PATCH v5 1/2] ipc: fix memory leak in sync request Herakliusz Lipiec
2019-05-03 10:28           ` Herakliusz Lipiec
2019-05-03 10:28         ` [dpdk-dev] [PATCH v5 2/2] net/tap: fix ipc related memory leak Herakliusz Lipiec
2019-05-03 10:28           ` Herakliusz Lipiec
2019-05-03 10:54         ` [dpdk-dev] [PATCH v5 0/2] ipc: fix possible memory leaks Thomas Monjalon
2019-05-03 10:54           ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=397C206A-DBA4-468C-8570-2E9E0C1C948A@intel.com \
    --to=keith.wiles@intel.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=herakliusz.lipiec@intel.com \
    --cc=rasland@mellanox.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).