From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: thomas@monjalon.net, bluca@debian.org,
Bruce Richardson <bruce.richardson@intel.com>
Subject: [dpdk-dev] [PATCH v2 6/6] examples: remove auto-generation of examples list
Date: Fri, 26 Apr 2019 17:50:43 +0100 [thread overview]
Message-ID: <20190426165043.17268-7-bruce.richardson@intel.com> (raw)
In-Reply-To: <20190426165043.17268-1-bruce.richardson@intel.com>
The examples/meson.build file scanned the filesystem to find all examples
to build (for examples=all option) and install. However, using run_command
and scanning the filesystem prevented ninja from properly detecting the
addition or removal of any examples - one had to recreate the build
directory from scratch to guarantee correct detection of all examples. This
patch replaces this generated list with a static list of examples, thereby
allowing proper tracking by ninja/meson, but at the cost of having to
update this file when a new example is added or removed.
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
examples/meson.build | 31 ++++++++++++++++++++++++++++---
1 file changed, 28 insertions(+), 3 deletions(-)
diff --git a/examples/meson.build b/examples/meson.build
index 1a6134f12..8b6577cf7 100644
--- a/examples/meson.build
+++ b/examples/meson.build
@@ -8,9 +8,34 @@ endif
execinfo = cc.find_library('execinfo', required: false)
-all_examples = run_command('sh', '-c',
- 'cd $MESON_SOURCE_ROOT/$MESON_SUBDIR && for d in * ; do if [ -d $d ] ; then echo $d ; fi ; done'
- ).stdout().split()
+# list of all example apps. Keep 1-3 per line, in alphabetical order.
+all_examples = [
+ 'bbdev_app', 'bond',
+ 'bpf', 'cmdline',
+ 'distributor', 'ethtool',
+ 'eventdev_pipeline', 'exception_path',
+ 'fips_validation', 'flow_classify',
+ 'flow_filtering', 'helloworld',
+ 'ip_fragmentation', 'ip_pipeline',
+ 'ip_reassembly', 'ipsec-secgw',
+ 'ipv4_multicast', 'kni',
+ 'l2fwd', 'l2fwd-cat',
+ 'l2fwd-crypto', 'l2fwd-jobstats',
+ 'l2fwd-keepalive', 'l3fwd',
+ 'l3fwd-acl', 'l3fwd-power',
+ 'l3fwd-vf', 'link_status_interrupt',
+ 'load_balancer', 'multi_process',
+ 'netmap_compat', 'packet_ordering',
+ 'performance-thread', 'ptpclient',
+ 'qos_meter', 'qos_sched',
+ 'quota_watermark', 'rxtx_callbacks',
+ 'server_node_efd', 'service_cores',
+ 'skeleton', 'tep_termination',
+ 'timer', 'vdpa',
+ 'vhost', 'vhost_crypto',
+ 'vhost_scsi', 'vm_power_manager',
+ 'vmdq', 'vmdq_dcb',
+]
# install all example code on install - irrespective of whether the example in
# question is to be built as part of this build or not.
foreach ex:all_examples
--
2.21.0
next prev parent reply other threads:[~2019-04-26 16:51 UTC|newest]
Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-23 22:06 [dpdk-dev] [PATCH 0/4] add testing of libdpdk pkg-config file Bruce Richardson
2019-04-23 22:06 ` Bruce Richardson
2019-04-23 22:06 ` [dpdk-dev] [PATCH 1/4] examples: install examples as part of ninja install Bruce Richardson
2019-04-23 22:06 ` Bruce Richardson
2019-04-23 22:06 ` [dpdk-dev] [PATCH 2/4] examples: simplify getting list of all examples Bruce Richardson
2019-04-23 22:06 ` Bruce Richardson
2019-04-23 22:06 ` [dpdk-dev] [PATCH 3/4] devtools/test-meson-builds: add testing of pkg-config file Bruce Richardson
2019-04-23 22:06 ` Bruce Richardson
2019-04-24 9:22 ` Luca Boccassi
2019-04-24 9:22 ` Luca Boccassi
2019-04-24 10:41 ` Bruce Richardson
2019-04-24 10:41 ` Bruce Richardson
2019-04-24 11:02 ` Luca Boccassi
2019-04-24 11:02 ` Luca Boccassi
2019-04-24 12:31 ` Bruce Richardson
2019-04-24 12:31 ` Bruce Richardson
2019-04-24 13:37 ` Luca Boccassi
2019-04-24 13:37 ` Luca Boccassi
2019-04-26 14:56 ` Bruce Richardson
2019-04-26 14:56 ` Bruce Richardson
2019-04-26 16:10 ` Luca Boccassi
2019-04-26 16:10 ` Luca Boccassi
2019-05-02 13:11 ` Thomas Monjalon
2019-05-02 13:11 ` Thomas Monjalon
2019-05-02 13:17 ` Bruce Richardson
2019-05-02 13:17 ` Bruce Richardson
2019-05-02 14:08 ` Luca Boccassi
2019-05-02 14:08 ` Luca Boccassi
2019-05-02 15:11 ` Thomas Monjalon
2019-05-02 15:11 ` Thomas Monjalon
2019-05-02 15:30 ` Bruce Richardson
2019-05-02 15:30 ` Bruce Richardson
2019-05-02 15:38 ` Thomas Monjalon
2019-05-02 15:38 ` Thomas Monjalon
2019-05-02 15:41 ` Bruce Richardson
2019-05-02 15:41 ` Bruce Richardson
2019-04-23 22:06 ` [dpdk-dev] [PATCH 4/4] build: add libbsd to pkg-config file if enabled Bruce Richardson
2019-04-23 22:06 ` Bruce Richardson
2019-04-23 23:04 ` [dpdk-dev] [PATCH 0/4] add testing of libdpdk pkg-config file Stephen Hemminger
2019-04-23 23:04 ` Stephen Hemminger
2019-04-24 8:54 ` Bruce Richardson
2019-04-24 8:54 ` Bruce Richardson
2019-04-24 9:00 ` Bruce Richardson
2019-04-24 9:00 ` Bruce Richardson
2019-04-26 16:11 ` Luca Boccassi
2019-04-26 16:11 ` Luca Boccassi
2019-04-26 16:20 ` Bruce Richardson
2019-04-26 16:20 ` Bruce Richardson
2019-04-26 16:50 ` [dpdk-dev] [PATCH v2 0/6] " Bruce Richardson
2019-04-26 16:50 ` Bruce Richardson
2019-04-26 16:50 ` [dpdk-dev] [PATCH v2 1/6] examples/l3fwd: fix compile on FreeBSD Bruce Richardson
2019-04-26 16:50 ` Bruce Richardson
2019-05-01 10:10 ` Luca Boccassi
2019-05-01 10:10 ` Luca Boccassi
2019-04-26 16:50 ` [dpdk-dev] [PATCH v2 2/6] examples: install examples as part of ninja install Bruce Richardson
2019-04-26 16:50 ` Bruce Richardson
2019-04-26 16:50 ` [dpdk-dev] [PATCH v2 3/6] build: fix ninja install on FreeBSD Bruce Richardson
2019-04-26 16:50 ` Bruce Richardson
2019-05-01 10:10 ` Luca Boccassi
2019-05-01 10:10 ` Luca Boccassi
2019-04-26 16:50 ` [dpdk-dev] [PATCH v2 4/6] devtools/test-meson-builds: add testing of pkg-config file Bruce Richardson
2019-04-26 16:50 ` Bruce Richardson
2019-05-02 12:38 ` Thomas Monjalon
2019-05-02 12:38 ` Thomas Monjalon
2019-05-02 12:54 ` Luca Boccassi
2019-05-02 12:54 ` Luca Boccassi
2019-05-02 13:21 ` Bruce Richardson
2019-05-02 13:21 ` Bruce Richardson
2019-05-02 13:57 ` Thomas Monjalon
2019-05-02 13:57 ` Thomas Monjalon
2019-04-26 16:50 ` [dpdk-dev] [PATCH v2 5/6] build: add libbsd to pkg-config file if enabled Bruce Richardson
2019-04-26 16:50 ` Bruce Richardson
2019-04-26 16:50 ` Bruce Richardson [this message]
2019-04-26 16:50 ` [dpdk-dev] [PATCH v2 6/6] examples: remove auto-generation of examples list Bruce Richardson
2019-05-01 10:10 ` Luca Boccassi
2019-05-01 10:10 ` Luca Boccassi
2019-05-02 16:51 ` [dpdk-dev] [PATCH v4 0/4] file meson compilation and install issues Bruce Richardson
2019-05-02 16:51 ` Bruce Richardson
2019-05-02 16:51 ` [dpdk-dev] [PATCH v4 1/4] examples/l3fwd: fix compile on FreeBSD Bruce Richardson
2019-05-02 16:51 ` Bruce Richardson
2019-05-02 16:51 ` [dpdk-dev] [PATCH v4 2/4] examples: install examples as part of ninja install Bruce Richardson
2019-05-02 16:51 ` Bruce Richardson
2019-05-02 16:51 ` [dpdk-dev] [PATCH v4 3/4] build: fix ninja install on FreeBSD Bruce Richardson
2019-05-02 16:51 ` Bruce Richardson
2019-05-02 16:51 ` [dpdk-dev] [PATCH v4 4/4] build: add libbsd to pkg-config file if enabled Bruce Richardson
2019-05-02 16:51 ` Bruce Richardson
2019-05-02 21:09 ` [dpdk-dev] [PATCH v4 0/4] file meson compilation and install issues Thomas Monjalon
2019-05-02 21:09 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190426165043.17268-7-bruce.richardson@intel.com \
--to=bruce.richardson@intel.com \
--cc=bluca@debian.org \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).