DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Xiao, QimaiX" <qimaix.xiao@intel.com>
To: "Zhao1, Wei" <wei.zhao1@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
	"Zhang, Qi Z" <qi.z.zhang@intel.com>,
	 "Peng, Yuan" <yuan.peng@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/i40e: remove useless check for queue number
Date: Sun, 28 Apr 2019 06:51:29 +0000	[thread overview]
Message-ID: <5C5FA1EBCC0D164EAD0302E258A5234B6EFB9D@SHSMSX103.ccr.corp.intel.com> (raw)
Message-ID: <20190428065129.XKv2MC-8xkTuSRfDWoKSBBz4Do0tfOI5qHXdJbY-LfE@z> (raw)
In-Reply-To: <1556431998-65281-1-git-send-email-wei.zhao1@intel.com>

Tested-by: Xiao, QimaiX <qimaix.xiao@intel.com>

-----Original Message-----
From: Zhao1, Wei 
Sent: Sunday, April 28, 2019 2:13 PM
To: dev@dpdk.org
Cc: stable@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Xiao, QimaiX <qimaix.xiao@intel.com>; Peng, Yuan <yuan.peng@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>
Subject: [PATCH] net/i40e: remove useless check for queue number

There is no need to do such a check of queue number, so remove it.

Fixes: ac8d22de2394 ("ethdev: flatten RSS configuration in flow API")

Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
 drivers/net/i40e/i40e_ethdev.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index dca61f0..5059bad 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -12699,9 +12699,6 @@ i40e_config_rss_filter(struct i40e_pf *pf,
 		return -EINVAL;
 	}
 
-	if (rss_info->conf.queue_num)
-		return -EINVAL;
-
 	/* If both VMDQ and RSS enabled, not all of PF queues are configured.
 	 * It's necessary to calculate the actual PF queues that are configured.
 	 */
--
2.7.5


  parent reply	other threads:[~2019-04-28 14:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-28  6:13 Wei Zhao
2019-04-28  6:13 ` Wei Zhao
2019-04-28  6:51 ` Xiao, QimaiX [this message]
2019-04-28  6:51   ` Xiao, QimaiX
2019-04-29 11:57   ` Zhang, Qi Z
2019-04-29 11:57     ` Zhang, Qi Z

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5C5FA1EBCC0D164EAD0302E258A5234B6EFB9D@SHSMSX103.ccr.corp.intel.com \
    --to=qimaix.xiao@intel.com \
    --cc=dev@dpdk.org \
    --cc=qi.z.zhang@intel.com \
    --cc=stable@dpdk.org \
    --cc=wei.zhao1@intel.com \
    --cc=yuan.peng@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).