DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>
Subject: [dpdk-dev] [PATCH 19.08 3/3] kernel/linux: remove unneeded local variables
Date: Tue, 30 Apr 2019 15:03:25 +0100	[thread overview]
Message-ID: <20190430140325.45537-4-bruce.richardson@intel.com> (raw)
Message-ID: <20190430140325.IkK80iJ4lKfkm7yJDA4Y16dkXRAL_bCIrduOMAHVIu8@z> (raw)
In-Reply-To: <20190430140325.45537-1-bruce.richardson@intel.com>

The local variables for the error message aren't needed, since the messages
aren't used more than once, and the indent levels are now such that the
lines printing the message are not much longer than the lines defining the
variables to hold the messages themselves. Therefore the use of the
variables is pointless.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 kernel/linux/meson.build | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/kernel/linux/meson.build b/kernel/linux/meson.build
index d31fc8f80..a37c95752 100644
--- a/kernel/linux/meson.build
+++ b/kernel/linux/meson.build
@@ -3,12 +3,9 @@
 
 subdirs = ['igb_uio', 'kni']
 
-WARN_CROSS_COMPILE='Need "kernel_dir" option for kmod compilation when cross-compiling'
-WARN_NO_HEADERS='Cannot compile kernel modules as requested - are kernel headers installed?'
-
 # if we are cross-compiling we need kernel_dir specified
 if get_option('kernel_dir') == '' and meson.is_cross_build()
-	warning(WARN_CROSS_COMPILE)
+	warning('Need "kernel_dir" option for kmod compilation when cross-compiling')
 	subdir_done()
 endif
 
@@ -23,7 +20,7 @@ endif
 make_returncode = run_command('make', '-sC', kernel_dir,
 		'kernelversion').returncode()
 if make_returncode != 0
-	warning(WARN_NO_HEADERS)
+	warning('Cannot compile kernel modules as requested - are kernel headers installed?')
 	subdir_done()
 endif
 
-- 
2.20.1


  parent reply	other threads:[~2019-04-30 14:04 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-30 14:03 [dpdk-dev] [PATCH 19.08 0/3] cleanup kernel meson.build file for linux Bruce Richardson
2019-04-30 14:03 ` Bruce Richardson
2019-04-30 14:03 ` [dpdk-dev] [PATCH 19.08 1/3] kernel/linux: remove unnecessary meson version check Bruce Richardson
2019-04-30 14:03   ` Bruce Richardson
2019-04-30 14:13   ` Bruce Richardson
2019-04-30 14:13     ` Bruce Richardson
2019-04-30 14:03 ` [dpdk-dev] [PATCH 19.08 2/3] kernel/linux: reduce unneeded indents in meson build file Bruce Richardson
2019-04-30 14:03   ` Bruce Richardson
2019-04-30 14:03 ` Bruce Richardson [this message]
2019-04-30 14:03   ` [dpdk-dev] [PATCH 19.08 3/3] kernel/linux: remove unneeded local variables Bruce Richardson
2019-04-30 14:17 ` [dpdk-dev] [PATCH 19.08 0/3] cleanup kernel meson.build file for linux David Marchand
2019-04-30 14:17   ` David Marchand
2019-05-17 13:45 ` [dpdk-dev] [PATCH v2 " Bruce Richardson
2019-05-17 13:45   ` [dpdk-dev] [PATCH v2 1/3] kernel/linux: remove unnecessary meson version check Bruce Richardson
2019-05-17 13:45   ` [dpdk-dev] [PATCH v2 2/3] kernel/linux: reduce unneeded indents in meson build file Bruce Richardson
2019-05-17 13:45   ` [dpdk-dev] [PATCH v2 3/3] kernel/linux: remove unneeded local variables Bruce Richardson
2019-05-17 13:53   ` [dpdk-dev] [PATCH v2 0/3] cleanup kernel meson.build file for linux Luca Boccassi
2019-05-29 22:27     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190430140325.45537-4-bruce.richardson@intel.com \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).