From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 19.08 1/3] kernel/linux: remove unnecessary meson version check
Date: Tue, 30 Apr 2019 15:13:42 +0100 [thread overview]
Message-ID: <20190430141342.GA1795@bricha3-MOBL.ger.corp.intel.com> (raw)
Message-ID: <20190430141342.v6oXXffSceQyIHyA-Du_5gzabJZPLro5B06wyOCMlL4@z> (raw)
In-Reply-To: <20190430140325.45537-2-bruce.richardson@intel.com>
On Tue, Apr 30, 2019 at 03:03:23PM +0100, Bruce Richardson wrote:
> The check for meson version 0.44 is not redundant since the minimum
"not", in this case, being used as a synonym for "now" :-)
> supported version for the project as a whole is 0.47.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> kernel/linux/meson.build | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/kernel/linux/meson.build b/kernel/linux/meson.build
> index d751d939f..bf8f085b0 100644
> --- a/kernel/linux/meson.build
> +++ b/kernel/linux/meson.build
> @@ -7,13 +7,8 @@ WARN_CROSS_COMPILE='Need "kernel_dir" option for kmod compilation when cross-com
> WARN_NO_HEADERS='Cannot compile kernel modules as requested - are kernel headers installed?'
>
> # if we are cross-compiling we need kernel_dir specified
> -# NOTE: warning() function only available from version 0.44 onwards
> if get_option('kernel_dir') == '' and meson.is_cross_build()
> - if meson.version().version_compare('>=0.44')
> - warning(WARN_CROSS_COMPILE)
> - else
> - message('WARNING: ' + WARN_CROSS_COMPILE)
> - endif
> + warning(WARN_CROSS_COMPILE)
> else
>
> kernel_dir = get_option('kernel_dir')
> --
> 2.20.1
>
next prev parent reply other threads:[~2019-04-30 14:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-30 14:03 [dpdk-dev] [PATCH 19.08 0/3] cleanup kernel meson.build file for linux Bruce Richardson
2019-04-30 14:03 ` Bruce Richardson
2019-04-30 14:03 ` [dpdk-dev] [PATCH 19.08 1/3] kernel/linux: remove unnecessary meson version check Bruce Richardson
2019-04-30 14:03 ` Bruce Richardson
2019-04-30 14:13 ` Bruce Richardson [this message]
2019-04-30 14:13 ` Bruce Richardson
2019-04-30 14:03 ` [dpdk-dev] [PATCH 19.08 2/3] kernel/linux: reduce unneeded indents in meson build file Bruce Richardson
2019-04-30 14:03 ` Bruce Richardson
2019-04-30 14:03 ` [dpdk-dev] [PATCH 19.08 3/3] kernel/linux: remove unneeded local variables Bruce Richardson
2019-04-30 14:03 ` Bruce Richardson
2019-04-30 14:17 ` [dpdk-dev] [PATCH 19.08 0/3] cleanup kernel meson.build file for linux David Marchand
2019-04-30 14:17 ` David Marchand
2019-05-17 13:45 ` [dpdk-dev] [PATCH v2 " Bruce Richardson
2019-05-17 13:45 ` [dpdk-dev] [PATCH v2 1/3] kernel/linux: remove unnecessary meson version check Bruce Richardson
2019-05-17 13:45 ` [dpdk-dev] [PATCH v2 2/3] kernel/linux: reduce unneeded indents in meson build file Bruce Richardson
2019-05-17 13:45 ` [dpdk-dev] [PATCH v2 3/3] kernel/linux: remove unneeded local variables Bruce Richardson
2019-05-17 13:53 ` [dpdk-dev] [PATCH v2 0/3] cleanup kernel meson.build file for linux Luca Boccassi
2019-05-29 22:27 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190430141342.GA1795@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).