DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>,
	vladz@cloudius-systems.com
Subject: [dpdk-dev] [PATCH 1/4] net/ixgbe: fix warning with GCC 9 on Fedora 30
Date: Wed,  1 May 2019 20:50:11 +0100	[thread overview]
Message-ID: <20190501195014.2938-2-bruce.richardson@intel.com> (raw)
Message-ID: <20190501195011.UZPPPg4ZALhKdh8ja_zVRQmIG9JNgc4O26s7DNSD6QI@z> (raw)
In-Reply-To: <20190501195014.2938-1-bruce.richardson@intel.com>

Compiling on Fedora 30, we get the following warning, causing build failure
when Werror flag is set:

../drivers/net/ixgbe/ixgbe_rxtx.c:2141:14: warning: ‘nmb’ may be used uninitialized in this function [-Wmaybe-uninitialized]
 2141 |    rxe->mbuf = nmb;
      |    ~~~~~~~~~~^~~~~

Initializing the value to "NULL" fixes the issue.

Fixes: 8eecb3295aed ("ixgbe: add LRO support")
Cc: vladz@cloudius-systems.com

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 drivers/net/ixgbe/ixgbe_rxtx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c
index e71d3c188..1fbc754ae 100644
--- a/drivers/net/ixgbe/ixgbe_rxtx.c
+++ b/drivers/net/ixgbe/ixgbe_rxtx.c
@@ -2029,7 +2029,7 @@ ixgbe_recv_pkts_lro(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts,
 		struct ixgbe_rx_entry *next_rxe = NULL;
 		struct rte_mbuf *first_seg;
 		struct rte_mbuf *rxm;
-		struct rte_mbuf *nmb;
+		struct rte_mbuf *nmb = NULL;
 		union ixgbe_adv_rx_desc rxd;
 		uint16_t data_len;
 		uint16_t next_id;
-- 
2.21.0


  parent reply	other threads:[~2019-05-01 19:50 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-01 19:50 [dpdk-dev] [PATCH 0/4] fix warnings with gcc " Bruce Richardson
2019-05-01 19:50 ` Bruce Richardson
2019-05-01 19:50 ` Bruce Richardson [this message]
2019-05-01 19:50   ` [dpdk-dev] [PATCH 1/4] net/ixgbe: fix warning with GCC " Bruce Richardson
2019-05-02 12:20   ` David Marchand
2019-05-02 12:20     ` David Marchand
2019-05-01 19:50 ` [dpdk-dev] [PATCH 2/4] bus/fslmc: fix printf of null pointer Bruce Richardson
2019-05-01 19:50   ` Bruce Richardson
2019-05-02 12:20   ` David Marchand
2019-05-02 12:20     ` David Marchand
2019-05-01 19:50 ` [dpdk-dev] [PATCH 3/4] raw/skeleton_rawdev: fix warnings with GCC 9 on Fedora 30 Bruce Richardson
2019-05-01 19:50   ` Bruce Richardson
2019-05-02 12:22   ` David Marchand
2019-05-02 12:22     ` David Marchand
2019-05-01 19:50 ` [dpdk-dev] [PATCH 4/4] raw/dpaa2_cmdif: " Bruce Richardson
2019-05-01 19:50   ` Bruce Richardson
2019-05-02 12:24   ` David Marchand
2019-05-02 12:24     ` David Marchand
2019-05-02 12:18 ` [dpdk-dev] [PATCH 0/4] fix warnings with gcc " Thomas Monjalon
2019-05-02 12:18   ` Thomas Monjalon
2019-05-02 12:32   ` [dpdk-dev] [dpdk-stable] " David Marchand
2019-05-02 12:32     ` David Marchand
2019-05-02 13:24     ` Bruce Richardson
2019-05-02 13:24       ` Bruce Richardson
2019-05-02 13:32       ` David Marchand
2019-05-02 13:32         ` David Marchand
2019-05-02 13:46         ` Bruce Richardson
2019-05-02 13:46           ` Bruce Richardson
2019-05-02 13:53           ` David Marchand
2019-05-02 13:53             ` David Marchand
2019-05-02 14:04             ` Bruce Richardson
2019-05-02 14:04               ` Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190501195014.2938-2-bruce.richardson@intel.com \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=vladz@cloudius-systems.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).