DPDK patches and discussions
 help / color / mirror / Atom feed
From: Shahaf Shuler <shahafs@mellanox.com>
To: Dekel Peled <dekelp@mellanox.com>, Yongseok Koh <yskoh@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 0/4] net/mlx5: code cleanup in rx and tx files
Date: Thu, 2 May 2019 14:10:50 +0000	[thread overview]
Message-ID: <AM0PR0502MB3795E93A71BCC0C999BBCEABC3340@AM0PR0502MB3795.eurprd05.prod.outlook.com> (raw)
Message-ID: <20190502141050.UwUBqEd9GubcqF6dCmHz-5ruVXiztV9eDjkOKynHx4Q@z> (raw)
In-Reply-To: <cover.1556534247.git.dekelp@mellanox.com>

Hi Dekel,

Monday, April 29, 2019 2:01 PM, Dekel Peled:
> Subject: [dpdk-dev] [PATCH 0/4] net/mlx5: code cleanup in rx and tx files
> 
> During work on Rx feature I did some cleanup actions.
> This series includes those changes divided by their type.

Good cleanup.
I am basically OK w/ the series, you can add my Acked-by to next version. See small comment below.

> 
> Dekel Peled (4):
>   net/mlx5: remove unused functions
>   net/mlx5: add missing validation of null pointer

This one should be "fix ..." and not "add ..." + Cc for stable. Since you actually fix a possible segfault. 

>   net/mlx5: fix description of function return value
>   net/mlx5: move locally used functions to static
> 
>  drivers/net/mlx5/mlx5_rxq.c  | 218 +++++++++++++++++++-------------------
> -----
>  drivers/net/mlx5/mlx5_rxtx.h |  20 ----  drivers/net/mlx5/mlx5_txq.c  |  13 --
> -
>  3 files changed, 94 insertions(+), 157 deletions(-)
> 
> --
> 1.8.3.1


  parent reply	other threads:[~2019-05-02 14:10 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-29 11:00 Dekel Peled
2019-04-29 11:00 ` Dekel Peled
2019-04-29 11:00 ` [dpdk-dev] [PATCH 1/4] net/mlx5: remove unused functions Dekel Peled
2019-04-29 11:00   ` Dekel Peled
2019-04-29 11:00 ` [dpdk-dev] [PATCH 2/4] net/mlx5: add missing validation of null pointer Dekel Peled
2019-04-29 11:00   ` Dekel Peled
2019-04-29 11:00 ` [dpdk-dev] [PATCH 3/4] net/mlx5: fix description of function return value Dekel Peled
2019-04-29 11:00   ` Dekel Peled
2019-04-29 11:00 ` [dpdk-dev] [PATCH 4/4] net/mlx5: move locally used functions to static Dekel Peled
2019-04-29 11:00   ` Dekel Peled
2019-05-02 14:10 ` Shahaf Shuler [this message]
2019-05-02 14:10   ` [dpdk-dev] [PATCH 0/4] net/mlx5: code cleanup in rx and tx files Shahaf Shuler
2019-05-02 15:01 ` [dpdk-dev] [PATCH v2 " Dekel Peled
2019-05-02 15:01   ` Dekel Peled
2019-05-02 15:01   ` [dpdk-dev] [PATCH v2 1/4] net/mlx5: remove unused functions Dekel Peled
2019-05-02 15:01     ` Dekel Peled
2019-05-02 18:13     ` Yongseok Koh
2019-05-02 18:13       ` Yongseok Koh
2019-05-02 15:01   ` [dpdk-dev] [PATCH v2 2/4] net/mlx5: fix missing validation of null pointer Dekel Peled
2019-05-02 15:01     ` Dekel Peled
2019-05-02 18:12     ` Yongseok Koh
2019-05-02 18:12       ` Yongseok Koh
2019-05-02 15:01   ` [dpdk-dev] [PATCH v2 3/4] net/mlx5: fix description of function return value Dekel Peled
2019-05-02 15:01     ` Dekel Peled
2019-05-02 18:13     ` Yongseok Koh
2019-05-02 18:13       ` Yongseok Koh
2019-05-02 15:01   ` [dpdk-dev] [PATCH v2 4/4] net/mlx5: move locally used functions to static Dekel Peled
2019-05-02 15:01     ` Dekel Peled
2019-05-02 18:14     ` Yongseok Koh
2019-05-02 18:14       ` Yongseok Koh
2019-05-05 13:09   ` [dpdk-dev] [PATCH v3 0/4] net/mlx5: code cleanup in rx and tx files Dekel Peled
2019-05-05 13:09     ` Dekel Peled
2019-05-05 13:09     ` [dpdk-dev] [PATCH v3 1/4] net/mlx5: remove unused functions Dekel Peled
2019-05-05 13:09       ` Dekel Peled
2019-05-05 13:09     ` [dpdk-dev] [PATCH v3 2/4] net/mlx5: fix missing validation of null pointer Dekel Peled
2019-05-05 13:09       ` Dekel Peled
2019-05-05 13:09     ` [dpdk-dev] [PATCH v3 3/4] net/mlx5: fix description of function return value Dekel Peled
2019-05-05 13:09       ` Dekel Peled
2019-05-05 13:09     ` [dpdk-dev] [PATCH v3 4/4] net/mlx5: move locally used functions to static Dekel Peled
2019-05-05 13:09       ` Dekel Peled
2019-05-08  4:43     ` [dpdk-dev] [PATCH v3 0/4] net/mlx5: code cleanup in rx and tx files Shahaf Shuler
2019-05-08  4:43       ` Shahaf Shuler
2019-05-08  8:29     ` [dpdk-dev] [PATCH v4 " Dekel Peled
2019-05-08  8:29       ` Dekel Peled
2019-05-08  8:29       ` [dpdk-dev] [PATCH v4 1/4] net/mlx5: remove unused functions Dekel Peled
2019-05-08  8:29         ` Dekel Peled
2019-05-08  8:29       ` [dpdk-dev] [PATCH v4 2/4] net/mlx5: fix missing validation of null pointer Dekel Peled
2019-05-08  8:29         ` Dekel Peled
2019-05-08  8:29       ` [dpdk-dev] [PATCH v4 3/4] net/mlx5: fix description of function return value Dekel Peled
2019-05-08  8:29         ` Dekel Peled
2019-05-08  8:29       ` [dpdk-dev] [PATCH v4 4/4] net/mlx5: move locally used functions to static Dekel Peled
2019-05-08  8:29         ` Dekel Peled
2019-05-22 20:35       ` [dpdk-dev] [PATCH v4 0/4] net/mlx5: code cleanup in rx and tx files Shahaf Shuler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM0PR0502MB3795E93A71BCC0C999BBCEABC3340@AM0PR0502MB3795.eurprd05.prod.outlook.com \
    --to=shahafs@mellanox.com \
    --cc=dekelp@mellanox.com \
    --cc=dev@dpdk.org \
    --cc=yskoh@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).