From: Yongseok Koh <yskoh@mellanox.com>
To: Dekel Peled <dekelp@mellanox.com>
Cc: Shahaf Shuler <shahafs@mellanox.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 3/4] net/mlx5: fix description of function return value
Date: Thu, 2 May 2019 18:13:35 +0000 [thread overview]
Message-ID: <08F3CC29-B432-47BB-B887-1D53908CA4C4@mellanox.com> (raw)
Message-ID: <20190502181335.7IOBB_ais3VeCQO4KrDPGb019vw47iPvFDIgSwfdldQ@z> (raw)
In-Reply-To: <c49673972995d19ed36c6cdd8f44388b282fff68.1556809050.git.dekelp@mellanox.com>
> On May 2, 2019, at 8:01 AM, Dekel Peled <dekelp@mellanox.com> wrote:
>
> Return value of function mlx5_rxq_releasable() was not described
> correctly in function description.
>
> This patch updates the description to correctly describe the optional
> return values.
>
> Fixes: a6d83b6a9209 ("net/mlx5: standardize on negative errno values")
> cc: stable@dpdk.org
>
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> ---
Acked-by: Yongseok Koh <yskoh@mellanox.com>
> drivers/net/mlx5/mlx5_rxq.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c
> index c9c2a14..a547f2a 100644
> --- a/drivers/net/mlx5/mlx5_rxq.c
> +++ b/drivers/net/mlx5/mlx5_rxq.c
> @@ -1546,8 +1546,9 @@ struct mlx5_rxq_ctrl *
> * RX queue index.
> *
> * @return
> - * 1 if the queue can be released, negative errno otherwise and rte_errno is
> - * set.
> + * 1 if the queue can be released
> + * 0 if the queue can not be released, there are references to it.
> + * Negative errno and rte_errno is set if queue doesn't exist.
> */
> int
> mlx5_rxq_releasable(struct rte_eth_dev *dev, uint16_t idx)
> --
> 1.8.3.1
>
next prev parent reply other threads:[~2019-05-02 18:13 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-29 11:00 [dpdk-dev] [PATCH 0/4] net/mlx5: code cleanup in rx and tx files Dekel Peled
2019-04-29 11:00 ` Dekel Peled
2019-04-29 11:00 ` [dpdk-dev] [PATCH 1/4] net/mlx5: remove unused functions Dekel Peled
2019-04-29 11:00 ` Dekel Peled
2019-04-29 11:00 ` [dpdk-dev] [PATCH 2/4] net/mlx5: add missing validation of null pointer Dekel Peled
2019-04-29 11:00 ` Dekel Peled
2019-04-29 11:00 ` [dpdk-dev] [PATCH 3/4] net/mlx5: fix description of function return value Dekel Peled
2019-04-29 11:00 ` Dekel Peled
2019-04-29 11:00 ` [dpdk-dev] [PATCH 4/4] net/mlx5: move locally used functions to static Dekel Peled
2019-04-29 11:00 ` Dekel Peled
2019-05-02 14:10 ` [dpdk-dev] [PATCH 0/4] net/mlx5: code cleanup in rx and tx files Shahaf Shuler
2019-05-02 14:10 ` Shahaf Shuler
2019-05-02 15:01 ` [dpdk-dev] [PATCH v2 " Dekel Peled
2019-05-02 15:01 ` Dekel Peled
2019-05-02 15:01 ` [dpdk-dev] [PATCH v2 1/4] net/mlx5: remove unused functions Dekel Peled
2019-05-02 15:01 ` Dekel Peled
2019-05-02 18:13 ` Yongseok Koh
2019-05-02 18:13 ` Yongseok Koh
2019-05-02 15:01 ` [dpdk-dev] [PATCH v2 2/4] net/mlx5: fix missing validation of null pointer Dekel Peled
2019-05-02 15:01 ` Dekel Peled
2019-05-02 18:12 ` Yongseok Koh
2019-05-02 18:12 ` Yongseok Koh
2019-05-02 15:01 ` [dpdk-dev] [PATCH v2 3/4] net/mlx5: fix description of function return value Dekel Peled
2019-05-02 15:01 ` Dekel Peled
2019-05-02 18:13 ` Yongseok Koh [this message]
2019-05-02 18:13 ` Yongseok Koh
2019-05-02 15:01 ` [dpdk-dev] [PATCH v2 4/4] net/mlx5: move locally used functions to static Dekel Peled
2019-05-02 15:01 ` Dekel Peled
2019-05-02 18:14 ` Yongseok Koh
2019-05-02 18:14 ` Yongseok Koh
2019-05-05 13:09 ` [dpdk-dev] [PATCH v3 0/4] net/mlx5: code cleanup in rx and tx files Dekel Peled
2019-05-05 13:09 ` Dekel Peled
2019-05-05 13:09 ` [dpdk-dev] [PATCH v3 1/4] net/mlx5: remove unused functions Dekel Peled
2019-05-05 13:09 ` Dekel Peled
2019-05-05 13:09 ` [dpdk-dev] [PATCH v3 2/4] net/mlx5: fix missing validation of null pointer Dekel Peled
2019-05-05 13:09 ` Dekel Peled
2019-05-05 13:09 ` [dpdk-dev] [PATCH v3 3/4] net/mlx5: fix description of function return value Dekel Peled
2019-05-05 13:09 ` Dekel Peled
2019-05-05 13:09 ` [dpdk-dev] [PATCH v3 4/4] net/mlx5: move locally used functions to static Dekel Peled
2019-05-05 13:09 ` Dekel Peled
2019-05-08 4:43 ` [dpdk-dev] [PATCH v3 0/4] net/mlx5: code cleanup in rx and tx files Shahaf Shuler
2019-05-08 4:43 ` Shahaf Shuler
2019-05-08 8:29 ` [dpdk-dev] [PATCH v4 " Dekel Peled
2019-05-08 8:29 ` Dekel Peled
2019-05-08 8:29 ` [dpdk-dev] [PATCH v4 1/4] net/mlx5: remove unused functions Dekel Peled
2019-05-08 8:29 ` Dekel Peled
2019-05-08 8:29 ` [dpdk-dev] [PATCH v4 2/4] net/mlx5: fix missing validation of null pointer Dekel Peled
2019-05-08 8:29 ` Dekel Peled
2019-05-08 8:29 ` [dpdk-dev] [PATCH v4 3/4] net/mlx5: fix description of function return value Dekel Peled
2019-05-08 8:29 ` Dekel Peled
2019-05-08 8:29 ` [dpdk-dev] [PATCH v4 4/4] net/mlx5: move locally used functions to static Dekel Peled
2019-05-08 8:29 ` Dekel Peled
2019-05-22 20:35 ` [dpdk-dev] [PATCH v4 0/4] net/mlx5: code cleanup in rx and tx files Shahaf Shuler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08F3CC29-B432-47BB-B887-1D53908CA4C4@mellanox.com \
--to=yskoh@mellanox.com \
--cc=dekelp@mellanox.com \
--cc=dev@dpdk.org \
--cc=shahafs@mellanox.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).