DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>,
	Herakliusz Lipiec <herakliusz.lipiec@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v4 0/2] ipc: fix possible memleaks
Date: Fri, 3 May 2019 09:38:41 +0100	[thread overview]
Message-ID: <173ee033-e181-6ea8-b567-c683ce2c5028@intel.com> (raw)
Message-ID: <20190503083841.mtAb9EWajeHYobvGaK0tFIXrjkXVZDkrtp4cgoTbOd0@z> (raw)
In-Reply-To: <3401531.dNvLWj16ye@xps>

On 03-May-19 9:34 AM, Thomas Monjalon wrote:
> 25/04/2019 14:48, Herakliusz Lipiec:
>> When sending multiple requests, rte_mp_request_sync
>> can succeed sending a few of those requests, but then
>> fail on a later one and in the end return with rc=-1.
>> The upper layers - e.g. device hotplug - currently
>> handles this case as if no messages were sent and no
>> memory for response buffers was allocated, which is
>> not true. Fixed by always initializing message buffer
>> to NULL and calling free everytime rte_mp_request_sync
>> is used.
>>
>> v2:
>> - resending as patchset to make it easier to review it.
> 
> Heraliusz, it's a total mess.
> There were 8 patches in v2. Why they disappeared?
> The title prefixes are often wrong, so it's harder to classify them.
> 
> Should I merge all these patches?
>    ipc: fix rte_mp_request_sync memleak
>    ipc: fix hotplug memleak
>    ipc: fix vdev memleak
>    ipc: fix vfio memleak
>    ipc: fix pdump memleak
>    ipc: fix tap pmd memleak
>    ipc: fix net/mlx4 memleak
>    ipc: fix net/mlx5 memleak
> 

Hi Thomas,

you've also skipped the following:

 > v3:
 > - rework of the patchset
 > - caller is no longer responsible for freeing buffers on failure
 > - caller still has to free response buffers on success

the v3 was where the 8 patch patchset was reworked into two-patch 
patchset, because we've changed our approach.

So no, those 8 patches should not be merged - they're superseded by v3 
(well, v4 now).

-- 
Thanks,
Anatoly

  parent reply	other threads:[~2019-05-03  8:38 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-17 14:38 [dpdk-dev] [PATCH 1/8] ipc: fix rte_mp_request_sync memleak Herakliusz Lipiec
2019-04-17 14:38 ` Herakliusz Lipiec
2019-04-23  8:11 ` Burakov, Anatoly
2019-04-23  8:11   ` Burakov, Anatoly
2019-04-23  8:13 ` Burakov, Anatoly
2019-04-23  8:13   ` Burakov, Anatoly
2019-04-23 17:43 ` [dpdk-dev] [PATCH v2 0/8] ipc: fix possible memleaks Herakliusz Lipiec
2019-04-23 17:43   ` Herakliusz Lipiec
2019-04-23 17:43   ` [dpdk-dev] [PATCH v2 1/8] ipc: fix rte_mp_request_sync memleak Herakliusz Lipiec
2019-04-23 17:43     ` Herakliusz Lipiec
2019-04-24  9:28     ` Stojaczyk, Dariusz
2019-04-24  9:28       ` Stojaczyk, Dariusz
2019-04-25  9:37     ` Burakov, Anatoly
2019-04-25  9:37       ` Burakov, Anatoly
2019-04-23 17:43   ` [dpdk-dev] [PATCH v2 2/8] ipc: fix hotplug memleak Herakliusz Lipiec
2019-04-23 17:43     ` Herakliusz Lipiec
2019-04-25  6:00     ` Stojaczyk, Dariusz
2019-04-25  6:00       ` Stojaczyk, Dariusz
2019-04-23 17:43   ` [dpdk-dev] [PATCH v2 3/8] ipc: fix vdev memleak Herakliusz Lipiec
2019-04-23 17:43     ` Herakliusz Lipiec
2019-04-25  6:08     ` Stojaczyk, Dariusz
2019-04-25  6:08       ` Stojaczyk, Dariusz
2019-04-23 17:43   ` [dpdk-dev] [PATCH v2 4/8] ipc: fix vfio memleak Herakliusz Lipiec
2019-04-23 17:43     ` Herakliusz Lipiec
2019-04-25  6:06     ` Stojaczyk, Dariusz
2019-04-25  6:06       ` Stojaczyk, Dariusz
2019-04-23 17:43   ` [dpdk-dev] [PATCH v2 5/8] ipc: fix pdump memleak Herakliusz Lipiec
2019-04-23 17:43     ` Herakliusz Lipiec
2019-04-23 17:43   ` [dpdk-dev] [PATCH v2 6/8] ipc: fix tap pmd memleak Herakliusz Lipiec
2019-04-23 17:43     ` Herakliusz Lipiec
2019-04-23 17:43   ` [dpdk-dev] [PATCH v2 7/8] ipc: fix net/mlx4 memleak Herakliusz Lipiec
2019-04-23 17:43     ` Herakliusz Lipiec
2019-04-23 20:16     ` Yongseok Koh
2019-04-23 20:16       ` Yongseok Koh
2019-04-23 17:43   ` [dpdk-dev] [PATCH v2 8/8] ipc: fix net/mlx5 memleak Herakliusz Lipiec
2019-04-23 17:43     ` Herakliusz Lipiec
2019-04-23 20:16     ` Yongseok Koh
2019-04-23 20:16       ` Yongseok Koh
2019-04-25 11:43   ` [dpdk-dev] [PATCH v3 0/2] ipc: fix possible memleaks Herakliusz Lipiec
2019-04-25 11:43     ` Herakliusz Lipiec
2019-04-25 11:43     ` [dpdk-dev] [PATCH v3 1/2] ipc: fix rte_mp_request_sync memleak Herakliusz Lipiec
2019-04-25 11:43       ` Herakliusz Lipiec
2019-04-25 12:47       ` Burakov, Anatoly
2019-04-25 12:47         ` Burakov, Anatoly
2019-04-25 11:43     ` [dpdk-dev] [PATCH v3 2/2] ipc: fix tap pmd memleak Herakliusz Lipiec
2019-04-25 11:43       ` Herakliusz Lipiec
2019-04-25 12:48     ` [dpdk-dev] [PATCH v4 0/2] ipc: fix possible memleaks Herakliusz Lipiec
2019-04-25 12:48       ` Herakliusz Lipiec
2019-04-25 12:48       ` [dpdk-dev] [PATCH v4 1/2] ipc: fix rte_mp_request_sync memleak Herakliusz Lipiec
2019-04-25 12:48         ` Herakliusz Lipiec
2019-04-25 12:48         ` Burakov, Anatoly
2019-04-25 12:48           ` Burakov, Anatoly
2019-04-25 12:48       ` [dpdk-dev] [PATCH v4 2/2] ipc: fix tap pmd memleak Herakliusz Lipiec
2019-04-25 12:48         ` Herakliusz Lipiec
2019-04-25 18:14         ` Wiles, Keith
2019-04-25 18:14           ` Wiles, Keith
2019-05-03  8:34       ` [dpdk-dev] [PATCH v4 0/2] ipc: fix possible memleaks Thomas Monjalon
2019-05-03  8:34         ` Thomas Monjalon
2019-05-03  8:38         ` Burakov, Anatoly [this message]
2019-05-03  8:38           ` Burakov, Anatoly
2019-05-03 10:28       ` [dpdk-dev] [PATCH v5 0/2] ipc: fix possible memory leaks Herakliusz Lipiec
2019-05-03 10:28         ` Herakliusz Lipiec
2019-05-03 10:28         ` [dpdk-dev] [PATCH v5 1/2] ipc: fix memory leak in sync request Herakliusz Lipiec
2019-05-03 10:28           ` Herakliusz Lipiec
2019-05-03 10:28         ` [dpdk-dev] [PATCH v5 2/2] net/tap: fix ipc related memory leak Herakliusz Lipiec
2019-05-03 10:28           ` Herakliusz Lipiec
2019-05-03 10:54         ` [dpdk-dev] [PATCH v5 0/2] ipc: fix possible memory leaks Thomas Monjalon
2019-05-03 10:54           ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=173ee033-e181-6ea8-b567-c683ce2c5028@intel.com \
    --to=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=herakliusz.lipiec@intel.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).