From: David Marchand <david.marchand@redhat.com>
To: Aaron Conole <aconole@redhat.com>
Cc: dev <dev@dpdk.org>,
Herakliusz Lipiec <herakliusz.lipiec@intel.com>,
dpdk stable <stable@dpdk.org>,
Anatoly Burakov <anatoly.burakov@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] ipc: unlock on failure
Date: Mon, 6 May 2019 16:02:00 +0200 [thread overview]
Message-ID: <CAJFAV8xNWFwPjHxr8fBqduQT1FjB=xmOK=OfzaOi-esL92766A@mail.gmail.com> (raw)
Message-ID: <20190506140200.YZZRUuoxpxM8XhdZy2oOV9Or4QvVOXhz-g8KJ1MLkXI@z> (raw)
In-Reply-To: <20190506134825.20706-1-aconole@redhat.com>
On Mon, May 6, 2019 at 3:48 PM Aaron Conole <aconole@redhat.com> wrote:
> Reported by Coverity.
>
>
Coverity issue: 340076
Fixes: a2a06860b8c4 ("ipc: fix memory leak on request failure")
> Cc: Herakliusz Lipiec <herakliusz.lipiec@intel.com>
> Cc: stable@dpdk.org
> Cc: Anatoly Burakov <anatoly.burakov@intel.com>
> Signed-off-by: Aaron Conole <aconole@redhat.com>
> ---
> lib/librte_eal/common/eal_common_proc.c | 34 +++++++++++++------------
> 1 file changed, 18 insertions(+), 16 deletions(-)
>
> diff --git a/lib/librte_eal/common/eal_common_proc.c
> b/lib/librte_eal/common/eal_common_proc.c
> index d23728604..1a2259fe3 100644
> --- a/lib/librte_eal/common/eal_common_proc.c
> +++ b/lib/librte_eal/common/eal_common_proc.c
> @@ -934,7 +934,7 @@ int __rte_experimental
> rte_mp_request_sync(struct rte_mp_msg *req, struct rte_mp_reply *reply,
> const struct timespec *ts)
> {
> - int dir_fd, ret = 0;
> + int dir_fd, ret = -1;
> DIR *mp_dir;
> struct dirent *ent;
> struct timeval now;
> @@ -947,7 +947,7 @@ rte_mp_request_sync(struct rte_mp_msg *req, struct
> rte_mp_reply *reply,
> reply->msgs = NULL;
>
> if (check_input(req) != 0)
> - goto err;
> + goto end;
>
> if (internal_config.no_shconf) {
> RTE_LOG(DEBUG, EAL, "No shared files mode enabled, IPC is
> disabled\n");
> @@ -957,7 +957,7 @@ rte_mp_request_sync(struct rte_mp_msg *req, struct
> rte_mp_reply *reply,
> if (gettimeofday(&now, NULL) < 0) {
> RTE_LOG(ERR, EAL, "Failed to get current time\n");
> rte_errno = errno;
> - goto err;
> + goto end;
> }
>
> end.tv_nsec = (now.tv_usec * 1000 + ts->tv_nsec) % 1000000000;
> @@ -969,9 +969,7 @@ rte_mp_request_sync(struct rte_mp_msg *req, struct
> rte_mp_reply *reply,
> pthread_mutex_lock(&pending_requests.lock);
> ret = mp_request_sync(eal_mp_socket_path(), req, reply,
> &end);
> pthread_mutex_unlock(&pending_requests.lock);
> - if (ret)
> - goto err;
> - return ret;
> + goto end;
> }
>
> /* for primary process, broadcast request, and collect reply 1 by
> 1 */
> @@ -979,7 +977,7 @@ rte_mp_request_sync(struct rte_mp_msg *req, struct
> rte_mp_reply *reply,
> if (!mp_dir) {
> RTE_LOG(ERR, EAL, "Unable to open directory %s\n",
> mp_dir_path);
> rte_errno = errno;
> - goto err;
> + goto end;
> }
>
> dir_fd = dirfd(mp_dir);
> @@ -987,9 +985,8 @@ rte_mp_request_sync(struct rte_mp_msg *req, struct
> rte_mp_reply *reply,
> if (flock(dir_fd, LOCK_SH)) {
> RTE_LOG(ERR, EAL, "Unable to lock directory %s\n",
> mp_dir_path);
> - closedir(mp_dir);
> rte_errno = errno;
> - goto err;
> + goto close_end;
> }
>
> pthread_mutex_lock(&pending_requests.lock);
> @@ -1006,21 +1003,26 @@ rte_mp_request_sync(struct rte_mp_msg *req, struct
> rte_mp_reply *reply,
> * locks on receive
> */
> if (mp_request_sync(path, req, reply, &end))
> - goto err;
> + goto unlock_end;
> }
> + ret = 0;
> +
> +unlock_end:
> pthread_mutex_unlock(&pending_requests.lock);
> /* unlock the directory */
> flock(dir_fd, LOCK_UN);
>
> +close_end:
> /* dir_fd automatically closed on closedir */
> closedir(mp_dir);
> - return ret;
>
> -err:
> - free(reply->msgs);
> - reply->nb_received = 0;
> - reply->msgs = NULL;
> - return -1;
> +end:
> + if (ret) {
> + free(reply->msgs);
> + reply->nb_received = 0;
> + reply->msgs = NULL;
> + }
> + return ret;
> }
>
> int __rte_experimental
> --
> 2.19.1
>
LGTM.
Reviewed-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
next prev parent reply other threads:[~2019-05-06 14:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-06 13:11 [dpdk-dev] [PATCH] " Aaron Conole
2019-05-06 13:11 ` Aaron Conole
2019-05-06 13:14 ` David Marchand
2019-05-06 13:14 ` David Marchand
2019-05-06 13:22 ` Aaron Conole
2019-05-06 13:22 ` Aaron Conole
2019-05-06 13:48 ` [dpdk-dev] [PATCH v2] " Aaron Conole
2019-05-06 13:48 ` Aaron Conole
2019-05-06 14:02 ` David Marchand [this message]
2019-05-06 14:02 ` David Marchand
2019-05-08 14:24 ` Stojaczyk, Dariusz
2019-05-08 14:24 ` Stojaczyk, Dariusz
2019-05-09 11:50 ` Burakov, Anatoly
2019-05-09 11:50 ` Burakov, Anatoly
2019-05-09 14:31 ` Thomas Monjalon
2019-05-09 14:31 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8xNWFwPjHxr8fBqduQT1FjB=xmOK=OfzaOi-esL92766A@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=aconole@redhat.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=herakliusz.lipiec@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).