From: Thomas Monjalon <thomas@monjalon.net>
To: Nithin Dabilpuram <nithind1988@gmail.com>,
Nithin Dabilpuram <ndabilpuram@marvell.com>
Cc: dev@dpdk.org, Wenzhuo Lu <wenzhuo.lu@intel.com>,
Jingjing Wu <jingjing.wu@intel.com>,
Bernard Iremonger <bernard.iremonger@intel.com>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: change port detach interface
Date: Tue, 14 May 2019 17:39:30 +0200 [thread overview]
Message-ID: <1973719.Au6Grg4Sd1@xps> (raw)
Message-ID: <20190514153930.LLQfL9EsoNiImaV9CIHeiI1iX4TJK8MowvJN2HLA2qI@z> (raw)
In-Reply-To: <20190513112112.7069-1-ndabilpuram@marvell.com>
Hi,
13/05/2019 13:21, Nithin Dabilpuram:
> With the latest published interface of
> rte_eal_hotplug_[add,remove](), and rte_eth_dev_close(),
> rte_eth_dev_close() would cleanup all the data structures of
> port's eth dev leaving the device common resource intact
> if RTE_ETH_DEV_CLOSE_REMOVE is set in dev flags.
> So "port detach" (~hotplug remove) should be able to work,
> with device identifier like "port attach" as eth_dev could have
> been closed already and rte_eth_devices[port_id] reused.
"port attach" uses devargs as identifier because there
is no port id before creating it. But "detach port" uses
logically the port id to close.
> This change alters "port detach" cmdline interface to
> work with device identifier like "port attach".
The word "port" means an ethdev port, so it should be
referenced with a port id.
If you want to close an EAL rte_device, then you should
rename the command.
But testpmd purpose should be to work with ethdev ports only.
PS: Please remind that a device can have multiple ports.
next prev parent reply other threads:[~2019-05-14 15:39 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-13 11:21 Nithin Dabilpuram
2019-05-13 11:21 ` Nithin Dabilpuram
2019-05-14 15:39 ` Thomas Monjalon [this message]
2019-05-14 15:39 ` Thomas Monjalon
2019-05-15 6:52 ` Nithin Dabilpuram
2019-05-15 6:52 ` Nithin Dabilpuram
2019-05-15 7:27 ` Thomas Monjalon
2019-05-15 7:27 ` Thomas Monjalon
2019-05-17 8:55 ` Nithin Dabilpuram
2019-05-17 8:59 ` Thomas Monjalon
2019-05-20 12:50 ` Nithin Dabilpuram
2019-05-29 8:16 ` Nithin Dabilpuram
2019-06-25 4:24 ` Nithin Dabilpuram
2019-07-02 15:58 ` Yigit, Ferruh
2019-07-03 5:05 ` Nithin Dabilpuram
2019-07-10 13:07 ` [dpdk-dev] [PATCH v2] app/testpmd: add device related cmds Nithin Dabilpuram
2019-07-16 18:30 ` Ferruh Yigit
2019-07-17 8:08 ` [dpdk-dev] [EXT] " Nithin Kumar Dabilpuram
2019-07-17 12:30 ` [dpdk-dev] [PATCH v3] " Nithin Dabilpuram
2019-07-17 16:51 ` Ferruh Yigit
2019-07-18 5:27 ` [dpdk-dev] [EXT] " Nithin Kumar Dabilpuram
2019-07-19 19:00 ` Ferruh Yigit
2019-07-22 6:01 ` Hemant Agrawal
2019-07-22 6:15 ` Nithin Kumar Dabilpuram
2019-07-22 16:04 ` Ferruh Yigit
2019-07-17 16:54 ` [dpdk-dev] " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1973719.Au6Grg4Sd1@xps \
--to=thomas@monjalon.net \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=ndabilpuram@marvell.com \
--cc=nithind1988@gmail.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).