From: David Marchand <david.marchand@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [RFC 2/4] net/ether: add eth_unformat_addr
Date: Thu, 16 May 2019 09:28:00 +0200 [thread overview]
Message-ID: <CAJFAV8yVC9yj2XQdcFp2OCrh27PSYv1KfN9T_Q6Gc7iO54XaEw@mail.gmail.com> (raw)
Message-ID: <20190516072800.O0Dxh1zL9daz7pNyXPFb9bTeDfS5FRhfmOAGYAMTz_A@z> (raw)
In-Reply-To: <20190515221952.21959-3-stephen@networkplumber.org>
On Thu, May 16, 2019 at 12:20 AM Stephen Hemminger <
stephen@networkplumber.org> wrote:
> Make a function that coresponds with eth_aton_r which can
>
nit: corresponds
be used to convert string to ether_addr.
>
> This also allows rte_ethdev to no longer depend on the
> cmdline library.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> lib/librte_net/rte_ether.c | 12 ++++++++++++
> lib/librte_net/rte_ether.h | 14 ++++++++++++++
> lib/librte_net/rte_net_version.map | 1 +
> 3 files changed, 27 insertions(+)
>
> diff --git a/lib/librte_net/rte_ether.c b/lib/librte_net/rte_ether.c
> index d4b41f122a16..ca7c841db197 100644
> --- a/lib/librte_net/rte_ether.c
> +++ b/lib/librte_net/rte_ether.c
> @@ -27,3 +27,15 @@ ether_format_addr(char *buf, uint16_t size,
> eth_addr->addr_bytes[4],
> eth_addr->addr_bytes[5]);
> }
> +
> +int __rte_experimental
>
You don't need the experimental tag in the .c.
+ether_unformat_addr(const char *str, struct ether_addr *eth_addr)
> +{
> + return (sscanf(str, "%hhx:%hhx:%hhx:%hhx:%hhx:%hhx",
> + ð_addr->addr_bytes[0],
> + ð_addr->addr_bytes[1],
> + ð_addr->addr_bytes[2],
> + ð_addr->addr_bytes[3],
> + ð_addr->addr_bytes[4],
> + ð_addr->addr_bytes[5]) == 6) ? 0 : -1;
> +}
>
Using scanf this way, you won't detect trailing characters
And I am not sure this format would detect something like:
00:11:22:33:44:555
diff --git a/lib/librte_net/rte_ether.h b/lib/librte_net/rte_ether.h
> index 46d40412763c..b94e64b2195e 100644
> --- a/lib/librte_net/rte_ether.h
> +++ b/lib/librte_net/rte_ether.h
> @@ -248,6 +248,20 @@ void
> ether_format_addr(char *buf, uint16_t size,
> const struct ether_addr *eth_addr);
>
> +/**
> + * Convert string with Ethernet address to an ether_addr.
> + *
> + * @param str
> + * A pointer to buffer contains the formatted MAC address.
> + * @param eth_addr
> + * A pointer to a ether_addr structure.
> + * @return
> + * 0 if successful
> + * -1 and sets rte_errno if invalid string
> + */
> +int __rte_experimental
> +ether_unformat_addr(const char *str, struct ether_addr *eth_addr);
> +
> /**
> * Ethernet header: Contains the destination address, source address
> * and frame type.
> diff --git a/lib/librte_net/rte_net_version.map
> b/lib/librte_net/rte_net_version.map
> index 49d34093781c..bbf14ff1cdfa 100644
> --- a/lib/librte_net/rte_net_version.map
> +++ b/lib/librte_net/rte_net_version.map
> @@ -26,4 +26,5 @@ EXPERIMENTAL {
>
> rte_net_make_rarp_packet;
> rte_net_skip_ip6_ext;
> + eth_unformat_addr;
>
Ditto previous patch, can we prefix this with rte_ ?
--
David Marchand
next prev parent reply other threads:[~2019-05-16 7:28 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-15 22:19 [dpdk-dev] [RFC 0/4] net/ether: improvements Stephen Hemminger
2019-05-15 22:19 ` Stephen Hemminger
2019-05-15 22:19 ` [dpdk-dev] [RFC 1/4] net/ether: deinline non-critical functions Stephen Hemminger
2019-05-15 22:19 ` Stephen Hemminger
2019-05-16 7:10 ` David Marchand
2019-05-16 7:10 ` David Marchand
2019-05-15 22:19 ` [dpdk-dev] [RFC 2/4] net/ether: add eth_unformat_addr Stephen Hemminger
2019-05-15 22:19 ` Stephen Hemminger
2019-05-16 7:28 ` David Marchand [this message]
2019-05-16 7:28 ` David Marchand
2019-05-15 22:19 ` [dpdk-dev] [RFC 3/4] ethdev: use eth_unformat_addr Stephen Hemminger
2019-05-15 22:19 ` Stephen Hemminger
2019-05-16 7:32 ` David Marchand
2019-05-16 7:32 ` David Marchand
2019-05-16 10:19 ` Bruce Richardson
2019-05-16 10:19 ` Bruce Richardson
2019-05-15 22:19 ` [dpdk-dev] [RFC 4/4] net/ether: use bitops to speedup comparison Stephen Hemminger
2019-05-15 22:19 ` Stephen Hemminger
2019-05-16 9:03 ` Mattias Rönnblom
2019-05-16 9:03 ` Mattias Rönnblom
2019-05-16 15:32 ` Stephen Hemminger
2019-05-16 16:03 ` Bruce Richardson
2019-05-16 16:06 ` Stephen Hemminger
2019-05-16 16:07 ` Bruce Richardson
2019-05-16 16:36 ` Bruce Richardson
2019-05-16 17:04 ` Stephen Hemminger
2019-05-16 20:37 ` Bruce Richardson
2019-05-16 20:41 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8yVC9yj2XQdcFp2OCrh27PSYv1KfN9T_Q6Gc7iO54XaEw@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).