DPDK patches and discussions
 help / color / mirror / Atom feed
From: Luca Boccassi <bluca@debian.org>
To: William Tu <u9012063@gmail.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/af_xdp: add libelf for pmd_af_xdp.
Date: Thu, 16 May 2019 09:59:42 +0100	[thread overview]
Message-ID: <16a81a92627551d03e6c7620787468f0e77462fc.camel@debian.org> (raw)
Message-ID: <20190516085942.JkvtWUS2wOBjpn-QVAiW6YmSTv8_g7roit8iDmw0myQ@z> (raw)
In-Reply-To: <1557951879-123265-1-git-send-email-u9012063@gmail.com>

On Wed, 2019-05-15 at 13:24 -0700, William Tu wrote:
> The libbpf requires linking elf library. Fix it by
> adding -lelf.
> 
> Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD")
> Signed-off-by: William Tu <
> u9012063@gmail.com
> >
> ---
>  mk/rte.app.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mk/rte.app.mk b/mk/rte.app.mk
> index 7c9b4b538e52..e5d15218618a 100644
> --- a/mk/rte.app.mk
> +++ b/mk/rte.app.mk
> @@ -145,7 +145,7 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_DPAA2_MEMPOOL)  +=
> -lrte_mempool_dpaa2
>  endif
>  
>  _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET)  += -lrte_pmd_af_packet
> -_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AF_XDP)     += -lrte_pmd_af_xdp
> -lbpf
> +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AF_XDP)     += -lrte_pmd_af_xdp
> -lbpf -lelf
>  _LDLIBS-$(CONFIG_RTE_LIBRTE_ARK_PMD)        += -lrte_pmd_ark
>  _LDLIBS-$(CONFIG_RTE_LIBRTE_ATLANTIC_PMD)   += -lrte_pmd_atlantic
>  _LDLIBS-$(CONFIG_RTE_LIBRTE_AVP_PMD)        += -lrte_pmd_avp

Hi,

This was already discussed, and libbpf needs to link with libelf itself
as it's an internal dependency. It was already fixed in the kernel tree
some time ago, so it should be correct with a recent version. If you
are using an old version you can either update or fix it in your
application. So I don't think we should carry this work-around
ourselves in DPDK, as we'll end up overlinking when using fixed libbpf
versions.

-- 
Kind regards,
Luca Boccassi

  parent reply	other threads:[~2019-05-16  8:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-15 20:24 William Tu
2019-05-15 20:24 ` William Tu
2019-05-16  8:59 ` Luca Boccassi [this message]
2019-05-16  8:59   ` Luca Boccassi
2019-05-16 16:28   ` William Tu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16a81a92627551d03e6c7620787468f0e77462fc.camel@debian.org \
    --to=bluca@debian.org \
    --cc=dev@dpdk.org \
    --cc=u9012063@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).