From: Neil Horman <nhorman@tuxdriver.com>
To: jerinj@marvell.com
Cc: dev@dpdk.org, thomas@monjalon.net, stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] devtools: skip the symbol check when map file under drivers
Date: Tue, 21 May 2019 16:27:04 -0400 [thread overview]
Message-ID: <20190521202704.GA12605@hmswarspite.think-freely.org> (raw)
In-Reply-To: <20190521195628.16355-1-jerinj@marvell.com>
On Wed, May 22, 2019 at 01:26:28AM +0530, jerinj@marvell.com wrote:
> From: Jerin Jacob <jerinj@marvell.com>
>
> Drivers do not have ABI.
> Skip the symbol check if map file under drivers directory.
>
> Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition")
>
> Cc: stable@dpdk.org
> Cc: Neil Horman <nhorman@tuxdriver.com>
>
Sorry, but I'm not ok with this, because many of our DPDK PMDs have functions
that get exported which are meant to be called by applications directly. The
dpaa2 driver is a good example, the cryptodev scheduler is another. Take a look
at their version.map files to see what I mean.
Unless we are willing to make drivers opaque objects that are only accessible
from the [eth|crypto|etc]dev apis in the DPDK core, we have the potential for
exported symbols, which means we have an ABI that has to be maintained, or at
least recognized and reviewed for consistency
Nacked-by: Neil Horman <nhorman@tuxdriver.com>
> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> ---
> devtools/check-symbol-change.sh | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh
> index c5434f3bb..444beddad 100755
> --- a/devtools/check-symbol-change.sh
> +++ b/devtools/check-symbol-change.sh
> @@ -93,6 +93,14 @@ check_for_rule_violations()
> if [ "$ar" = "add" ]
> then
>
> + directory=`echo $mname | cut -d / -f 2`
> + if [ "$directory" = "drivers" ]
> + then
> + # Drivers do not have ABI. Skip further
> + # processing if the map file is under
> + # drivers directory
> + continue
> + fi
> if [ "$secname" = "unknown" ]
> then
> # Just inform the user of this occurrence, but
> --
> 2.21.0
>
>
next prev parent reply other threads:[~2019-05-21 20:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-21 19:56 jerinj
2019-05-21 20:27 ` Neil Horman [this message]
2019-05-22 3:05 ` [dpdk-stable] [EXT] " Jerin Jacob Kollanukkaran
2019-05-22 10:50 ` [dpdk-stable] [dpdk-dev] [EXT] " Bruce Richardson
2019-05-22 12:45 ` [dpdk-stable] [EXT] Re: [dpdk-dev] " Neil Horman
2019-05-22 13:12 [dpdk-stable] " Jerin Jacob Kollanukkaran
2019-05-22 13:40 ` Neil Horman
2019-05-22 14:12 ` Thomas Monjalon
2019-05-22 14:33 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190521202704.GA12605@hmswarspite.think-freely.org \
--to=nhorman@tuxdriver.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).