From: Bruce Richardson <bruce.richardson@intel.com>
To: Igor Ryzhov <iryzhov@nfware.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] kernel/linux: fix modules install path
Date: Mon, 10 Jun 2019 12:12:03 +0100 [thread overview]
Message-ID: <20190610111203.GA1930@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <CAF+s_Fz2xBQNZjS-eBA1sUi2WbePvJSMt9k8YAb5a8qmwWGFoA@mail.gmail.com>
On Mon, Jun 10, 2019 at 02:04:26PM +0300, Igor Ryzhov wrote:
> Bruce,
> From my understanding, kernel_dir is a directory with kernel headers
> needed
> for modules building.
Right now, yes. I'd suggest that we change that to the actual kernel
modules directory, and we get both the build directory and the install
directory based off that.
> When it's formed automatically, yes, it will be
> "/lib/modules/version/build" and we can get installation directory by
> stripping
> "/build".
Well, I'd suggest if we query the value automatically we don't both adding
the build, and just add that later when building the modules, i.e.
kernel_dir should always be the the base directory without "build" on it.
> But when it's set manually, it can be set to, for example,
> "/usr/src/linux-headers-version", and build will be successful, but we
> won't be
> able to strip "/build" as there is no "/build".
> Which path should be used for installation in cross-compile case, when
> the
> kernel_dir is set manually?
The stripping "build" was just a suggestion to allow the value to be
specified either with or without the "build/" suffix and have things work.
For the paths specified in the cross-compile case, my thinking was that we
would:
* build using <kernel_dir>/build
* install to <kernel_dir>/extra/dpdk
as with the non-cross-compile case.
/Bruce
next prev parent reply other threads:[~2019-06-10 11:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-10 8:25 Igor Ryzhov
2019-06-10 9:37 ` Bruce Richardson
2019-06-10 11:04 ` Igor Ryzhov
2019-06-10 11:12 ` Bruce Richardson [this message]
2019-06-10 11:23 ` Igor Ryzhov
2019-06-11 8:49 ` [dpdk-dev] [PATCH v2] " Igor Ryzhov
2019-06-11 10:11 ` Bruce Richardson
2019-06-27 15:34 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190610111203.GA1930@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=iryzhov@nfware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).