From: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
To: honnappa.nagarahalli@arm.com
Cc: dev@dpdk.org, david.marchand@redhat.com, ruifeng.wang@arm.com,
nd@arm.com, stable@dpdk.org
Subject: [dpdk-stable] [PATCH 1/2] test/rcu: increase the size of num cores variable
Date: Thu, 27 Jun 2019 22:44:05 -0500 [thread overview]
Message-ID: <20190628034406.5399-1-honnappa.nagarahalli@arm.com> (raw)
num_cores is of type uint8_t. This results in the following
compilation error.
test_rcu_qsbr_perf.c:649:16: error: comparison is always false
due to limited range of data type [-Werror=type-limits]
if (num_cores >= RTE_MAX_LCORE) {
^~
RTE_MAX_LCORE is set to 256 for armv8 config.
Fixes: e6a14121f4ae ("test/rcu: remove arbitrary limit on max core count")
Cc: stable@dpdk.org
Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
app/test/test_rcu_qsbr.c | 4 ++--
app/test/test_rcu_qsbr_perf.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/app/test/test_rcu_qsbr.c b/app/test/test_rcu_qsbr.c
index 943a1e370..0c6267ee9 100644
--- a/app/test/test_rcu_qsbr.c
+++ b/app/test/test_rcu_qsbr.c
@@ -27,7 +27,7 @@
#define TEST_RCU_QSBR_CNT_INIT 1
uint16_t enabled_core_ids[RTE_MAX_LCORE];
-uint8_t num_cores;
+uint16_t num_cores;
static uint32_t *keys;
#define TOTAL_ENTRY (1024 * 8)
@@ -891,7 +891,7 @@ static int
test_rcu_qsbr_mw_mv_mqs(void)
{
int i, j;
- uint8_t test_cores;
+ uint16_t test_cores;
writer_done = 0;
test_cores = num_cores / 4;
diff --git a/app/test/test_rcu_qsbr_perf.c b/app/test/test_rcu_qsbr_perf.c
index 363365f46..b1a910423 100644
--- a/app/test/test_rcu_qsbr_perf.c
+++ b/app/test/test_rcu_qsbr_perf.c
@@ -17,7 +17,7 @@
/* Check condition and return an error if true. */
static uint16_t enabled_core_ids[RTE_MAX_LCORE];
-static uint8_t num_cores;
+static uint16_t num_cores;
static uint32_t *keys;
#define TOTAL_ENTRY (1024 * 8)
--
2.17.1
next reply other threads:[~2019-06-28 3:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 3:44 Honnappa Nagarahalli [this message]
2019-06-28 3:44 ` [dpdk-stable] [PATCH 2/2] test/rcu: address test case failure Honnappa Nagarahalli
2019-06-28 9:16 ` David Marchand
2019-06-28 13:53 ` Honnappa Nagarahalli
2019-06-28 14:09 ` David Marchand
2019-06-28 16:36 ` Honnappa Nagarahalli
2019-06-28 16:54 ` David Marchand
2019-06-28 9:09 ` [dpdk-stable] [dpdk-dev] [PATCH 1/2] test/rcu: increase the size of num cores variable David Marchand
2019-06-28 13:34 ` Thomas Monjalon
2019-06-28 16:38 ` Honnappa Nagarahalli
2019-06-28 16:35 ` [dpdk-stable] [PATCH v2 " Honnappa Nagarahalli
2019-06-28 16:35 ` [dpdk-stable] [PATCH v2 2/2] test/rcu: address test case failure Honnappa Nagarahalli
2019-06-28 17:11 ` [dpdk-stable] [PATCH v2 1/2] test/rcu: increase the size of num cores variable David Marchand
2019-06-28 18:43 ` [dpdk-stable] [PATCH v3 " Honnappa Nagarahalli
2019-06-28 18:43 ` [dpdk-stable] [PATCH v3 2/2] test/rcu: address test case failure Honnappa Nagarahalli
2019-06-28 18:54 ` [dpdk-stable] [PATCH v3 1/2] test/rcu: increase the size of num cores variable David Marchand
2019-06-29 12:25 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190628034406.5399-1-honnappa.nagarahalli@arm.com \
--to=honnappa.nagarahalli@arm.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=nd@arm.com \
--cc=ruifeng.wang@arm.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).