From: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
To: honnappa.nagarahalli@arm.com
Cc: dev@dpdk.org, david.marchand@redhat.com, thomas@monjalon.net,
ferruh.yigit@intel.com, ruifeng.wang@arm.com, nd@arm.com,
stable@dpdk.org
Subject: [dpdk-stable] [PATCH v3 2/2] test/rcu: address test case failure
Date: Fri, 28 Jun 2019 13:43:42 -0500 [thread overview]
Message-ID: <20190628184342.12260-2-honnappa.nagarahalli@arm.com> (raw)
In-Reply-To: <20190628184342.12260-1-honnappa.nagarahalli@arm.com>
Test case for rte_rcu_qsbr_get_memsize is written specifically
for 128 threads. Do not use RTE_MAX_LCORE as it changes for
different configurations.
Fixes: e6a14121f4ae ("test/rcu: remove arbitrary limit on max core count")
Cc: stable@dpdk.org
Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
Reviewed-by: David Marchand <david.marchand@redhat.com>
---
v3
- None
v2
- Changed the test case result validation (David)
app/test/test_rcu_qsbr.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/app/test/test_rcu_qsbr.c b/app/test/test_rcu_qsbr.c
index ae359a987..1d273e39d 100644
--- a/app/test/test_rcu_qsbr.c
+++ b/app/test/test_rcu_qsbr.c
@@ -89,13 +89,17 @@ test_rcu_qsbr_get_memsize(void)
sz = rte_rcu_qsbr_get_memsize(0);
TEST_RCU_QSBR_RETURN_IF_ERROR((sz != 1), "Get Memsize for 0 threads");
- sz = rte_rcu_qsbr_get_memsize(RTE_MAX_LCORE);
+ sz = rte_rcu_qsbr_get_memsize(128);
/* For 128 threads,
* for machines with cache line size of 64B - 8384
* for machines with cache line size of 128 - 16768
*/
- TEST_RCU_QSBR_RETURN_IF_ERROR((sz != 8384 && sz != 16768),
- "Get Memsize");
+ if (RTE_CACHE_LINE_SIZE == 64)
+ TEST_RCU_QSBR_RETURN_IF_ERROR((sz != 8384),
+ "Get Memsize for 128 threads");
+ else if (RTE_CACHE_LINE_SIZE == 128)
+ TEST_RCU_QSBR_RETURN_IF_ERROR((sz != 16768),
+ "Get Memsize for 128 threads");
return 0;
}
--
2.17.1
next prev parent reply other threads:[~2019-06-28 18:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 3:44 [dpdk-stable] [PATCH 1/2] test/rcu: increase the size of num cores variable Honnappa Nagarahalli
2019-06-28 3:44 ` [dpdk-stable] [PATCH 2/2] test/rcu: address test case failure Honnappa Nagarahalli
2019-06-28 9:16 ` David Marchand
2019-06-28 13:53 ` Honnappa Nagarahalli
2019-06-28 14:09 ` David Marchand
2019-06-28 16:36 ` Honnappa Nagarahalli
2019-06-28 16:54 ` David Marchand
2019-06-28 9:09 ` [dpdk-stable] [dpdk-dev] [PATCH 1/2] test/rcu: increase the size of num cores variable David Marchand
2019-06-28 13:34 ` Thomas Monjalon
2019-06-28 16:38 ` Honnappa Nagarahalli
2019-06-28 16:35 ` [dpdk-stable] [PATCH v2 " Honnappa Nagarahalli
2019-06-28 16:35 ` [dpdk-stable] [PATCH v2 2/2] test/rcu: address test case failure Honnappa Nagarahalli
2019-06-28 17:11 ` [dpdk-stable] [PATCH v2 1/2] test/rcu: increase the size of num cores variable David Marchand
2019-06-28 18:43 ` [dpdk-stable] [PATCH v3 " Honnappa Nagarahalli
2019-06-28 18:43 ` Honnappa Nagarahalli [this message]
2019-06-28 18:54 ` David Marchand
2019-06-29 12:25 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190628184342.12260-2-honnappa.nagarahalli@arm.com \
--to=honnappa.nagarahalli@arm.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=nd@arm.com \
--cc=ruifeng.wang@arm.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).