From: Olivier Matz <olivier.matz@6wind.com>
To: "Morten Brørup" <mb@smartsharesystems.com>
Cc: shahafs@mellanox.com, yskoh@mellanox.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] IPv6 header TC field is 8 (not 4) bits, and also used as DSCP and ECN.
Date: Mon, 1 Jul 2019 15:10:34 +0200 [thread overview]
Message-ID: <20190701131034.rrng76zz2ewgrkz2@platinum> (raw)
In-Reply-To: <1561125938-4414-1-git-send-email-mb@smartsharesystems.com>
Hi Morten,
On Fri, Jun 21, 2019 at 04:05:38PM +0200, Morten Brørup wrote:
> IPv4 header TOS field is also used as DSCP and ECN fields.
>
> Signed-off-by: Morten Brørup <mb@smartsharesystems.com>
> ---
> lib/librte_net/rte_ip.h | 10 ++++++++--
> 1 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_net/rte_ip.h b/lib/librte_net/rte_ip.h
> index ae3b7e7..e69b863 100644
> --- a/lib/librte_net/rte_ip.h
> +++ b/lib/librte_net/rte_ip.h
> @@ -58,6 +58,10 @@ struct rte_ipv4_hdr {
> */
> #define RTE_IPV4_IHL_MULTIPLIER (4)
>
> +/* Type of Service fields */
> +#define RTE_IPV4_HDR_DSCP_MASK (0xfc)
> +#define RTE_IPV4_HDR_ECN_MASK (0x03)
> +
> /* Fragment Offset * Flags. */
> #define RTE_IPV4_HDR_DF_SHIFT 14
> #define RTE_IPV4_HDR_MF_SHIFT 13
> @@ -354,8 +358,10 @@ struct rte_ipv6_hdr {
> /* IPv6 vtc_flow: IPv / TC / flow_label */
> #define RTE_IPV6_HDR_FL_SHIFT 0
> #define RTE_IPV6_HDR_TC_SHIFT 20
> -#define RTE_IPV6_HDR_FL_MASK ((1u << RTE_IPV6_HDR_TC_SHIFT) - 1)
> -#define RTE_IPV6_HDR_TC_MASK (0xf << RTE_IPV6_HDR_TC_SHIFT)
> +#define RTE_IPV6_HDR_FL_MASK ((1u << RTE_IPV6_HDR_TC_SHIFT) - 1)
> +#define RTE_IPV6_HDR_TC_MASK (0xff << RTE_IPV6_HDR_TC_SHIFT)
> +#define RTE_IPV6_HDR_DSCP_MASK (0xfc << RTE_IPV6_HDR_TC_SHIFT)
> +#define RTE_IPV6_HDR_ECN_MASK (0x03 << RTE_IPV6_HDR_TC_SHIFT)
>
> /**
> * Process the pseudo-header checksum of an IPv6 header.
The changes look good to me. Can I however suggest to split the
patch in 2 as below?
- net: fix definition of ipv6 traffic class mask
- net: add definition for dscp and ecn masks
I see that you already CC'd mlx5 maintainers, as the driver uses the
RTE_IPV6_HDR_TC_MASK definition.
Also, it looks that it may conflict with this patch:
https://mails.dpdk.org/archives/dev/2019-July/136575.html
It is maybe preferable to integrate your patchset first, then rebase
Fan's patchset on top of it.
Thanks,
Olivier
prev parent reply other threads:[~2019-07-01 13:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-21 14:05 Morten Brørup
2019-07-01 13:10 ` Olivier Matz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190701131034.rrng76zz2ewgrkz2@platinum \
--to=olivier.matz@6wind.com \
--cc=dev@dpdk.org \
--cc=mb@smartsharesystems.com \
--cc=shahafs@mellanox.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).