From: Bruce Richardson <bruce.richardson@intel.com>
To: David Hunt <david.hunt@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v1] examples/vm_power: fix strcpy buffer overrun
Date: Fri, 12 Jul 2019 15:47:51 +0100 [thread overview]
Message-ID: <20190712144750.GB536@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20190712140402.8492-1-david.hunt@intel.com>
On Fri, Jul 12, 2019 at 03:04:02PM +0100, David Hunt wrote:
> replace strcpy with rte_strlcpy to prevent buffer overrun
> With fix, attempting to use a VERY lonng vm name results in a nicely
> truncated 32 character name rather than a segfault:
> Setting VM Name to [sdfdsfsfsdffdsdsasdsadasdakjshd]
>
> Cc: stable@dpdk.org
> Fixes: 59287933a0bb ("examples/vm_power: add options to guest app")
> Signed-off-by: David Hunt <david.hunt@intel.com>
> ---
> examples/vm_power_manager/guest_cli/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/examples/vm_power_manager/guest_cli/main.c b/examples/vm_power_manager/guest_cli/main.c
> index 36365b124..a18eb214a 100644
> --- a/examples/vm_power_manager/guest_cli/main.c
> +++ b/examples/vm_power_manager/guest_cli/main.c
> @@ -65,7 +65,7 @@ parse_args(int argc, char **argv)
> switch (opt) {
> /* portmask */
> case 'n':
> - strcpy(policy->vm_name, optarg);
> + rte_strlcpy(policy->vm_name, optarg, VM_MAX_NAME_SZ);
> printf("Setting VM Name to [%s]\n", policy->vm_name);
> break;
> case 'b':
> --
You can just use "strlcpy" without the "rte_" prefix. The rte_ version is
just a fallback used when a standard strlcpy - either natively or from
libbsd - is unavailable.
next prev parent reply other threads:[~2019-07-12 14:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-12 14:04 [dpdk-stable] " David Hunt
2019-07-12 14:14 ` [dpdk-stable] [dpdk-dev] " Burakov, Anatoly
2019-07-12 14:47 ` Bruce Richardson [this message]
2019-07-14 13:26 ` Thomas Monjalon
2019-07-16 8:24 ` [dpdk-stable] [PATCH v2] " David Hunt
2019-07-16 11:05 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2019-07-16 11:23 ` Hunt, David
2019-07-16 11:19 ` [dpdk-stable] [PATCH v3] " David Hunt
2019-07-16 11:28 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190712144750.GB536@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).