From: Stephen Hemminger <stephen@networkplumber.org>
To: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
Cc: thomas@monjalon.net, dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH 1/2] timer: fix null pointer dereference
Date: Mon, 15 Jul 2019 08:48:41 -0700 [thread overview]
Message-ID: <20190715084841.4f6baebf@hermes.lan> (raw)
In-Reply-To: <1563205172-352-2-git-send-email-erik.g.carrillo@intel.com>
On Mon, 15 Jul 2019 10:39:31 -0500
Erik Gabriel Carrillo <erik.g.carrillo@intel.com> wrote:
> If the timer subsystem is not initialized before rte_timer_manage (for
> example) is invoked, a pointer to a shared hugepage memory region will
> still be null and dereferenced when it is checked for validity; handle
> this case.
>
> Fixes: c0749f7096c7 ("timer: allow management in shared memory")
> Cc: stable@dpdk.org
>
> Signed-off-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
I have mixed feelings about this patch.
Any calls to rte_timer before rte_timer_subsystem_init is not a
valid usage. Better to kill the application.
next prev parent reply other threads:[~2019-07-15 15:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1563205172-352-1-git-send-email-erik.g.carrillo@intel.com>
2019-07-15 15:39 ` [dpdk-stable] " Erik Gabriel Carrillo
2019-07-15 15:48 ` Stephen Hemminger [this message]
2019-07-15 16:04 ` [dpdk-stable] [dpdk-dev] " Carrillo, Erik G
2019-07-15 15:39 ` [dpdk-stable] [PATCH 2/2] examples/performance-thread: init timer subsystem Erik Gabriel Carrillo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190715084841.4f6baebf@hermes.lan \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=erik.g.carrillo@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).