From: Ye Xiaolong <xiaolong.ye@intel.com>
To: chenxux.di@intel.com
Cc: dev@dpdk.org, Wenzhuo Lu <wenzhuo.lu@intel.com>,
Beilei Xing <beilei.xing@intel.com>,
Qi Zhang <qi.z.zhang@intel.com>,
Yang Qiming <qiming.yang@intel.com>
Subject: Re: [dpdk-dev] [PATCH] drivers/net: release port upon close
Date: Tue, 27 Aug 2019 14:23:17 +0800 [thread overview]
Message-ID: <20190827062317.GB111534@intel.com> (raw)
In-Reply-To: <20190827050142.16010-1-chenxux.di@intel.com>
Hi, chenxu
On 08/27, chenxux.di@intel.com wrote:
>From: Di ChenxuX <chenxux.di@intel.com>
>
>Set RTE_ETH_DEV_CLOSE_REMOVE upon probe so all the private
>resources for the port can be freed by rte_eth_dev_close().
>This patch cover all the intel drivers
>
Just setting RTE_ETH_DEV_CLOSE_REMOVE in probe stage is not enough, you can see
the advice in http://git.dpdk.org/dpdk/commit/?id=23ea57a2a
"When enabling RTE_ETH_DEV_CLOSE_REMOVE, the PMD must free all its private resources for the port
in its dev_close function, it's advised to call the dev_close function in the remove function
in order to support removing a device without closing its ports".
You can refer to other PMD which has finished this transition, like
696202ca5396 ("net/mvpp2: remove resources when port is closed")
Also, I'd suggest to split it to several patches, one patch for one PMD.
Thanks,
Xiaolong
>Signed-off-by: Di ChenxuX <chenxux.di@intel.com>
>---
> drivers/net/e1000/igb_ethdev.c | 5 +++++
> drivers/net/fm10k/fm10k_ethdev.c | 5 +++++
> drivers/net/i40e/i40e_ethdev.c | 5 +++++
> drivers/net/ice/ice_ethdev.c | 5 +++++
> drivers/net/ixgbe/ixgbe_ethdev.c | 5 +++++
> 5 files changed, 25 insertions(+)
>
>diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
>index fec2b4289..fe785d1d7 100644
>--- a/drivers/net/e1000/igb_ethdev.c
>+++ b/drivers/net/e1000/igb_ethdev.c
>@@ -843,6 +843,11 @@ eth_igb_dev_init(struct rte_eth_dev *eth_dev)
> rte_ether_addr_copy((struct rte_ether_addr *)hw->mac.addr,
> ð_dev->data->mac_addrs[0]);
>
>+ /* Pass the information to the rte_eth_dev_close() that it should also
>+ * release the private port resources.
>+ */
>+ dev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;
>+
> /* initialize the vfta */
> memset(shadow_vfta, 0, sizeof(*shadow_vfta));
>
>diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c
>index db4d72129..b5a427c7b 100644
>--- a/drivers/net/fm10k/fm10k_ethdev.c
>+++ b/drivers/net/fm10k/fm10k_ethdev.c
>@@ -3103,6 +3103,11 @@ eth_fm10k_dev_init(struct rte_eth_dev *dev)
> &dev->data->mac_addrs[0]);
> }
>
>+ /* Pass the information to the rte_eth_dev_close() that it should also
>+ * release the private port resources.
>+ */
>+ dev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;
>+
> /* Reset the hw statistics */
> fm10k_stats_reset(dev);
>
>diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
>index 4e40b7ab5..a0536f14c 100644
>--- a/drivers/net/i40e/i40e_ethdev.c
>+++ b/drivers/net/i40e/i40e_ethdev.c
>@@ -1520,6 +1520,11 @@ eth_i40e_dev_init(struct rte_eth_dev *dev, void *init_params __rte_unused)
> rte_ether_addr_copy((struct rte_ether_addr *)hw->mac.perm_addr,
> &dev->data->mac_addrs[0]);
>
>+ /* Pass the information to the rte_eth_dev_close() that it should also
>+ * release the private port resources.
>+ */
>+ dev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;
>+
> /* Init dcb to sw mode by default */
> ret = i40e_dcb_init_configure(dev, TRUE);
> if (ret != I40E_SUCCESS) {
>diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
>index 44a14cb8a..476c768ee 100644
>--- a/drivers/net/ice/ice_ethdev.c
>+++ b/drivers/net/ice/ice_ethdev.c
>@@ -1488,6 +1488,11 @@ ice_dev_init(struct rte_eth_dev *dev)
> goto err_init_mac;
> }
>
>+ /* Pass the information to the rte_eth_dev_close() that it should also
>+ * release the private port resources.
>+ */
>+ dev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;
>+
> ret = ice_res_pool_init(&pf->msix_pool, 1,
> hw->func_caps.common_cap.num_msix_vectors - 1);
> if (ret) {
>diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
>index 03fc1f717..3e2b537ec 100644
>--- a/drivers/net/ixgbe/ixgbe_ethdev.c
>+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
>@@ -1245,6 +1245,11 @@ eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev, void *init_params __rte_unused)
> return -ENOMEM;
> }
>
>+ /* Pass the information to the rte_eth_dev_close() that it should also
>+ * release the private port resources.
>+ */
>+ dev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;
>+
> /* initialize the vfta */
> memset(shadow_vfta, 0, sizeof(*shadow_vfta));
>
>--
>2.17.1
>
next prev parent reply other threads:[~2019-08-27 6:24 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 5:01 chenxux.di
2019-08-27 6:23 ` Ye Xiaolong [this message]
2019-09-05 11:03 ` [dpdk-dev] [PATCH v3 0/5] " Di ChenxuX
2019-09-05 11:03 ` [dpdk-dev] [PATCH v3 1/5] net/e1000: " Di ChenxuX
2019-09-05 11:03 ` [dpdk-dev] [PATCH v3 2/5] net/fm10k: " Di ChenxuX
2019-09-05 11:03 ` [dpdk-dev] [PATCH v3 3/5] net/i40e: " Di ChenxuX
2019-09-05 11:03 ` [dpdk-dev] [PATCH v3 4/5] net/ice: " Di ChenxuX
2019-09-05 11:03 ` [dpdk-dev] [PATCH v3 5/5] net/ixgbe: " Di ChenxuX
2019-09-19 2:47 ` [dpdk-dev] [PATCH v4 0/5] drivers/net: " Di ChenxuX
2019-09-19 2:47 ` [dpdk-dev] [PATCH v4 1/5] net/e1000: " Di ChenxuX
2019-09-25 15:41 ` Ye Xiaolong
2019-09-26 3:21 ` Di, ChenxuX
2019-09-19 2:47 ` [dpdk-dev] [PATCH v4 2/5] net/fm10k: " Di ChenxuX
2019-09-19 2:47 ` [dpdk-dev] [PATCH v4 3/5] net/i40e: " Di ChenxuX
2019-09-19 2:47 ` [dpdk-dev] [PATCH v4 4/5] net/ice: " Di ChenxuX
2019-09-19 2:47 ` [dpdk-dev] [PATCH v4 5/5] net/ixgbe: " Di ChenxuX
2019-09-23 2:27 ` [dpdk-dev] [PATCH v4 0/5] drivers/net: " Yang, Qiming
2019-09-26 7:30 ` [dpdk-dev] [PATCH v5 " Di ChenxuX
2019-09-26 7:30 ` [dpdk-dev] [PATCH v5 1/5] net/e1000: " Di ChenxuX
2019-09-26 7:30 ` [dpdk-dev] [PATCH v5 2/5] net/fm10k: " Di ChenxuX
2019-09-26 7:30 ` [dpdk-dev] [PATCH v5 3/5] net/i40e: " Di ChenxuX
2019-09-26 7:30 ` [dpdk-dev] [PATCH v5 4/5] net/ice: " Di ChenxuX
2019-09-26 7:30 ` [dpdk-dev] [PATCH v5 5/5] net/ixgbe: " Di ChenxuX
2019-09-26 10:42 ` [dpdk-dev] [PATCH v5 0/5] drivers/net: " Ye Xiaolong
2019-09-26 10:00 ` [dpdk-dev] [PATCH v6 " Di ChenxuX
2019-09-26 10:00 ` [dpdk-dev] [PATCH v6 1/5] net/e1000: " Di ChenxuX
2019-09-26 10:00 ` [dpdk-dev] [PATCH v6 2/5] net/fm10k: " Di ChenxuX
2019-09-26 10:00 ` [dpdk-dev] [PATCH v6 3/5] net/i40e: " Di ChenxuX
2019-09-26 10:00 ` [dpdk-dev] [PATCH v6 4/5] net/ice: " Di ChenxuX
2019-09-26 10:00 ` [dpdk-dev] [PATCH v6 5/5] net/ixgbe: " Di ChenxuX
2019-09-27 2:46 ` [dpdk-dev] [PATCH v6 0/5] drivers/net: " Yang, Qiming
2019-09-27 9:09 ` [dpdk-dev] [PATCH v7 " Di ChenxuX
2019-09-27 9:09 ` [dpdk-dev] [PATCH v7 1/5] net/e1000: " Di ChenxuX
2019-09-27 9:09 ` [dpdk-dev] [PATCH v7 2/5] net/fm10k: " Di ChenxuX
2019-09-27 9:09 ` [dpdk-dev] [PATCH v7 3/5] net/i40e: " Di ChenxuX
2019-09-27 9:09 ` [dpdk-dev] [PATCH v7 4/5] net/ice: " Di ChenxuX
2019-09-27 9:09 ` [dpdk-dev] [PATCH v7 5/5] net/ixgbe: " Di ChenxuX
2019-09-27 10:50 ` [dpdk-dev] [PATCH v7 0/5] drivers/net: " Ye Xiaolong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190827062317.GB111534@intel.com \
--to=xiaolong.ye@intel.com \
--cc=beilei.xing@intel.com \
--cc=chenxux.di@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).