From: Stephen Hemminger <stephen@networkplumber.org>
To: "Morten Brørup" <mb@smartsharesystems.com>
Cc: "Thomas Monjalon" <thomas@monjalon.net>, <checkpatch@dpdk.org>,
<test-report@dpdk.org>, "dpdk-dev" <dev@dpdk.org>
Subject: Re: [dpdk-test-report] [dpdk-dev] |WARNING| pw59738 [PATCH v2 2/2] mbuf: add bulk free function
Date: Wed, 25 Sep 2019 16:37:01 -0700 [thread overview]
Message-ID: <20190925163701.78c09842@hermes.lan> (raw)
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35B42ACC@smartserver.smartshare.dk>
On Wed, 25 Sep 2019 14:17:42 +0200
Morten Brørup <mb@smartsharesystems.com> wrote:
> Dear Thomas - listed as checkpatch maintainer,
>
> I think this warning is bogus, and is a bug checkpatch.
>
> The line in question was deliberately indented using tabs to the current indentation level, and using spaces for the readability alignment. This makes the code readable in editors with another tab setting than 8 spaces. E.g. 4 spaces is my personal preference.
>
>
> Med venlig hilsen / kind regards
> - Morten Brørup
It is understandable that you have personal preferences, but projects like DPDK rely
on common style across all code. The collective decision has been made to keep a
uniform style similar to the Linux kernel.
No it is not a bug in checkpatch.
next prev parent reply other threads:[~2019-10-02 13:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190925120355.44821-3-mb@smartsharesystems.com>
2019-09-25 12:05 ` [dpdk-test-report] " checkpatch
2019-09-25 12:17 ` Morten Brørup
2019-09-25 23:37 ` Stephen Hemminger [this message]
2019-09-27 6:42 ` [dpdk-test-report] [dpdk-dev] " Morten Brørup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190925163701.78c09842@hermes.lan \
--to=stephen@networkplumber.org \
--cc=checkpatch@dpdk.org \
--cc=dev@dpdk.org \
--cc=mb@smartsharesystems.com \
--cc=test-report@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).